[GitHub] spark pull request: [SPARK-3636][CORE]:It is not friendly to inter...

2014-09-23 Thread uncleGen
Github user uncleGen closed the pull request at:

https://github.com/apache/spark/pull/2488


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-3636][CORE]:It is not friendly to inter...

2014-09-23 Thread uncleGen
Github user uncleGen commented on the pull request:

https://github.com/apache/spark/pull/2488#issuecomment-56505578
  
@pwendell ah, make sense, I will close this PR. Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-3636][CORE]:It is not friendly to inter...

2014-09-22 Thread pwendell
Github user pwendell commented on the pull request:

https://github.com/apache/spark/pull/2488#issuecomment-56446727
  
On this one, I would prefer the current approach of failing loudly rather 
than to silently continue. Existing users might also be depending on this 
behavior (e.g. they guard this in a try-catch) and for them this would break 
their code. Users who want to ignore this error can use a try/catch or a `Try` 
block in scala.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-3636][CORE]:It is not friendly to inter...

2014-09-22 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2488#issuecomment-56357881
  
  [QA tests have 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20652/consoleFull)
 for   PR 2488 at commit 
[`0e3831c`](https://github.com/apache/spark/commit/0e3831cc56f2532d5fdd8500b26dfe34a62069cd).
 * This patch **passes** unit tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-3636][CORE]:It is not friendly to inter...

2014-09-22 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2488#issuecomment-56351578
  
  [QA tests have 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20652/consoleFull)
 for   PR 2488 at commit 
[`0e3831c`](https://github.com/apache/spark/commit/0e3831cc56f2532d5fdd8500b26dfe34a62069cd).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-3636][CORE]:It is not friendly to inter...

2014-09-22 Thread uncleGen
GitHub user uncleGen opened a pull request:

https://github.com/apache/spark/pull/2488

[SPARK-3636][CORE]:It is not friendly to interrupt a Job when user passe...

... different storageLevels to a RDD

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/uncleGen/spark master-minorfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/2488.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2488


commit 0e3831cc56f2532d5fdd8500b26dfe34a62069cd
Author: uncleGen 
Date:   2014-09-22T09:48:29Z

[SPARK-3636][CORE]:It is not friendly to interrupt a Job when user passe 
different storageLevels to a RDD




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org