[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-67081829 Looks good - thanks @ryan-williams I can pull it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3523 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user ryan-williams commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-66690786 thanks @pwendell, I simplified the description and provided some example code, lmk if that's better --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-66691577 [Test build #24379 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24379/consoleFull) for PR 3523 at commit [`d2eddaa`](https://github.com/apache/spark/commit/d2eddaa8ff01425d1ebe827b5abb9e711e1d71a6). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-66703368 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24379/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-66703359 [Test build #24379 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24379/consoleFull) for PR 3523 at commit [`d2eddaa`](https://github.com/apache/spark/commit/d2eddaa8ff01425d1ebe827b5abb9e711e1d71a6). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/3523#discussion_r21643415 --- Diff: docs/building-spark.md --- @@ -145,7 +145,15 @@ We use the scala-maven-plugin which supports incremental and continuous compilat mvn scala:cc -should run continuous compilation (i.e. wait for changes). However, this has not been tested extensively. +should run continuous compilation (i.e. wait for changes). However, this has not been tested +extensively. A couple of gotchas to note: +* it only scans the paths `src/main` and `src/test` (see +[docs](http://scala-tools.org/mvnsites/maven-scala-plugin/usage_cc.html)), so it will only work +from within certain submodules that have that structure. +* compiling submodules that depend on other submodules (e.g. `core`, which depends on `network/common` and `network/shuffle`) requires those dependencies --- End diff -- This is a pretty complicated description. Instead can we just say that this requires first running mvn install? Or even just do a mvn install in the code example above before you run it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-66535952 I had one comment about the building stuff, but otherwise looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65836128 [Test build #24186 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24186/consoleFull) for PR 3523 at commit [`a4409be`](https://github.com/apache/spark/commit/a4409bed00c86cd33df298a6d116ed980c6b78a1). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65837247 [Test build #24187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24187/consoleFull) for PR 3523 at commit [`05a3113`](https://github.com/apache/spark/commit/05a31132bc15d98b9a831917007b34afd87e2c55). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65847289 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24186/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65847280 [Test build #24186 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24186/consoleFull) for PR 3523 at commit [`a4409be`](https://github.com/apache/spark/commit/a4409bed00c86cd33df298a6d116ed980c6b78a1). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65848971 [Test build #24187 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24187/consoleFull) for PR 3523 at commit [`05a3113`](https://github.com/apache/spark/commit/05a31132bc15d98b9a831917007b34afd87e2c55). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65848977 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24187/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user ryan-williams commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65716929 added some more documentation typo fixes and added parameter names to a few unmarked booleans, for clarity --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65737314 Jenkins, add to whitelist. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65737592 [Test build #24158 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24158/consoleFull) for PR 3523 at commit [`b85dc5b`](https://github.com/apache/spark/commit/b85dc5bed3df4208031ddf30117ef3ea4fed70c9). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65737697 [Test build #24158 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24158/consoleFull) for PR 3523 at commit [`b85dc5b`](https://github.com/apache/spark/commit/b85dc5bed3df4208031ddf30117ef3ea4fed70c9). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65737699 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24158/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3523#discussion_r21353961
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -156,7 +156,7 @@ object SparkEnv extends Logging {
assert(conf.contains(spark.driver.port), spark.driver.port is not
set on the driver!)
val hostname = conf.get(spark.driver.host)
val port = conf.get(spark.driver.port).toInt
-create(conf, SparkContext.DRIVER_IDENTIFIER, hostname, port, true,
isLocal, listenerBus)
+create(conf, SparkContext.DRIVER_IDENTIFIER, hostname, port, isDriver
= true, isLocal, listenerBus)
--- End diff --
This line failed `scalastyle` because it's too long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3523#discussion_r21353966
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -171,7 +171,7 @@ object SparkEnv extends Logging {
numCores: Int,
isLocal: Boolean,
actorSystem: ActorSystem = null): SparkEnv = {
-create(conf, executorId, hostname, port, false, isLocal,
defaultActorSystem = actorSystem,
+create(conf, executorId, hostname, port, isDriver = false, isLocal,
defaultActorSystem = actorSystem,
--- End diff --
Same here; this is 100 characters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65040128 Not sure if it's easy, but most of the diff is inadvertent changes to whitespace at the end of lines. This makes it a little hard to see the changes you're making since they're not otherwise enumerated here or in the JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user ryan-williams commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65094220 I can split out the whitespace changes, or expand the declared scope of the PR/JIRA to include removing trailing whitespaces; which would you prefer? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65094829 I figure it's best not to change those at all. It'll probably get added back by an IDE and very very slightly increases the chance of a spurious merge conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user ryan-williams commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65095213 why would specific instances of trailing whitespaces get added back by an IDE? I thought it was considered universally desirable to not leave trailing whitespaces on the ends of lines. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user ryan-williams commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65024489 addressed comments. also, I can no longer find the version of `configuration.html` that I was looking at that had the `extraJavaOptions` section duplicated... strange. In any case I took that bit out of this PR, it was wrong. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4668] Fix some documentation typos.
Github user ryan-williams commented on the pull request: https://github.com/apache/spark/pull/3523#issuecomment-65024591 also filed [SPARK-4668](https://issues.apache.org/jira/browse/SPARK-4668) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
