[GitHub] spark pull request: [SPARK-4920][UI] add version on master and wor...

2014-12-30 Thread JoshRosen
Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/3769#issuecomment-68376239
  
Actually, it looks like there are other patches that need to be 
cherry-picked before this can be pulled into `branch-1.1` (1.1.2) and 
`branch-1.0` (1.0.3); I'll tag this in JIRA for followup and handle it myself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4920][UI] add version on master and wor...

2014-12-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/3769


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4920][UI] add version on master and wor...

2014-12-30 Thread JoshRosen
Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/3769#issuecomment-68375782
  
I've made the SPARK_VERSION change in the maintenance branches, so I'm now 
going to merge this into `master` (1.3.0), `branch-1.2` (1.2.1), `branch-1.1` 
(1.1.2), and `branch-1.0` (1.0.3).  Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4920][UI] add version on master and wor...

2014-12-29 Thread JoshRosen
Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/3769#issuecomment-68332339
  
This looks good to me, so I'll merge it.  Thanks for the reminder.

Before I merge this, though, I'm going to hotfix the package-level 
SPARK_VERSION into the backport branches, since I accidentally broke those 
builds the last time I merged a fix using org.apache.spark.SPARK_VERSION.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4920][UI] add version on master and wor...

2014-12-29 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request:

https://github.com/apache/spark/pull/3769#issuecomment-68329234
  
@JoshRosen , is this PR ready to merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4920][UI] add version on master and wor...

2014-12-23 Thread JoshRosen
Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/3769#issuecomment-67990199
  
Here's a screenshot of what this looks like on various pages:

## Master:


![image](https://cloud.githubusercontent.com/assets/50748/5542170/d32fb724-8a97-11e4-883d-4a250ef6a512.png)

## Log viewer:

![image](https://cloud.githubusercontent.com/assets/50748/5542173/e95c0bc4-8a97-11e4-8278-58ec056b8c23.png)

## Worker:

![image](https://cloud.githubusercontent.com/assets/50748/5542179/f626317c-8a97-11e4-8dd7-89b6d786f5de.png)

## Before:

Here's what it looked like before:


![image](https://cloud.githubusercontent.com/assets/50748/5542194/5f93bbd4-8a98-11e4-80b5-c6f4ab57e7fd.png)

I think the extra horizontal space looks a little odd, but that's only 
because I'm using a SNAPSHOT version; it should look fine for releases.  
Therefore, I'm inclined to merge this unless anyone has objections.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4920][UI] add version on master and wor...

2014-12-22 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/3769#issuecomment-67921646
  
  [Test build #24722 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24722/consoleFull)
 for   PR 3769 at commit 
[`3bb7e0d`](https://github.com/apache/spark/commit/3bb7e0d9a19fa373eb257c4b3d83ce730ce63c65).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4920][UI] add version on master and wor...

2014-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/3769#issuecomment-67921648
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24722/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4920][UI] add version on master and wor...

2014-12-22 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/3769#issuecomment-67918375
  
  [Test build #24722 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24722/consoleFull)
 for   PR 3769 at commit 
[`3bb7e0d`](https://github.com/apache/spark/commit/3bb7e0d9a19fa373eb257c4b3d83ce730ce63c65).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4920][UI] add version on master and wor...

2014-12-22 Thread liyezhang556520
GitHub user liyezhang556520 opened a pull request:

https://github.com/apache/spark/pull/3769

[SPARK-4920][UI] add version on master and worker page for standalone mode



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liyezhang556520/spark spark-4920_WebVersion

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/3769.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3769


commit 3bb7e0d9a19fa373eb257c4b3d83ce730ce63c65
Author: Zhang, Liye 
Date:   2014-12-23T03:19:14Z

add version on master and worker page




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org