[GitHub] spark pull request: [SPARK-5429][SQL] Use javaXML plan serializati...

[marmbrus]

Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/4223#issuecomment-72149682
  
Ah, thanks for investigating.
On Jan 29, 2015 7:41 PM, "Liang-Chi Hsieh"  wrote:

> @marmbrus  I checked it again. Actually it
> works because we set it directly on hiveconf. So it is not kept in
> SessionState.getOverriddenConfigurations and is not affected by RESET
> command.
>
> —
> Reply to this email directly or view it on GitHub
> .
>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-5429][SQL] Use javaXML plan serializati...

[viirya]

Github user viirya commented on the pull request:

https://github.com/apache/spark/pull/4223#issuecomment-72149504
  
@marmbrus I checked it again. Actually it works because we set it directly 
on `hiveconf`. So it is not kept in `SessionState.getOverriddenConfigurations` 
and is not affected by `RESET` command.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-5429][SQL] Use javaXML plan serializati...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/4223


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-5429][SQL] Use javaXML plan serializati...

[marmbrus]

Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/4223#issuecomment-72125594
  
Confirmed this works locally.  This is awesome, thanks!

Merging to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-5429][SQL] Use javaXML plan serializati...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/4223#issuecomment-71963496
  
I am going to let @marmbrus to comment on this one ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-5429][SQL] Use javaXML plan serializati...

[viirya]

Github user viirya commented on the pull request:

https://github.com/apache/spark/pull/4223#issuecomment-71958179
  
@rxin This is a quick fix for the problem when generating Hive golden 
answer files on Hive 0.13.1. Do not know if it is useful for others. It would 
be great if you can look at this. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-5429][SQL] Use javaXML plan serializati...

[marmbrus]

Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/4223#issuecomment-71963599
  
The root cause is likely you aren't using the "right" version of hive.  
Where right means our hacked version that has a version of kryo that doesn't 
conflict with spark.

That said... this looks like a much better solution.  LGTM pending local 
testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-5429][SQL] Use javaXML plan serializati...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4223#issuecomment-71698918
  
  [Test build #26167 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26167/consoleFull)
 for   PR 4223 at commit 
[`97a8760`](https://github.com/apache/spark/commit/97a8760f6c8713af581b95f05d11e8d11f331246).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-5429][SQL] Use javaXML plan serializati...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4223#issuecomment-71698923
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26167/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-5429][SQL] Use javaXML plan serializati...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4223#issuecomment-71686488
  
  [Test build #26167 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26167/consoleFull)
 for   PR 4223 at commit 
[`97a8760`](https://github.com/apache/spark/commit/97a8760f6c8713af581b95f05d11e8d11f331246).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org