[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/1395


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[pwendell]

Github user pwendell commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-56624824
  
Go for it @tdas!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-56576026
  
@JoshRosen @pwendell If you dont have any objections on this addition to 
Spark core, I will merge this PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-55940929
  
  [QA tests have 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/127/consoleFull)
 for   PR 1395 at commit 
[`1f5595c`](https://github.com/apache/spark/commit/1f5595c19fe024d5eac6a56d639e9409541e3820).
 * This patch **passes** unit tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-55931130
  
  [QA tests have 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/127/consoleFull)
 for   PR 1395 at commit 
[`1f5595c`](https://github.com/apache/spark/commit/1f5595c19fe024d5eac6a56d639e9409541e3820).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54910020
  
  [QA tests have 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4/consoleFull)
 for   PR 1395 at commit 
[`1f5595c`](https://github.com/apache/spark/commit/1f5595c19fe024d5eac6a56d639e9409541e3820).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54899548
  
  [QA tests have 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19996/consoleFull)
 for   PR 1395 at commit 
[`1f5595c`](https://github.com/apache/spark/commit/1f5595c19fe024d5eac6a56d639e9409541e3820).
 * This patch **passes** unit tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54892709
  
  [QA tests have 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19996/consoleFull)
 for   PR 1395 at commit 
[`1f5595c`](https://github.com/apache/spark/commit/1f5595c19fe024d5eac6a56d639e9409541e3820).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[davies]

Github user davies commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54886261
  
Jenkins, retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[staple]

Github user staple commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54856229
  
Sure, I fixed the new python style issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[davies]

Github user davies commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54854991
  
@staple Could you fix the PEP8 style?

./python/pyspark/join.py:98:1: E302 expected 2 blank lines, found 1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54782006
  
  [QA tests have 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19965/consoleFull)
 for   PR 1395 at commit 
[`084b2d5`](https://github.com/apache/spark/commit/084b2d5edda993975ae2c1794ef8bf4dea2ae11b).
 * This patch **fails** unit tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54781953
  
  [QA tests have 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19965/consoleFull)
 for   PR 1395 at commit 
[`084b2d5`](https://github.com/apache/spark/commit/084b2d5edda993975ae2c1794ef8bf4dea2ae11b).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[pwendell]

Github user pwendell commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54780426
  
Jenkins, test this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54694594
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[JoshRosen]

Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54397669
  
From a cursory look, the Java API part of this looks fine to me, since the 
type signatures of the new methods are the same as existing Java API methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[JoshRosen]

Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54397314
  
It looks like this was last tested a really long time ago, so I'm concerned 
that it might fail some of the style checks.  Therefore:

Jenkins, retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54397226
  
I am good to go with this. Need someone to sign off from the RDD and core
point of view.


On Wed, Sep 3, 2014 at 7:44 PM, Josh Rosen  wrote:

> Bump @tdas  @pwendell
> . Does this look okay to you?
>
> —
> Reply to this email directly or view it on GitHub
> .
>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[JoshRosen]

Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54397141
  
Bump @tdas @pwendell.  Does this look okay to you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[davies]

Github user davies commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-54210052
  
+1, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-50685669
  
Also adding @rxin since he reported the JIRA


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[staple]

Github user staple commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-50684019
  
Cool, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-50683785
  
Oh yeah, right about the python tests. My bad. I will let @pwendell  chime 
in about the Spark RDD api.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[staple]

Github user staple commented on a diff in the pull request:

https://github.com/apache/spark/pull/1395#discussion_r15614024
  
--- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaPairDStream.scala
 ---
@@ -659,6 +659,52 @@ class JavaPairDStream[K, V](val dstream: DStream[(K, 
V)])(
   }
 
   /**
+   * Return a new DStream by applying 'full outer join' between RDDs of 
`this` DStream and
+   * `other` DStream. Hash partitioning is used to generate the RDDs with 
Spark's default
+   * number of partitions.
+   */
+  def fullOuterJoin[W](other: JavaPairDStream[K, W])
+  : JavaPairDStream[K, (Optional[V], Optional[W])] = {
--- End diff --

No worries :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[tdas]

Github user tdas commented on a diff in the pull request:

https://github.com/apache/spark/pull/1395#discussion_r15613724
  
--- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaPairDStream.scala
 ---
@@ -659,6 +659,52 @@ class JavaPairDStream[K, V](val dstream: DStream[(K, 
V)])(
   }
 
   /**
+   * Return a new DStream by applying 'full outer join' between RDDs of 
`this` DStream and
+   * `other` DStream. Hash partitioning is used to generate the RDDs with 
Spark's default
+   * number of partitions.
+   */
+  def fullOuterJoin[W](other: JavaPairDStream[K, W])
+  : JavaPairDStream[K, (Optional[V], Optional[W])] = {
--- End diff --

Aaargh. My visual estimation failed. :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[staple]

Github user staple commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-50675424
  
Thanks for taking a look.  The example provided in the descriptive comment 
for rdd.py's fullOuterJoin implementation will be executed and checked as part 
of the python test suite.  Any other concerns?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[staple]

Github user staple commented on a diff in the pull request:

https://github.com/apache/spark/pull/1395#discussion_r15609908
  
--- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaPairDStream.scala
 ---
@@ -659,6 +659,52 @@ class JavaPairDStream[K, V](val dstream: DStream[(K, 
V)])(
   }
 
   /**
+   * Return a new DStream by applying 'full outer join' between RDDs of 
`this` DStream and
+   * `other` DStream. Hash partitioning is used to generate the RDDs with 
Spark's default
+   * number of partitions.
+   */
+  def fullOuterJoin[W](other: JavaPairDStream[K, W])
+  : JavaPairDStream[K, (Optional[V], Optional[W])] = {
--- End diff --

It's slightly over the limit at 103 characters


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-50673558
  
QA results for PR 1395:- This patch PASSES unit tests.- This patch 
merges cleanly- This patch adds no public classesFor more 
information see test 
ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17469/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-50667136
  
This looks pretty good to me. However, I dont see a python unit test. Can 
you add that? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[tdas]

Github user tdas commented on a diff in the pull request:

https://github.com/apache/spark/pull/1395#discussion_r15606130
  
--- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaPairDStream.scala
 ---
@@ -659,6 +659,52 @@ class JavaPairDStream[K, V](val dstream: DStream[(K, 
V)])(
   }
 
   /**
+   * Return a new DStream by applying 'full outer join' between RDDs of 
`this` DStream and
+   * `other` DStream. Hash partitioning is used to generate the RDDs with 
Spark's default
+   * number of partitions.
+   */
+  def fullOuterJoin[W](other: JavaPairDStream[K, W])
+  : JavaPairDStream[K, (Optional[V], Optional[W])] = {
--- End diff --

This does not need to be on the next line. It fits in the previous line I 
think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-50666418
  
QA tests have started for PR 1395. This patch merges cleanly. View 
progress: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17469/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-50665916
  
@pwendell This patch involves the core RDD API as well. Can you take a look 
as well? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-50665813
  
Jenkins, test this please.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-50665795
  
Jenkins, this is ok to test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1395#issuecomment-48851025
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-546] Add full outer join to RDD and DSt...

[staple]

GitHub user staple opened a pull request:

https://github.com/apache/spark/pull/1395

[SPARK-546] Add full outer join to RDD and DStream.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/staple/spark SPARK-546

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/1395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1395


commit 0575e2f45ec26eddf7470cc9fc67f52fc53120ff
Author: Aaron Staple 
Date:   2014-07-13T18:19:03Z

Fix left outer join documentation comments.

commit 217614dbe4540bb8155e3fbb6eae56f70795b28d
Author: Aaron Staple 
Date:   2014-07-13T18:19:03Z

In JavaPairDStream, make class tag specification in rightOuterJoin 
consistent with other functions.

commit 084b2d5edda993975ae2c1794ef8bf4dea2ae11b
Author: Aaron Staple 
Date:   2014-07-13T18:19:03Z

[SPARK-546] Add full outer join to RDD and DStream.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---