[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/spark/pull/6983#discussion_r42723887
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -324,20 +324,6 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
| FROM src LIMIT 1
""".stripMargin)
- createQueryTest("Date comparison test 2",
-"SELECT CAST(CAST(0 AS timestamp) AS date) > CAST(0 AS timestamp) FROM
src LIMIT 1")
--- End diff --
```
override def beforeAll() {
...
TimeZone.setDefault(TimeZone.getTimeZone("America/Los_Angeles"))
```
- before my fix, both Spark (1.4) and Hive (0.13) returned `true`
- after my fix, Spark (1.5) returned `false` and Hive (0.13) returned
`true` (that's why we removed it)
- since Spark (1.5) later moved to Hive 1.2.1 now, both Spark and Hive
return `false`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6983#discussion_r42717418
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -324,20 +324,6 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
| FROM src LIMIT 1
""".stripMargin)
- createQueryTest("Date comparison test 2",
-"SELECT CAST(CAST(0 AS timestamp) AS date) > CAST(0 AS timestamp) FROM
src LIMIT 1")
--- End diff --
That's true, but there is a setting in beforeAll, so spark should produce
same result in regard of your system timezone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/spark/pull/6983#discussion_r42717075
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -324,20 +324,6 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
| FROM src LIMIT 1
""".stripMargin)
- createQueryTest("Date comparison test 2",
-"SELECT CAST(CAST(0 AS timestamp) AS date) > CAST(0 AS timestamp) FROM
src LIMIT 1")
--- End diff --
depends on the system time zone, it should be ...
- West of GMT `daysSinceEpoch` is `-1`
- East of GMT `daysSinceEpoch` is `0`
```
"CAST(0 AS timestamp)" --> "1 Jan 1970 00:00:00 GMT"
"CAST(0 AS timestamp)" --> "31 Dec 1969 16:00:00 PST"
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6983#discussion_r42579245
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -324,20 +324,6 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
| FROM src LIMIT 1
""".stripMargin)
- createQueryTest("Date comparison test 2",
-"SELECT CAST(CAST(0 AS timestamp) AS date) > CAST(0 AS timestamp) FROM
src LIMIT 1")
--- End diff --
I mean, the bug of Hive only affects those whose `daysSinceEpoch` is
negative, but test cases here should yield Date values whose `daysSinceEpoch`
is 0, so these cases shouldn't be affected by this bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6983#discussion_r42457735
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -324,20 +324,6 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
| FROM src LIMIT 1
""".stripMargin)
- createQueryTest("Date comparison test 2",
-"SELECT CAST(CAST(0 AS timestamp) AS date) > CAST(0 AS timestamp) FROM
src LIMIT 1")
--- End diff --
but these cases are non-negative?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user ckadner commented on a diff in the pull request:
https://github.com/apache/spark/pull/6983#discussion_r42408083
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -324,20 +324,6 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
| FROM src LIMIT 1
""".stripMargin)
- createQueryTest("Date comparison test 2",
-"SELECT CAST(CAST(0 AS timestamp) AS date) > CAST(0 AS timestamp) FROM
src LIMIT 1")
--- End diff --
@adrian-wang at the time of [this
fix](https://issues.apache.org/jira/browse/SPARK-6785), Spark was using Hive
v0.13, which suffered from the same bug
([HIVE-10178](https://issues.apache.org/jira/browse/HIVE-10178)) and this test
case did no longer test for equivalent behavior between Hive and Spark. Please
see https://github.com/apache/spark/pull/6242#issuecomment-103670515 (and
following) for the discussion about removing this test case.
Since Spark is now on Hive 1.2.1 and
[HIVE-10178](https://issues.apache.org/jira/browse/HIVE-10178) was fixed in
Hive 1.2, we could consider re-introducing this test case to the
`HiveQuerySuite` (@marmbrus ?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6983#discussion_r42337999
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -324,20 +324,6 @@ class HiveQuerySuite extends HiveComparisonTest with
BeforeAndAfter {
| FROM src LIMIT 1
""".stripMargin)
- createQueryTest("Date comparison test 2",
-"SELECT CAST(CAST(0 AS timestamp) AS date) > CAST(0 AS timestamp) FROM
src LIMIT 1")
--- End diff --
@ckadner why do we remove this?
I think we have handled time zone issue in `beforeAll()`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user ckadner commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-11732 Thanks Michael! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6983 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-117312278 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user ckadner commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116955196 @squito - thx 4 your comments! :+1: @marmbrus - back to you -- thx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116945221 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116944872 [Test build #36066 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36066/console) for PR 6983 at commit [`ab1e79b`](https://github.com/apache/spark/commit/ab1e79b86be00fcfd93c3d746d0a120d3c98a99d). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116912881 [Test build #36066 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36066/consoleFull) for PR 6983 at commit [`ab1e79b`](https://github.com/apache/spark/commit/ab1e79b86be00fcfd93c3d746d0a120d3c98a99d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116912757 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116912751 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116910721 [Test build #36064 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36064/console) for PR 6983 at commit [`9d8021d`](https://github.com/apache/spark/commit/9d8021d631c8e61bcb0599becd2248363864577c). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116910724 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116910563 [Test build #36064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36064/consoleFull) for PR 6983 at commit [`9d8021d`](https://github.com/apache/spark/commit/9d8021d631c8e61bcb0599becd2248363864577c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116910475 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116910464 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116863918 +1 to @squito 's suggestion, and I'll add that you can also force push if you do a rebase instead of a merge. Eitherway, github only is going to look at whatever the head commit of the branch you used to open this PR. When we merge to spark master we have a script that squash commits, so it doesn't really matter if the tree is messy. There will only be one clean commit no matter what the PR looks like. I should be able to look at it this week (and I've marked myself as the shepherd on JIRA so it should show up on my dashboard when its ready). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116862765 Hi @ckadner. I'm not the best person to review this, but just randomly saw your comment. If you merge with master, and then push to your same branch, the diff here on github will still be fine. It'll add one merge commit, but not all the other commits that got pulled. Also github will still show the right diff, so reviewers will still be able to focus on the right bits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user ckadner commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-116861479 @marmbrus - Hi Michael, please let me know when you have time to review my pull-request. This PR no longer merges, so I would close this and create a new PR on top of the latest code in apache/spark master (as opposed to pushing one merge and hundreds of unrelated changes to this PR)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-115046759 [Test build #35725 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35725/console) for PR 6983 at commit [`b97c3fb`](https://github.com/apache/spark/commit/b97c3fb68cbf12d932c191c1d15e032eaaf17068). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-115046786 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-115020946 [Test build #35725 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35725/consoleFull) for PR 6983 at commit [`b97c3fb`](https://github.com/apache/spark/commit/b97c3fb68cbf12d932c191c1d15e032eaaf17068). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-115020376 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-115020353 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-115013994 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-115013905 [Test build #35716 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35716/console) for PR 6983 at commit [`a451184`](https://github.com/apache/spark/commit/a451184d7fe8fe7ec2b6212e6ba80d01926214e7). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-114984275 [Test build #35716 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35716/consoleFull) for PR 6983 at commit [`a451184`](https://github.com/apache/spark/commit/a451184d7fe8fe7ec2b6212e6ba80d01926214e7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-114983992 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-114983969 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-114983591 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6983#issuecomment-114839104 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6785][SQL] fix DateTimeUtils for dates ...
GitHub user ckadner opened a pull request: https://github.com/apache/spark/pull/6983 [SPARK-6785][SQL] fix DateTimeUtils for dates before 1970 Hi Michael, this Pull-Request is a follow-up to [PR-6242](https://github.com/apache/spark/pull/6242). I removed the two obsolete test cases from the HiveQuerySuite and deleted the corresponding golden answer files. Thanks for your review! You can merge this pull request into a Git repository by running: $ git pull https://github.com/ckadner/spark SPARK-6785 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/6983.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6983 commit a451184d7fe8fe7ec2b6212e6ba80d01926214e7 Author: Christian Kadner Date: 2015-06-24T11:21:15Z [SPARK-6785][SQL] fix DateTimeUtils.fromJavaDate(java.util.Date) for Dates before 1970 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
