[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-162080621 Hey @JoshRosen, thanks, my handle is dskrvk there as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-162068764 Hey @dskrvk, what's your Apache JIRA username? I need it in order to assign the JIRA to you so that you are properly credit by our release-notes generation script. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9867 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-162068024 LGTM, so I'm going to merge this into master. Thanks for being so patient, @dskrvk! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-162067339 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-162067340 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47201/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-162067147 **[Test build #47201 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47201/consoleFull)** for PR 9867 at commit [`b079f29`](https://github.com/apache/spark/commit/b079f29f5370a3fe1ce643ff2ab1c999da1d72b9). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * ` public abstract static class PrefixComputer `\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-162033003 **[Test build #47201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47201/consoleFull)** for PR 9867 at commit [`b079f29`](https://github.com/apache/spark/commit/b079f29f5370a3fe1ce643ff2ab1c999da1d72b9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-162031154 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161882116 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161880303 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161880306 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47183/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161880279 **[Test build #47183 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47183/consoleFull)** for PR 9867 at commit [`b079f29`](https://github.com/apache/spark/commit/b079f29f5370a3fe1ce643ff2ab1c999da1d72b9). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * ` public abstract static class PrefixComputer `\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161864244 **[Test build #47183 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47183/consoleFull)** for PR 9867 at commit [`b079f29`](https://github.com/apache/spark/commit/b079f29f5370a3fe1ce643ff2ab1c999da1d72b9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on a diff in the pull request: https://github.com/apache/spark/pull/9867#discussion_r46645444 --- Diff: dev/lint-java --- @@ -0,0 +1,34 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )" +SPARK_ROOT_DIR="$(dirname $SCRIPT_DIR)" + +$SCRIPT_DIR/../build/mvn -Pkinesis-asl -Phive -Phive-thriftserver checkstyle:check > checkstyle.txt +$SCRIPT_DIR/../build/mvn -Pkinesis-asl -Pyarn -Phadoop-2.2 checkstyle:check >> checkstyle.txt --- End diff -- Good point; changed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9867#discussion_r46597229 --- Diff: dev/lint-java --- @@ -0,0 +1,34 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )" +SPARK_ROOT_DIR="$(dirname $SCRIPT_DIR)" + +$SCRIPT_DIR/../build/mvn -Pkinesis-asl -Phive -Phive-thriftserver checkstyle:check > checkstyle.txt +$SCRIPT_DIR/../build/mvn -Pkinesis-asl -Pyarn -Phadoop-2.2 checkstyle:check >> checkstyle.txt --- End diff -- You should be able to have a single run with "-Pkinesis-asl -Pyarn -Phive -Phive-thriftserver" - I even think "-Phive" is unnecessary, I think it only affects packaging right now. "-Phadoop2.2" is unnecessary, that's the default. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161752186 Minor, but there's a typo in the title: "mix" -> "fix". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on a diff in the pull request: https://github.com/apache/spark/pull/9867#discussion_r46465055 --- Diff: dev/lint-java --- @@ -0,0 +1,34 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )" +SPARK_ROOT_DIR="$(dirname $SCRIPT_DIR)" + +$SCRIPT_DIR/../build/mvn -Pkinesis-asl -Phive -Phive-thriftserver checkstyle:check > checkstyle.txt +$SCRIPT_DIR/../build/mvn -Pkinesis-asl -Pyarn -Phadoop-2.2 checkstyle:check >> checkstyle.txt --- End diff -- I didn't actually observe any differences between the two profiles in terms of Checkstyle warnings, but decided to add the second run just to be thorough. My reasoning was that since some profiles omit some of the modules, we need to exercise all of the possible ones, even though at the moment the set of Java sources may be the same. In any case, this only adds a few seconds to the build - negligible compared to the overall `run-tests` time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161408545 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161408548 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47074/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161408233 **[Test build #47074 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47074/consoleFull)** for PR 9867 at commit [`c773e90`](https://github.com/apache/spark/commit/c773e90c93ce211f3bd348eb87fade2a2c19a025). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * ` public abstract static class PrefixComputer `\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161406496 Changes look good to me and ready to merge today; my [only question](https://github.com/apache/spark/pull/9867#discussion_r46461693) concerns why we need to run Checkstyle twice with different sets of profiles. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9867#discussion_r46461693 --- Diff: dev/lint-java --- @@ -0,0 +1,34 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )" +SPARK_ROOT_DIR="$(dirname $SCRIPT_DIR)" + +$SCRIPT_DIR/../build/mvn -Pkinesis-asl -Phive -Phive-thriftserver checkstyle:check > checkstyle.txt +$SCRIPT_DIR/../build/mvn -Pkinesis-asl -Pyarn -Phadoop-2.2 checkstyle:check >> checkstyle.txt --- End diff -- Quick question: why do you need to run twice with different profiles? AFAIK the set of source files should be the same under all of the Hadoop profiles, so I don't think we need to set `-Phadoop-2.2` here. Why can't we just use one Maven run with the profiles `-Pkinesis-asl -Phive -Phive-thriftserver -Pyarn`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161373793 **[Test build #47074 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47074/consoleFull)** for PR 9867 at commit [`c773e90`](https://github.com/apache/spark/commit/c773e90c93ce211f3bd348eb87fade2a2c19a025). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161371851 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161371987 Hey @dskrvk, sorry to let this slip through the cracks. I'm going to shepherd this today to try to get it merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161337172 Thanks @rxin. Would appreciate a "Ship it" on this (unless there are issues). Don't mean to whine, but the longer we wait, the bigger this PR becomes as I have to fix any new code that doesn't pass the checks. Right now the latest merge from upstream passes successfully. Added some more details in the description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-159700647 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46692/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-159700643 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-159700490 **[Test build #46692 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46692/consoleFull)** for PR 9867 at commit [`c773e90`](https://github.com/apache/spark/commit/c773e90c93ce211f3bd348eb87fade2a2c19a025). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * ` public abstract static class PrefixComputer `\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-159698868 I haven't looked at it super closely yet but I think this is definitely good to have! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-159652847 **[Test build #46692 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46692/consoleFull)** for PR 9867 at commit [`c773e90`](https://github.com/apache/spark/commit/c773e90c93ce211f3bd348eb87fade2a2c19a025). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-159355234 Ping? I've just merged the latest changes locally and verified the checks still pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-158683916 Added some more commits so that new changes are in line with the style guide. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-158683705 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46482/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-158683704 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-158683645 **[Test build #46482 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46482/consoleFull)** for PR 9867 at commit [`7a49ad7`](https://github.com/apache/spark/commit/7a49ad708d35bfd1ba7027bb07ae016b2057987c). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * ` public abstract static class PrefixComputer `\n * `abstract class Aggregator[-I, B, O] extends Serializable `\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-158671998 **[Test build #46482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46482/consoleFull)** for PR 9867 at commit [`7a49ad7`](https://github.com/apache/spark/commit/7a49ad708d35bfd1ba7027bb07ae016b2057987c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-158554257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46433/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-158554256 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-158554083 **[Test build #46433 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46433/consoleFull)** for PR 9867 at commit [`fd6d0e0`](https://github.com/apache/spark/commit/fd6d0e0a640b76c9f95f25fb2ab756b645efc69f). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * `public class JavaLDAExample `\n * ` public abstract static class PrefixComputer `\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-158513655 **[Test build #46433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46433/consoleFull)** for PR 9867 at commit [`fd6d0e0`](https://github.com/apache/spark/commit/fd6d0e0a640b76c9f95f25fb2ab756b645efc69f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-158510674 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
GitHub user dskrvk opened a pull request: https://github.com/apache/spark/pull/9867 [SPARK-6990] [Build] Add Java linting script; mix minor warnings This replaces https://github.com/apache/spark/pull/9696 Invoke Checkstyle and print any errors to the console, failing the step. Use Google's style rules modified according to https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide Some important checks are disabled (see TODOs in `checkstyle.xml`) due to multiple violations being present in the codebase. Suggest fixing those TODOs in a separate PR(s). Also fix some of the minor violations that didn't require sweeping changes. Apologies for the previous botched PRs - I finally figured out the issue. cr: @JoshRosen, @pwendell > I state that the contribution is my original work, and I license the work to the project under the project's open source license. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dskrvk/spark master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/9867.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9867 commit 38a00078a73173f953e1de2230148b8973941572 Author: Dmitry Erastov Date: 2015-11-10T16:56:46Z [SPARK-6990] Add Java linting script Invoke Checkstyle and print any errors to the console, failing the step. Use Google's style rules modified according to https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide Some important checks are disabled (see TODOs in checkstyle.xml) due to multiple violations being present in the codebase. commit 10465b567bd3c54562f9ecc8bc9778126571dc7d Author: Dmitry Erastov Date: 2015-11-13T16:53:16Z [SPARK-6990] Remove whitespace after '>' Closing '>' and method name shouldn't have whitespace between them, according to http://checkstyle.sourceforge.net/config_whitespace.html#GenericWhitespace commit 1a57e30be00b07ccba0c9e7412370b685cd92014 Author: Dmitry Erastov Date: 2015-11-10T16:57:20Z [SPARK-6990] Fix some Checkstyle warnings commit 59c99c996416927722dcd499d4c5f7634b283f91 Author: Dmitry Erastov Date: 2015-11-11T14:52:19Z [SPARK-6990] Suppress Checkstyle for TimSort The code was copied from a third-party source and needs to be in sync with that, so we shouldn't make our own modifications to it. The file contains some style violations, so suppress the checks. commit d33ed8de691ee4d411febe15f77766f97397d260 Author: Dmitry Erastov Date: 2015-11-11T14:58:41Z [SPARK-6990] Fix some Checkstyle issues in tests commit 7d5cbe163115a8ee170a867ba74476aa31286958 Author: Dmitry Erastov Date: 2015-11-11T15:01:20Z [SPARK-6990] Enable Checkstyle for tests commit b96a61a3a447b15015853f7349a84d1fe503b972 Author: Dmitry Erastov Date: 2015-11-11T15:01:48Z [SPARK-6990] Enable FallThrough check in Checkstyle This makes sure all case statements end with a break. See http://checkstyle.sourceforge.net/config_coding.html#FallThrough commit db17e0e3bc98de89e644e273604abdad04265328 Author: Dmitry Erastov Date: 2015-11-19T21:20:34Z [SPARK-6990] Disable MissingSwitchDefault check Checks fails in UnsafeRowParquetRecordReader.java. Let's enable the check in a separate change. commit ae30c6a1cf52f1b313f6cdb9d456703c8207a5b3 Author: Dmitry Erastov Date: 2015-11-19T21:25:24Z [SPARK-6990] Fix qualifier order in SpecificParquetRecordReaderBase commit fd6d0e0a640b76c9f95f25fb2ab756b645efc69f Author: Dmitry Erastov Date: 2015-11-20T19:47:24Z Merge remote-tracking branch 'upstream/master' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-158509085 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk closed the pull request at: https://github.com/apache/spark/pull/9696 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158274392 Yes, I believe rebasing instead of merging is the problem since it rewrites history, and if some of the changes I'm rebasing have already been pushed to my remote, it freaks out and creates theses false commits. I'll resubmit a (hopefully) final PR tomorrow. Sorry everyone. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158273031 Sounds similar to what I do, except I don't do step 3 (I just push to a branch on my fork and create a PR from that). Maybe you're doing something wrong in that step (like merging instead of rebasing or something). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158270941 My setup looks like this: 1. Local master tracks my fork's master. 2. Changes from upstream/master get periodically rebased on top of local master. 3. Local feature branch contains my changes and is being merged into local master before pushing. 4. The PR is master against master. Is there anything obviously wrong with this workflow? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158269665 Are you sure you're working off the right branch? That's the most common cause of these things; e.g. you're working on branch-1.6 but the PR is against master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158267775 Yeah, I'm still struggling with the fork syncing workflow. Looks like I'll have to open a new PR yet again to get rid of all those extraneous commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158265989 This PR still looks pretty botched to me. Lots of seemingly unrelated stuff in the patch, lots if weird things (github says "empty file changed"?) and other stuff. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158261811 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158261812 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46363/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158261749 **[Test build #46363 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46363/consoleFull)** for PR 9696 at commit [`c461924`](https://github.com/apache/spark/commit/c461924ea9f61dba555a946ac07b7aea637b2051). * This patch **fails from timeout after a configured wait of \`250m\`**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158219521 **[Test build #46363 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46363/consoleFull)** for PR 9696 at commit [`c461924`](https://github.com/apache/spark/commit/c461924ea9f61dba555a946ac07b7aea637b2051). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158175801 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158175789 **[Test build #46345 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46345/consoleFull)** for PR 9696 at commit [`677e228`](https://github.com/apache/spark/commit/677e228f429029072cdc87770cb584de34cea63e). * This patch **fails Java style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * ` public abstract static class PrefixComputer `\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158175805 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46345/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158174906 **[Test build #46345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46345/consoleFull)** for PR 9696 at commit [`677e228`](https://github.com/apache/spark/commit/677e228f429029072cdc87770cb584de34cea63e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158172649 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158163207 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-157881163 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-157876465 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46231/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-157876463 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-157876338 **[Test build #46231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46231/consoleFull)** for PR 9696 at commit [`677e228`](https://github.com/apache/spark/commit/677e228f429029072cdc87770cb584de34cea63e). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * ` public abstract static class PrefixComputer `\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-157829103 **[Test build #46231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46231/consoleFull)** for PR 9696 at commit [`677e228`](https://github.com/apache/spark/commit/677e228f429029072cdc87770cb584de34cea63e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-157826072 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-157825981 Can one of the admins give this a nudge please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-156542963 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-156542964 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45869/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-156542792 **[Test build #45869 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45869/consoleFull)** for PR 9600 at commit [`b023412`](https://github.com/apache/spark/commit/b023412e0d65c5c4f50c410051efad92772234f4). * This patch passes all tests. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-156500411 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
GitHub user dskrvk opened a pull request: https://github.com/apache/spark/pull/9696 [SPARK-6990] [Build] Add Java linting script; mix minor warnings This replaces the botched PR https://github.com/apache/spark/pull/9600 Invoke Checkstyle and print any errors to the console, failing the step. Use Google's style rules modified according to https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide Some important checks are disabled (see TODOs in `checkstyle.xml`) due to multiple violations being present in the codebase. Suggest fixing those TODOs in a separate PR(s). Also fix some of the minor violations that didn't require sweeping changes. cr: @JoshRosen, @pwendell > I state that the contribution is my original work, and I license the work to the project under the project's open source license. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dskrvk/spark master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/9696.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9696 commit c6bab96d3f958d413373789e6e790b98d4dd195a Author: Dmitry Erastov Date: 2015-11-10T16:56:46Z [SPARK-6990] Add Java linting script Invoke Checkstyle and print any errors to the console, failing the step. Use Google's style rules modified according to https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide Some important checks are disabled (see TODOs in checkstyle.xml) due to multiple violations being present in the codebase. commit 59e84dc5435dea27ad7efb82ff3f1c5a28fa8ec5 Author: Dmitry Erastov Date: 2015-11-13T16:53:16Z [SPARK-6990] Remove whitespace after '>' Closing '>' and method name shouldn't have whitespace between them, according to http://checkstyle.sourceforge.net/config_whitespace.html#GenericWhitespace commit 20de73e85b4c8fe4cb4edebd0d564964c8525a0b Author: Dmitry Erastov Date: 2015-11-10T16:57:20Z [SPARK-6990] Fix some Checkstyle warnings commit 6a2c1439eb2ed56de25fc3f45f448664a9162329 Author: Dmitry Erastov Date: 2015-11-11T14:52:19Z [SPARK-6990] Suppress Checkstyle for TimSort The code was copied from a third-party source and needs to be in sync with that, so we shouldn't make our own modifications to it. The file contains some style violations, so suppress the checks. commit 67ffb934b259ab5dae4b7fb8a03fd71e77cfbda2 Author: Dmitry Erastov Date: 2015-11-11T14:58:41Z [SPARK-6990] Fix some Checkstyle issues in tests commit 6f42a36e90b2b82577621a6e54a6a4fdd5b55e4f Author: Dmitry Erastov Date: 2015-11-11T15:01:20Z [SPARK-6990] Enable Checkstyle for tests commit 677e228f429029072cdc87770cb584de34cea63e Author: Dmitry Erastov Date: 2015-11-11T15:01:48Z [SPARK-6990] Enable FallThrough check in Checkstyle This makes sure all case statements end with a break. See http://checkstyle.sourceforge.net/config_coding.html#FallThrough --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk closed the pull request at: https://github.com/apache/spark/pull/9600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-156491186 **[Test build #45869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45869/consoleFull)** for PR 9600 at commit [`b023412`](https://github.com/apache/spark/commit/b023412e0d65c5c4f50c410051efad92772234f4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-156480066 @JoshRosen or @pwendell, can you please take a look at the new revision when you have a chance? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155910438 Incorporated CR comments from @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155909442 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45649/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155909441 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155909099 **[Test build #45649 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45649/consoleFull)** for PR 9600 at commit [`e7bdddc`](https://github.com/apache/spark/commit/e7bdddc86baf14748186934e23d8901e933a9fc4). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * ` public abstract static class PrefixComputer `\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155855630 **[Test build #45649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45649/consoleFull)** for PR 9600 at commit [`e7bdddc`](https://github.com/apache/spark/commit/e7bdddc86baf14748186934e23d8901e933a9fc4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155851906 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155851931 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155575801 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155575805 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45537/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155575629 **[Test build #45537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45537/consoleFull)** for PR 9600 at commit [`add6f45`](https://github.com/apache/spark/commit/add6f45a86e1e14f05b8cd7d992e41166d69c382). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_:\n * ` public abstract static class PrefixComputer `\n --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on a diff in the pull request: https://github.com/apache/spark/pull/9600#discussion_r44464894 --- Diff: pom.xml --- @@ -2224,6 +2224,30 @@ + +org.apache.maven.plugins +maven-checkstyle-plugin +2.17 + + false + false + false --- End diff -- OK, looks like the tests need some more work to pass the checks. Working on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user dskrvk commented on a diff in the pull request: https://github.com/apache/spark/pull/9600#discussion_r44453088 --- Diff: pom.xml --- @@ -2224,6 +2224,30 @@ + +org.apache.maven.plugins +maven-checkstyle-plugin +2.17 + + false + false + false --- End diff -- I copied this setting from the Scalatest section. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9600#discussion_r9420 --- Diff: pom.xml --- @@ -2224,6 +2224,30 @@ + +org.apache.maven.plugins +maven-checkstyle-plugin +2.17 + + false + false + false --- End diff -- I think we _do_ want to lint tests, no? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9600#discussion_r9339
--- Diff: core/src/main/java/org/apache/spark/util/collection/TimSort.java
---
@@ -120,8 +120,9 @@ public void sort(Buffer a, int lo, int hi, Comparator c) {
assert c != null;
--- End diff --
Can you exclude this TimSort file, since it's third-party code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155526138 **[Test build #45537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45537/consoleFull)** for PR 9600 at commit [`add6f45`](https://github.com/apache/spark/commit/add6f45a86e1e14f05b8cd7d992e41166d69c382). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155524038 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155524079 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155523839 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155513294 I think @JoshRosen or @pwendell may be better suited to review this patch. Original issue: [SPARK-6990](https://issues.apache.org/jira/browse/SPARK-6990) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9600#issuecomment-155500554 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
GitHub user dskrvk opened a pull request: https://github.com/apache/spark/pull/9600 [SPARK-6990] [Build] Add Java linting script; mix minor warnings Invoke Checkstyle and print any errors to the console, failing the step. Use Google's style rules modified according to https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide Some important checks are disabled (see TODOs in `checkstyle.xml`) due to multiple violations being present in the codebase. Suggest fixing those TODOs in a separate PR(s). Also fix some of the minor violations that didn't require sweeping changes. cr: @nchammas, @ScrapCodes > I state that the contribution is my original work, and I license the work to the project under the project's open source license. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dskrvk/spark master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/9600.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9600 commit 374e55f61cdaac948a34a2b261b92992a0d1641c Author: Dmitry Erastov Date: 2015-11-10T16:56:46Z [SPARK-6990] Add Java linting script Invoke Checkstyle and print any errors to the console, failing the step. Use Google's style rules modified according to https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide Some important checks are disabled (see TODOs in checkstyle.xml) due to multiple violations being present in the codebase. commit add6f45a86e1e14f05b8cd7d992e41166d69c382 Author: Dmitry Erastov Date: 2015-11-10T16:57:20Z [SPARK-6990] Fix some Checkstyle warnings --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
