[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-08-02 Thread haiyangsea
Github user haiyangsea closed the pull request at:

https://github.com/apache/spark/pull/5861


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-05-04 Thread haiyangsea
Github user haiyangsea commented on the pull request:

https://github.com/apache/spark/pull/5861#issuecomment-98690829
  
@marmbrus. I have already realized this problem, but didn't find a good way 
to solve it.Thank you for reminding me, I will try to fix it according to the 
idea you provided:)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-05-02 Thread marmbrus
Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/5861#issuecomment-98408007
  
You could still have collisions if the user uses backticks.  It seems like 
what we really want to do is add a `systemGenerated` property to attributes 
that defaults to false.  System generated Attributes can be ignored when doing 
resolution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/5861#issuecomment-98323926
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31658/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/5861#issuecomment-98323922
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-05-02 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/5861#issuecomment-98323904
  
  [Test build #31658 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31658/consoleFull)
 for   PR 5861 at commit 
[`620473e`](https://github.com/apache/spark/commit/620473eac8c2b519a67b183890cc05207fd81436).
 * This patch **fails PySpark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-05-01 Thread haiyangsea
Github user haiyangsea commented on the pull request:

https://github.com/apache/spark/pull/5861#issuecomment-98316844
  
@rxin "having-condition" contains "-" operator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-05-01 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/5861#issuecomment-98311958
  
  [Test build #31658 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31658/consoleFull)
 for   PR 5861 at commit 
[`620473e`](https://github.com/apache/spark/commit/620473eac8c2b519a67b183890cc05207fd81436).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-05-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/5861#issuecomment-98311408
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-05-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/5861#issuecomment-98311397
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-05-01 Thread rxin
Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/5861#issuecomment-98310852
  
Is having-condition invalid?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-05-01 Thread rxin
Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/5861#issuecomment-98310901
  
Jenkins, test this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-05-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/5861#issuecomment-98308017
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-7149] [SQL] Fix system default alias pr...

2015-05-01 Thread haiyangsea
GitHub user haiyangsea opened a pull request:

https://github.com/apache/spark/pull/5861

[SPARK-7149] [SQL] Fix system default alias problem

executing the following sql statement will throw exception:

```sql
select key as havingCondition from testData group by key having key > 
count(*)
```

org.apache.spark.sql.AnalysisException: Reference 'havingCondition' is 
ambiguous, could be: havingCondition#42, havingCondition#41.

```sql
select substr(value, 0, 2), key as c0 from testData order by c0 desc limit 2
```

org.apache.spark.sql.AnalysisException: Reference 'c0' is ambiguous, could 
be: c0#42, c0#41.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/haiyangsea/spark alias

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/5861.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5861


commit 620473eac8c2b519a67b183890cc05207fd81436
Author: haiyang 
Date:   2015-04-26T07:09:45Z

fix system default alias problem




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org