[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5859#issuecomment-98320002 [Test build #31651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31651/consoleFull) for PR 5859 at commit [`4b25056`](https://github.com/apache/spark/commit/4b25056dd12cc6b2bc8b0cf68d3573c592943053). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SaslEncryption ` * ` static class EncryptedMessage extends AbstractReferenceCounted implements FileRegion ` * `class SaslRpcHandler extends RpcHandler ` * `public class SaslServerBootstrap implements TransportServerBootstrap ` * `public class SparkSaslClient implements SaslEncryptionBackend ` * `public class SparkSaslServer implements SaslEncryptionBackend ` * `public class ByteArrayWritableChannel implements WritableByteChannel ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5859#issuecomment-98320004 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5859#issuecomment-98320005 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31651/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5859#issuecomment-98320137 [Test build #31653 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31653/consoleFull) for PR 5859 at commit [`f9aa9ce`](https://github.com/apache/spark/commit/f9aa9ce35b121f94c8801498266bf5d46d234b19). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SaslEncryption ` * ` static class EncryptedMessage extends AbstractReferenceCounted implements FileRegion ` * `class SaslRpcHandler extends RpcHandler ` * `public class SaslServerBootstrap implements TransportServerBootstrap ` * `public class SparkSaslClient implements SaslEncryptionBackend ` * `public class SparkSaslServer implements SaslEncryptionBackend ` * `public class ByteArrayWritableChannel implements WritableByteChannel ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5859#issuecomment-98320140 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31653/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5859#issuecomment-98320139 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5859 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/5859#discussion_r29545099 --- Diff: python/pyspark/sql/dataframe.py --- @@ -889,6 +889,24 @@ def cov(self, col1, col2): raise ValueError(col2 should be a string.) return self._jdf.stat().cov(col1, col2) +def freqItems(self, cols, support=1e-2): --- End diff -- it's probably best to use None as the default, and set support to 1e-2 if it is None in the body of the function. Then you don't need to set the default value in two places. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/5859#discussion_r29545089 --- Diff: python/pyspark/sql/dataframe.py --- @@ -889,6 +889,24 @@ def cov(self, col1, col2): raise ValueError(col2 should be a string.) return self._jdf.stat().cov(col1, col2) +def freqItems(self, cols, support=1e-2): + +Finding frequent items for columns, possibly with false positives. Using the +frequent element count algorithm described in +http://dx.doi.org/10.1145/762471.762473, proposed by Karp, Schenker, and Papadimitriou. +Uses a `default` support of 1%. The support must be greater than 1e-4. +:func:`DataFrame.freqItems` and :func:`DataFrameStatFunctions.freqItems` are aliases. + +:param cols: Names of the columns to calculate frequent items for as a list or tuple of +strings. +:param support: The frequency with which to consider an item 'frequent'. Default is 1%. --- End diff -- Move the default value and default support here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5859#issuecomment-98300854 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5859#issuecomment-98300847 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/5859 [SPARK-7242] added python api for freqItems in DataFrames The python api for DataFrame's plus addressed your comments from previous PR. @rxin You can merge this pull request into a Git repository by running: $ git pull https://github.com/brkyvz/spark df-freq-py2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/5859.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5859 commit 4b25056dd12cc6b2bc8b0cf68d3573c592943053 Author: Burak Yavuz brk...@gmail.com Date: 2015-05-02T04:20:07Z added python api for freqItems --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/5859#discussion_r29545101 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1344,6 +1362,11 @@ def cov(self, col1, col2): cov.__doc__ = DataFrame.cov.__doc__ +def freqItems(self, cols, support=1e-2): --- End diff -- here -- if support=None by default, we only need to set the default value in one place. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5859#issuecomment-98300894 [Test build #31651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31651/consoleFull) for PR 5859 at commit [`4b25056`](https://github.com/apache/spark/commit/4b25056dd12cc6b2bc8b0cf68d3573c592943053). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5859#issuecomment-98303294 [Test build #31653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31653/consoleFull) for PR 5859 at commit [`f9aa9ce`](https://github.com/apache/spark/commit/f9aa9ce35b121f94c8801498266bf5d46d234b19). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5859#issuecomment-98302936 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7242] added python api for freqItems in...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5859#issuecomment-98302973 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
