[GitHub] spark pull request: [SPARK-7889] make sure click the "App ID" on H...
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-107659004 Can I suggest that you start by creating a failing test case? You can try to follow the examples in `UISeleniumSuite`. that might help us see what is going wrong. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7889] make sure click the "App ID" on H...
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-107430955 Hey Sean, what we wanna fix is the "load once, show them forever" issue. That is to say, when user click a link on history page, the provider will load an application information from persistent layer into memory and will never update it. So if the click happened with application incompleted, then no matter what the followed operations are, the history page will show the incompleted infomation ever. Obviously it is a problem. We have not much experience at Jetty so maybe it is not a perfect solution by now. Hope someone would give their feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7889] make sure click the "App ID" on H...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-107381570 Can you explain this more? what does this accomplish that isn't accomplished by refreshing the page? and unless the page is refreshed I would not expect an update. This code has a lot of style problems like indentation too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7889] make sure click the "App ID" on H...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6545#issuecomment-107285299 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7889] make sure click the "App ID" on H...
GitHub user XuTingjun opened a pull request: https://github.com/apache/spark/pull/6545 [SPARK-7889] make sure click the "App ID" on HistoryPage, the SparkUI will be refreshed. The bug is that: When clicking the app in incomplete page, the tasks progress is 100/2000. After the app finished, click into the app again, the tasks progress still shows 100/2000. This patch I override the handle function in UIHandlerCollection. I just add the line 137-151, to make sure every time click the "App ID" , the HistoryPage will read the event file on hdfs, and refresh the SparkUI. May have two problems: 1. Though it makes the SparkUI can refresh, but the refresh is effective just after clicking the "App ID". If have entered the SparkUI, refresh makes no change. 2. every time click the "App ID", it will go to read the hdfs file. So it will make response more slower and have the risk of being attacked. You can merge this pull request into a Git repository by running: $ git pull https://github.com/XuTingjun/spark SPARK-7889 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/6545.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6545 commit 9d5c1baa4acfe66e04dc58a4ece5a97792db8749 Author: Xutingjun Date: 2015-06-01T02:01:29Z To make sure every time click the "App ID" on HistoryPage, the SparkUI will be refreshed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
