[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10459 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168148942 I've merged it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168148715 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48545/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168148714 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168148675 **[Test build #48545 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48545/consoleFull)** for PR 10459 at commit [`1aa9728`](https://github.com/apache/spark/commit/1aa9728bc238ebc69545b06b794127dc4a09e958). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168134901 **[Test build #48545 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48545/consoleFull)** for PR 10459 at commit [`1aa9728`](https://github.com/apache/spark/commit/1aa9728bc238ebc69545b06b794127dc4a09e958). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168126541 Ah this no longer merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168115808 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168115809 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48529/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168115773 **[Test build #48529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48529/consoleFull)** for PR 10459 at commit [`3d347bc`](https://github.com/apache/spark/commit/3d347bc34f7134e14fe3f66a825cdbe88fe4dab7). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168107375 **[Test build #48529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48529/consoleFull)** for PR 10459 at commit [`3d347bc`](https://github.com/apache/spark/commit/3d347bc34f7134e14fe3f66a825cdbe88fe4dab7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168103376 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168103242 **[Test build #48513 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48513/consoleFull)** for PR 10459 at commit [`3d347bc`](https://github.com/apache/spark/commit/3d347bc34f7134e14fe3f66a825cdbe88fe4dab7). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168103265 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48513/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168103264 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168093023 **[Test build #48513 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48513/consoleFull)** for PR 10459 at commit [`3d347bc`](https://github.com/apache/spark/commit/3d347bc34f7134e14fe3f66a825cdbe88fe4dab7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168091225 > re: AkkaUtilsSuite, it should be rewritten to only cover the ActorSystem parts of the code (not any of the RPC stuff), or removed altogether. Removed AkkaUtilsSuite > Hopefully we can also get rid of the ActorSystem in 2.0 and make it an optional streaming module if the API is still desired. That's the plan :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-168083178 re: `AkkaUtilsSuite`, it should be rewritten to only cover the `ActorSystem` parts of the code (not any of the RPC stuff), or removed altogether. Hopefully we can also get rid of the `ActorSystem` in 2.0 and make it an optional streaming module if the API is still desired. Otherwise, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10459#discussion_r48635701
--- Diff: core/src/test/scala/org/apache/spark/util/AkkaUtilsSuite.scala ---
@@ -61,9 +55,14 @@ class AkkaUtilsSuite extends SparkFunSuite with
LocalSparkContext with ResetSyst
val slaveRpcEnv = RpcEnv.create("spark-slave", hostname, 0, conf,
securityManagerBad)
val slaveTracker = new MapOutputTrackerWorker(conf)
-intercept[akka.actor.ActorNotFound] {
+try {
slaveTracker.trackerEndpoint =
-slaveRpcEnv.setupEndpointRef("spark", rpcEnv.address,
MapOutputTracker.ENDPOINT_NAME)
+slaveRpcEnv.setupEndpointRef(rpcEnv.address,
MapOutputTracker.ENDPOINT_NAME)
+} catch {
+ case e: RuntimeException =>
+assert(e.getMessage.contains("javax.security.sasl.SaslException"))
+ case e: SparkException =>
+assert(e.getMessage.contains("Message is dropped because Outbox is
stopped"))
--- End diff --
Actually I think that most of these tests are now redundant; the transport
library's auth code is already well covered in the network-common tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10459#discussion_r48635379
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/SimrSchedulerBackend.scala
---
@@ -18,9 +18,9 @@
package org.apache.spark.scheduler.cluster
import org.apache.hadoop.fs.{Path, FileSystem}
+import org.apache.spark.rpc.RpcEndpointAddress
--- End diff --
nit: import is in wrong place
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10459#discussion_r48635104
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -544,7 +544,8 @@ private[spark] object SparkConf extends Logging {
DeprecatedConfig("spark.kryoserializer.buffer.mb", "1.4",
"Please use spark.kryoserializer.buffer instead. The default value
for " +
"spark.kryoserializer.buffer.mb was previously specified as
'0.064'. Fractional values " +
- "are no longer accepted. To specify the equivalent now, one may
use '64k'.")
+ "are no longer accepted. To specify the equivalent now, one may
use '64k'."),
+ DeprecatedConfig("spark.rpc", "2.0.0", "Not used any more.")
--- End diff --
nit: use just `2.0`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167914770 CC @vanzin @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167677319 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167677321 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48372/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167677241 **[Test build #48372 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48372/consoleFull)** for PR 10459 at commit [`1f5a523`](https://github.com/apache/spark/commit/1f5a5237c9fe238a23d0601293da3ae33f1f9fa2). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10459#discussion_r48505634
--- Diff: core/src/test/scala/org/apache/spark/util/AkkaUtilsSuite.scala ---
@@ -61,9 +55,14 @@ class AkkaUtilsSuite extends SparkFunSuite with
LocalSparkContext with ResetSyst
val slaveRpcEnv = RpcEnv.create("spark-slave", hostname, 0, conf,
securityManagerBad)
val slaveTracker = new MapOutputTrackerWorker(conf)
-intercept[akka.actor.ActorNotFound] {
+try {
slaveTracker.trackerEndpoint =
-slaveRpcEnv.setupEndpointRef("spark", rpcEnv.address,
MapOutputTracker.ENDPOINT_NAME)
+slaveRpcEnv.setupEndpointRef(rpcEnv.address,
MapOutputTracker.ENDPOINT_NAME)
+} catch {
+ case e: RuntimeException =>
+assert(e.getMessage.contains("javax.security.sasl.SaslException"))
+ case e: SparkException =>
+assert(e.getMessage.contains("Message is dropped because Outbox is
stopped"))
--- End diff --
AkkaUtilsSuite should be moved to RpcEnvSuite and rewritten. However, I
prefer to do it in a follow up PR to minimize the changes of this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10459#discussion_r48505487
--- Diff: core/src/test/scala/org/apache/spark/util/AkkaUtilsSuite.scala ---
@@ -61,9 +55,14 @@ class AkkaUtilsSuite extends SparkFunSuite with
LocalSparkContext with ResetSyst
val slaveRpcEnv = RpcEnv.create("spark-slave", hostname, 0, conf,
securityManagerBad)
val slaveTracker = new MapOutputTrackerWorker(conf)
-intercept[akka.actor.ActorNotFound] {
+try {
slaveTracker.trackerEndpoint =
-slaveRpcEnv.setupEndpointRef("spark", rpcEnv.address,
MapOutputTracker.ENDPOINT_NAME)
+slaveRpcEnv.setupEndpointRef(rpcEnv.address,
MapOutputTracker.ENDPOINT_NAME)
+} catch {
+ case e: RuntimeException =>
+assert(e.getMessage.contains("javax.security.sasl.SaslException"))
+ case e: SparkException =>
+assert(e.getMessage.contains("Message is dropped because Outbox is
stopped"))
--- End diff --
Adding this catch clause because there is a race condition in `Outbox` that
may throw `SparkException` instead. Image the following execution order:
Execution Order | Thread1 | Thread2
- | - | -
1 | nettyEnv.createClient (Outbox.scala, will call channel.close in this
method if authentication fails) |
2 | catch NonFatal(e) |
3 | | connectionTerminated (NettyRpcHandler)
4 | | nettyEnv.removeOutbox
5 | | outbox.stop
6 | | message.onFailure(new SparkException("Message is dropped because
Outbox is stopped"))
7 | Outbox.handleNetworkFailure |
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167654637 **[Test build #48372 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48372/consoleFull)** for PR 10459 at commit [`1f5a523`](https://github.com/apache/spark/commit/1f5a5237c9fe238a23d0601293da3ae33f1f9fa2). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10459#discussion_r48402964
--- Diff: project/MimaExcludes.scala ---
@@ -171,7 +171,19 @@ object MimaExcludes {
) ++
// SPARK-11314: YARN backend moved to yarn sub-module and MiMA
complains even though it's a
// private class.
-
MimaBuild.excludeSparkClass("scheduler.cluster.YarnSchedulerBackend$YarnSchedulerEndpoint")
+
MimaBuild.excludeSparkClass("scheduler.cluster.YarnSchedulerBackend$YarnSchedulerEndpoint")
++
+ Seq(
+// SPARK-7995 Remove AkkaRpcEnv
--- End diff --
can you move this to the front instead of the back?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167069410 And please also point out if there are any tricky changes that should be paid more attention (I'm guessing none since it's mostly just removal of code?) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167069342 Can you update the pull request and JIRA description to explain what systemName is, why it still exists, and why it is no longer useful now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167024832 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167024834 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48268/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167024785 **[Test build #48268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48268/consoleFull)** for PR 10459 at commit [`a3d9388`](https://github.com/apache/spark/commit/a3d938872cbb1f5c82b8abccc0e44cbbea442b54). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167016412 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167016413 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48265/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167016380 **[Test build #48265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48265/consoleFull)** for PR 10459 at commit [`a3d9388`](https://github.com/apache/spark/commit/a3d938872cbb1f5c82b8abccc0e44cbbea442b54). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167013686 **[Test build #48268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48268/consoleFull)** for PR 10459 at commit [`a3d9388`](https://github.com/apache/spark/commit/a3d938872cbb1f5c82b8abccc0e44cbbea442b54). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167012620 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167012366 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167012368 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48264/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167012329 **[Test build #48264 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48264/consoleFull)** for PR 10459 at commit [`a3d9388`](https://github.com/apache/spark/commit/a3d938872cbb1f5c82b8abccc0e44cbbea442b54). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167008339 **[Test build #48265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48265/consoleFull)** for PR 10459 at commit [`a3d9388`](https://github.com/apache/spark/commit/a3d938872cbb1f5c82b8abccc0e44cbbea442b54). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167007565 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167006863 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48262/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167006862 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167006026 **[Test build #48264 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48264/consoleFull)** for PR 10459 at commit [`a3d9388`](https://github.com/apache/spark/commit/a3d938872cbb1f5c82b8abccc0e44cbbea442b54). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167004641 **[Test build #48259 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48259/consoleFull)** for PR 10459 at commit [`b4d087e`](https://github.com/apache/spark/commit/b4d087e9d3381fda727ea425d5c4c4f53b8a8d25). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167004661 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167004663 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48259/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10459#issuecomment-167003325 **[Test build #48259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48259/consoleFull)** for PR 10459 at commit [`b4d087e`](https://github.com/apache/spark/commit/b4d087e9d3381fda727ea425d5c4c4f53b8a8d25). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/10459 [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEnv and remove systemName from setupEndpointRef Keep `SparkEnv.actorSystem` because Streaming still uses it. Will remove it and AkkaUtils after refactoring Streaming actorStream API. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zsxwing/spark remove-akka-rpc-env Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/10459.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10459 commit 478a645e7d4c5c70048fccb2e705b4371f6be3ce Author: Shixiong Zhu Date: 2015-12-23T21:02:52Z Remove AkkaRpcEnv commit 8b2d628841e950b57d114e0ee400a94bdcd704b2 Author: Shixiong Zhu Date: 2015-12-23T21:16:50Z Remove SystemName commit 613201f519af4553d3fbc1c0ed517b7dd9a87868 Author: Shixiong Zhu Date: 2015-12-23T22:00:58Z Fix tests commit b4d087e9d3381fda727ea425d5c4c4f53b8a8d25 Author: Shixiong Zhu Date: 2015-12-23T22:04:19Z Remove ActorLogReceive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
