[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[harishreedharan]

Github user harishreedharan commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-114594047
  
Now that we don't have the commons-lang3 dependency in the flume-sink 
anymore, the assembly question for this module is moot. But if we want to have 
a more general discussion, we should perhaps move this discussion to a jira or 
the dev list?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[zsxwing]

Github user zsxwing commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-114356316
  
I agree with @srowen that Maven isn't really the right place to distribute 
assemblies. For the assembly jars, what we need to do is just providing 
download links for people. 

I find now these jars are already assembled in `spark-examples-jar`. 
How bout adding separate assembly jars to the final distribution "tgz" file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[harishreedharan]

Github user harishreedharan commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113659788
  
Yes, all of the libs in the flume-ng/lib directory gets added to the 
classpath, so scala would get added to the classpath, but get loaded only as 
required (which is normal JVM protocol). We'd have to bump our dependency to 
1.6.0 for scala to be automagically available. 

Even if we don't upgrade, we don't need to change the dependency set, as 
the behavior is the same as before (add scala to flume-ng/lib or plugins dir). 
Apart from the assembly part, nothing else changes. I am sending a PR soon to 
get rid of the commons-lang3 dependency anyway


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113656100
  
I see. So the Kafka is present only through the flume-kafka-source

http://mvnrepository.com/artifact/org.apache.flume.flume-ng-sources/flume-kafka-source/1.6.0

Furthermore this is not available for Flume 1.4.0 as kafka source was added
only in 1.6.0

So here are two questions
1. Do installations of Flume always have all the sources loaded? If not,
then its an incorrect assumption that Scala will always be present.
2. Even if 1 is true, we have to upgrade Flume in Spark Streaming to
version 1.6.0 for this to be feasible. That;s a whole different issue.

I dont know enough about Flume, but I will be very surprised if the kafka
source is always loaded in the classpath in all flume installations.

@harishreedharan please comment.

On Fri, Jun 19, 2015 at 2:50 PM, Sean Owen  wrote:

> That looks like just the API module. I suspect it comes via the actual
> implementation such as in
> http://mvnrepository.com/artifact/org.apache.flume/flume-ng-sources/1.6.0
> but I don't know Flume well.
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113653289
  
That looks like just the API module. I suspect it comes via the actual 
implementation such as in 
http://mvnrepository.com/artifact/org.apache.flume/flume-ng-sources/1.6.0 but I 
don't know Flume well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113652186
  
I dont see a dependency on Kafka in Flume 1.4.0
http://mvnrepository.com/artifact/org.apache.flume/flume-ng-sdk/1.4.0

What am i missing?

On Fri, Jun 19, 2015 at 2:21 PM, Hari Shreedharan 
wrote:

> Kafka brings in 2.10.
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[harishreedharan]

Github user harishreedharan commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113648154
  
Kafka brings in 2.10.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113592433
  
Yep, lets just remove the dependency on common lang. However, what is the
version of Scala that comes with Kafka? Scala 2.10, or 2.11? This is
something we need to document. Since spark artifacts are now published for
both 2.10 and 2.11, this needs a bit of documentation.

On a related note, should we bump the flume support to latest Flume? It
seems to be stuck in 1.4.0 where as 1.6.0 is out. Does it matter?

On Fri, Jun 19, 2015 at 10:04 AM, Hari Shreedharan  wrote:

> I will open a PR later today for this one.
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[harishreedharan]

Github user harishreedharan commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113576860
  
I will open a PR later today for this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[harishreedharan]

Github user harishreedharan commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113576309
  
This is the only usage:
`private val seqBase = RandomStringUtils.randomAlphanumeric(8)`

I am inclined to just copy the method into the class. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[JoshRosen]

Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113576062
  
How extensive is our use of commons Lang 3 in flume sink?  If we only use 
one class or method maybe we can just copy the source into our repository, 
depending on how complex or large it is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[harishreedharan]

Github user harishreedharan commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113570465
  
So the only reason for an assembly would be to add commons-lang3. I am more 
in favor of removing that dependency than making the build more complex. Flume 
already has scala in classpath (since that is pulled in by the Kafka 
dependency). I am inclined to keep this component as simple as possible and 
depend only on stuff already pulled in by Flume into its own classpath anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113446313
  
Yeah I'm not worried about size. Maven isn't really the right place to 
distribute assemblies as it's not something to depend on. Yes, it just should 
be downloadable. I get it, that maven artifacts are still a pretty easy way to 
make it available. In that case maybe a new module makes sense after all: 
flume-assembly. Or if you're saying nobody would ever use the existing 
no-assembly artifact anyway, I can see changing it to the assembly. But that is 
suggesting that the existing module would never be used as a dependency.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113429762
  
The idea for publishing the assembly (which BTW is not that big as it
should contain only the sink code + scala + common lang 3) is same as that
of current publishing of package JAR - so that people can directly download
the JAR and put it in the Flume to run the sink. So the only difference
compared to what is the current behavior is that instead of publishing just
sink code, we will publish sink code + scala + common lang 3, which makes
it more self contained.

On Fri, Jun 19, 2015 at 12:52 AM, Sean Owen 
wrote:

> Oh, I didn't realize you wanted to publish the assembly JAR. I don't think
> it makes sense to publish assemblies as Maven artifacts. Right? anyone 
that
> uses it via Maven does not want an assembly and it causes a bunch of
> problems. So no please don't publish the assembly that way.
>
> You just need a target to build the assembly right? that's just a matter
> of adding a plugin.
>
> (You can publish multiple artifacts under different *classifiers* for one
> group/artifact but this isn't the situation that this would be used.)
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113417003
  
Oh, I didn't realize you wanted to publish the assembly JAR. I don't think 
it makes sense to publish assemblies as Maven artifacts. Right? anyone that 
uses it via Maven does not want an assembly and it causes a bunch of problems. 
So no please don't publish the assembly that way.

You just need a target to build the assembly right? that's just a matter of 
adding a plugin.

(You can publish multiple artifacts under different _classifiers_ for one 
group/artifact but this isn't the situation that this would be used.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[zsxwing]

Github user zsxwing commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113348608
  
Publishing the single jar would be helpful if people find some dependency 
conflicts or want to upgrade the version of a dependency library, and want to 
resolve it by themselves.

I think people wont't use the assembly jar in a pom.xml. So I think we can 
publish the assembly jar under the same artifact.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113344386
  
Actually, I dont think we can publish two artifacts from same project. Nor
do we need to. No one needs to the single jar for anything, only the
assembly jar. Rather we should publish just publish the assembly. May be
maintain the same name just publish the assembly jar instead.


On Thu, Jun 18, 2015 at 6:59 PM, Shixiong Zhu 
wrote:

> @srowen  do you have an example to publish
> both the single jar and the assembly jar?
>
> Two approaches I'm thinking about:
> 1. Upload the assembly jar in the same artifact: flume-sink.
> 2. Create a new artifact for the assembly jar just like the kafka-assembly
> module. And we need to generate a new pom.xml for the assembly jar.
>
> I prefer 1 because I don't know how to implement 2 in maven. What do you
> think?
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[zsxwing]

Github user zsxwing commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113339743
  
@srowen do you have an example to publish both the single jar and the 
assembly jar? 

Two approaches I'm thinking about:
1. Upload the assembly jar in the same artifact: flume-sink.
2. Create a new artifact for the assembly jar just like the kafka-assembly 
module. And we need to generate a new pom.xml for the assembly jar.

I prefer 1 because I don't know how to implement 2 in maven. What do you 
think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/6829


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113292109
  
@zsxwing Then lets try to build an assembly. But for the benefit of 
branch-1.4 I am going to merge this PR to master and 1.4 (so that the docs are 
updated for 1.4.1). But then lets create a separate JIRA and PR for the 
assembly.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[harishreedharan]

Github user harishreedharan commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113029848
  
+1 on creating assembly. I am not entirely sure what it takes to generate 
the assembly, but if it is possible to add that to the current sink module, 
that would be great. I doubt this would affect any existing deployments in any 
way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113024805
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113024787
  
  [Test build #35074 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35074/console)
 for   PR 6829 at commit 
[`f8617f0`](https://github.com/apache/spark/commit/f8617f0ea073b4cf5fcafce7b8295ac0046d477e).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113005987
  
  [Test build #35074 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35074/consoleFull)
 for   PR 6829 at commit 
[`f8617f0`](https://github.com/apache/spark/commit/f8617f0ea073b4cf5fcafce7b8295ac0046d477e).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113004760
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113004694
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[JoshRosen]

Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113002892
  
Jenkins, retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[JoshRosen]

Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-113003052
  
(I'm retesting this to see whether our new Jenkins PRB script is properly 
skipping the tests for doc-only changes)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[tdas]

Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-112969135
  
I think the assembly is a good idea. Though for that we will have to 
1. publish the assembly JAR instead of package JAR. It will be cumbersome 
to add additional flume-sink-assembly directory for this. Maybe we can make the 
existing flume-sink project generate and publish the assembly instead of the 
package.
2. Update instructions. I am not sure this will much impact existing 
deployments, because they are supposed to download and run the version of sink 
that is necessary for the version of Spark they are running.

@harishreedharan What do you think about this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-112080610
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-112080561
  
  [Test build #34936 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34936/console)
 for   PR 6829 at commit 
[`f8617f0`](https://github.com/apache/spark/commit/f8617f0ea073b4cf5fcafce7b8295ac0046d477e).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[zsxwing]

Github user zsxwing commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-112071017
  
> OK but surely it's easier to make an assembly target than tell people 
they have to piece together the dependencies and keep updating docs about it?

ping @tdas about the assembly idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-112068466
  
OK but surely it's easier to make an assembly target than tell people they 
have to piece together the dependencies and keep updating docs about it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[zsxwing]

Github user zsxwing commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-112063658
  
> This is built into the assembly though, right?

No. Spark Flume Sink does not assemble the dependencies. Actually, now we 
don't have an assembly jar for Flume.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-112058266
  
This is built into the assembly though, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-112040285
  
  [Test build #34936 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34936/consoleFull)
 for   PR 6829 at commit 
[`f8617f0`](https://github.com/apache/spark/commit/f8617f0ea073b4cf5fcafce7b8295ac0046d477e).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-112039637
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6829#issuecomment-112039618
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8376][Docs]Add common lang3 to the Spar...

[zsxwing]

GitHub user zsxwing opened a pull request:

https://github.com/apache/spark/pull/6829

[SPARK-8376][Docs]Add common lang3 to the Spark Flume Sink doc

Commons Lang 3 has been added as one of the dependencies of Spark Flume 
Sink since #5703. This PR updates the doc for it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zsxwing/spark flume-sink-dep

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/6829.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6829


commit f8617f0ea073b4cf5fcafce7b8295ac0046d477e
Author: zsxwing 
Date:   2015-06-15T12:10:16Z

Add common lang3 to the Spark Flume Sink doc




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org