[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113814335 LGTM merging into branch-1.4 and master Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6905 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113629487 [Test build #35311 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35311/console) for PR 6905 at commit [`16e3b2c`](https://github.com/apache/spark/commit/16e3b2cbe4f0027a66e0cc68622b53ae503c2a37). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113629511 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/6905#issuecomment-113651697
@viirya Could you fix the python unit tests?
~~~
**
File
/home/jenkins/workspace/SparkPullRequestBuilder/python/pyspark/ml/evaluation.py,
line 162, in __main__.RegressionEvaluator
Failed example:
evaluator.evaluate(dataset)
Expected:
2.842...
Got:
-2.8424854081906372
**
File
/home/jenkins/workspace/SparkPullRequestBuilder/python/pyspark/ml/evaluation.py,
line 166, in __main__.RegressionEvaluator
Failed example:
evaluator.evaluate(dataset, {evaluator.metricName: mae})
Expected:
2.649...
Got:
-2.649645429996
**
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113702249 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113702266 [Test build #35351 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35351/consoleFull) for PR 6905 at commit [`930d3db`](https://github.com/apache/spark/commit/930d3dbe132fcce7b78320e9730bbd5e7bfc7894). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113702242 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113695171 @viirya Could you also please document the meaning of the various metrics in RegressionEvaluator? Users will be surprised that those values are negated. The doc can go in the metricName Param Scala/Python doc. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113710323 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113710317 [Test build #35351 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35351/console) for PR 6905 at commit [`930d3db`](https://github.com/apache/spark/commit/930d3dbe132fcce7b78320e9730bbd5e7bfc7894). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class StreamingKMeansModel(KMeansModel):` * `class StreamingKMeans(object):` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user chelseaz commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113581694 Thanks for the fix @viirya! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113582385 Arguing with myself: I see the value of the eval is used in some log statements including its mean. This may be a little less than useful when it is some inverse RMSE but still probably a decent solution --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113613633 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113614212 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113614228 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113614728 [Test build #35311 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35311/consoleFull) for PR 6905 at commit [`16e3b2c`](https://github.com/apache/spark/commit/16e3b2cbe4f0027a66e0cc68622b53ae503c2a37). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113606235 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8468][ML] Take the negative of some met...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6905#issuecomment-113606178 [Test build #35285 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35285/console) for PR 6905 at commit [`16e3b2c`](https://github.com/apache/spark/commit/16e3b2cbe4f0027a66e0cc68622b53ae503c2a37). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
