[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-08-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/8039


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-08-07 Thread jkbradley
Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/8039#issuecomment-128840782
  
Merging with master, branch-1.5  (using LGTM from previous PR)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8039#issuecomment-128839068
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-08-07 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/8039#issuecomment-128838979
  
  [Test build #40191 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40191/console)
 for   PR 8039 at commit 
[`bfbedc4`](https://github.com/apache/spark/commit/bfbedc4c31fa1b9f2be245381c7ce6debffc653a).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-08-07 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/8039#issuecomment-128832060
  
  [Test build #40191 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40191/consoleFull)
 for   PR 8039 at commit 
[`bfbedc4`](https://github.com/apache/spark/commit/bfbedc4c31fa1b9f2be245381c7ce6debffc653a).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8039#issuecomment-128831892
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8039#issuecomment-128831871
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-08-07 Thread jkbradley
GitHub user jkbradley opened a pull request:

https://github.com/apache/spark/pull/8039

[SPARK-8481] [MLlib] GaussianMixtureModel predict accepting single vector

Resubmit of [https://github.com/apache/spark/pull/6906] for adding 
single-vec predict to GMMs

CC: @dkobylarz  @mengxr 

To be merged with master and branch-1.5

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jkbradley/spark gmm-predict-vec

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/8039.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8039


commit bfbedc4c31fa1b9f2be245381c7ce6debffc653a
Author: Dariusz Kobylarz 
Date:   2015-07-16T22:29:19Z

[SPARK-8481] [MLlib] GaussianMixtureModel predict accepting single vector




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-20 Thread jkbradley
Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-123170860
  
@dkobylarz Could you please update the PR description to say what was done 
in this PR? It will become part of the git commit message (so the current 
description does not quite fit).

Also, as you make updates, it is helpful if you only rebase in order to fix 
merge conflicts.  Otherwise, it's hard to tell what changes you have made in 
each update.

I'll take another look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-122138889
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-16 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-122138721
  
  [Test build #37547 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37547/consoleFull)
 for   PR 6906 at commit 
[`cef1f0a`](https://github.com/apache/spark/commit/cef1f0a1518b005975ff69deb460221276423b33).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-16 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-122122943
  
  [Test build #37547 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37547/consoleFull)
 for   PR 6906 at commit 
[`cef1f0a`](https://github.com/apache/spark/commit/cef1f0a1518b005975ff69deb460221276423b33).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-122122419
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-122122403
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/6906#discussion_r34198402
  
--- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixtureModel.scala
 ---
@@ -84,6 +90,14 @@ class GaussianMixtureModel(
   }
 
   /**
+   * Given the input vector, return the membership values
--- End diff --

Will this fit on 1 line (<= 100 chars)?  If so, please do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/6906#discussion_r34198404
  
--- Diff: 
mllib/src/test/scala/org/apache/spark/mllib/clustering/GaussianMixtureSuite.scala
 ---
@@ -148,6 +148,30 @@ class GaussianMixtureSuite extends SparkFunSuite with 
MLlibTestSparkContext {
 }
   }
 
+  test("model prediction, parallel and local") {
+
--- End diff --

scala style: Please eliminate all of these extra newlines and only use 
newlines for logical divides.  See other tests for examples.

Please review 
[https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/6906#discussion_r34198407
  
--- Diff: 
mllib/src/test/scala/org/apache/spark/mllib/clustering/GaussianMixtureSuite.scala
 ---
@@ -148,6 +148,30 @@ class GaussianMixtureSuite extends SparkFunSuite with 
MLlibTestSparkContext {
 }
   }
 
+  test("model prediction, parallel and local") {
+
+val data = sc.parallelize(GaussianTestData.data)
+
+val gmm = new GaussianMixture().setK(2).setSeed(0).run(data)
+
+val batchPredictions = gmm.predict(data).collect()
--- End diff --

Be careful about assuming rows are returned in the same order.  It 
generally works but is not guaranteed.  Instead, how about doing:
```
val batchPredictions = gmm.predict(data)
batchPredictions.zip(data).collect().foreach { case (batchPred, datum) =>
  assert(batchPred === gmm.predict(datum))
}
```
Note the use of triple equals (better type handling).

Same for soft predictions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-08 Thread jkbradley
Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/6906#discussion_r34198399
  
--- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixtureModel.scala
 ---
@@ -66,6 +66,12 @@ class GaussianMixtureModel(
 responsibilityMatrix.map(r => r.indexOf(r.max))
   }
 
+  /** Maps given point to its cluster index. */
+  def predict(point: Vector) : Int = {
--- End diff --

scala style: no space between parenthesis and colon


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-08 Thread jkbradley
Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-119728659
  
@dkobylarz Could you please update the PR description to say what was done 
in this PR?  It will become part of the git commit message (so the current 
description does not quite fit).

Jenkins test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-08 Thread hadfield
Github user hadfield commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-119706005
  
Jenkins, retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-06 Thread dkobylarz
Github user dkobylarz commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-119005632
  
I quickly reviewed the Jenkins log. Mllib tests seem to be passed, it's the 
sql test that fails. Have there been any changes to 1.4 branch that are 
responsible for it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-118829147
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-06 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-118829112
  
  [Test build #36568 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36568/consoleFull)
 for   PR 6906 at commit 
[`54af203`](https://github.com/apache/spark/commit/54af2036778f20def47d6f2172598f41ac281894).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-06 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-118798311
  
  [Test build #36568 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36568/consoleFull)
 for   PR 6906 at commit 
[`54af203`](https://github.com/apache/spark/commit/54af2036778f20def47d6f2172598f41ac281894).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-118796657
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-118796564
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-05 Thread jkbradley
Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-118661622
  
Great thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-02 Thread dkobylarz
Github user dkobylarz commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-118197018
  
it will be added on Monday


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-07-01 Thread jkbradley
Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-117793356
  
Ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-24 Thread jkbradley
Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-115022178
  
@dkobylarz Thanks for the PR!  This looks fine, but could you please add a 
simple test to the unit tests?  It could be a new unit test in the GMM suite, 
or just an extra line testing this method in an existing unit test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113661689
  
  [Test build #35318 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35318/consoleFull)
 for   PR 6906 at commit 
[`cb87180`](https://github.com/apache/spark/commit/cb87180516973caf772c95405a39b3f9bd627272).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113661713
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113632802
  
  [Test build #35318 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35318/consoleFull)
 for   PR 6906 at commit 
[`cb87180`](https://github.com/apache/spark/commit/cb87180516973caf772c95405a39b3f9bd627272).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113632359
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113632377
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113605228
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113605226
  
  [Test build #35306 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35306/consoleFull)
 for   PR 6906 at commit 
[`dce2432`](https://github.com/apache/spark/commit/dce2432a21310c6feffd5d6bad3de99c7138c71f).
 * This patch **fails Scala style tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113604854
  
  [Test build #35306 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35306/consoleFull)
 for   PR 6906 at commit 
[`dce2432`](https://github.com/apache/spark/commit/dce2432a21310c6feffd5d6bad3de99c7138c71f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113604119
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113604092
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread JoshRosen
Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113604117
  
I think that this particular build failure is due to code that failed our 
style checker being committed to master; we've fixed this with a hotfix commit.

You can use the `dev/lint-scala` script to run these style checks yourself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread JoshRosen
Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113604001
  
Jenkins, retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread dkobylarz
Github user dkobylarz commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113603121
  
A blank line with two space characters (added by IDE) caused the test to 
fail. Is there some source code validation tool I could apply to my code before 
contributing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113582910
  
  [Test build #35290 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35290/consoleFull)
 for   PR 6906 at commit 
[`dce2432`](https://github.com/apache/spark/commit/dce2432a21310c6feffd5d6bad3de99c7138c71f).
 * This patch **fails Scala style tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113582913
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113582323
  
  [Test build #35290 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35290/consoleFull)
 for   PR 6906 at commit 
[`dce2432`](https://github.com/apache/spark/commit/dce2432a21310c6feffd5d6bad3de99c7138c71f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113581751
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113581771
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread mengxr
Github user mengxr commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113580828
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113541966
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread srowen
Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/6906#issuecomment-113545058
  
OK to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-8481] [MLlib] GaussianMixtureModel pred...

2015-06-19 Thread dkobylarz
GitHub user dkobylarz opened a pull request:

https://github.com/apache/spark/pull/6906

[SPARK-8481] [MLlib] GaussianMixtureModel predict accepting single vector

This PR addresses the issue I have just reported. After taking a look at 
the code It seemed trivial to implement.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dkobylarz/spark branch-1.4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/6906.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6906


commit dce2432a21310c6feffd5d6bad3de99c7138c71f
Author: Dariusz Kobylarz 
Date:   2015-06-19T15:01:22Z

[SPARK-8481] [MLlib] GaussianMixtureModel predict accepting single vector




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org