[GitHub] spark pull request: [SPARK-8660][ML] Convert JavaDoc style comment...
Github user Rosstin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7096#discussion_r33719147
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -211,22 +211,22 @@ class LogisticRegressionSuite extends SparkFunSuite
with MLlibTestSparkContext {
val trainer = (new LogisticRegression).setFitIntercept(true)
val model = trainer.fit(binaryDataset)
-/**
- * Using the following R code to load the data and train the model
using glmnet package.
- *
- * > library("glmnet")
- * > data <- read.csv("path", header=FALSE)
- * > label = factor(data$V1)
- * > features = as.matrix(data.frame(data$V2, data$V3, data$V4,
data$V5))
- * > weights = coef(glmnet(features,label, family="binomial", alpha =
0, lambda = 0))
- * > weights
- * 5 x 1 sparse Matrix of class "dgCMatrix"
- * s0
- * (Intercept) 2.8366423
- * data.V2 -0.5895848
- * data.V3 0.8931147
- * data.V4 -0.3925051
- * data.V5 -0.7996864
+/*
+ Using the following R code to load the data and train the model
using glmnet package.
+
+ > library("glmnet")
--- End diff --
Sure, no problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660][ML] Convert JavaDoc style comment...
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7096#discussion_r33714575
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -211,22 +211,22 @@ class LogisticRegressionSuite extends SparkFunSuite
with MLlibTestSparkContext {
val trainer = (new LogisticRegression).setFitIntercept(true)
val model = trainer.fit(binaryDataset)
-/**
- * Using the following R code to load the data and train the model
using glmnet package.
- *
- * > library("glmnet")
- * > data <- read.csv("path", header=FALSE)
- * > label = factor(data$V1)
- * > features = as.matrix(data.frame(data$V2, data$V3, data$V4,
data$V5))
- * > weights = coef(glmnet(features,label, family="binomial", alpha =
0, lambda = 0))
- * > weights
- * 5 x 1 sparse Matrix of class "dgCMatrix"
- * s0
- * (Intercept) 2.8366423
- * data.V2 -0.5895848
- * data.V3 0.8931147
- * data.V4 -0.3925051
- * data.V5 -0.7996864
+/*
+ Using the following R code to load the data and train the model
using glmnet package.
+
+ > library("glmnet")
+ > data <- read.csv("path", header=FALSE)
+ > label = factor(data$V1)
+ > features = as.matrix(data.frame(data$V2, data$V3, data$V4,
data$V5))
+ > weights = coef(glmnet(features,label, family="binomial", alpha =
0, lambda = 0))
+ > weights
--- End diff --
If we remove `>`, please insert an empty line to separate commands and
results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660][ML] Convert JavaDoc style comment...
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7096#discussion_r33714571
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -211,22 +211,22 @@ class LogisticRegressionSuite extends SparkFunSuite
with MLlibTestSparkContext {
val trainer = (new LogisticRegression).setFitIntercept(true)
val model = trainer.fit(binaryDataset)
-/**
- * Using the following R code to load the data and train the model
using glmnet package.
- *
- * > library("glmnet")
- * > data <- read.csv("path", header=FALSE)
- * > label = factor(data$V1)
- * > features = as.matrix(data.frame(data$V2, data$V3, data$V4,
data$V5))
- * > weights = coef(glmnet(features,label, family="binomial", alpha =
0, lambda = 0))
- * > weights
- * 5 x 1 sparse Matrix of class "dgCMatrix"
- * s0
- * (Intercept) 2.8366423
- * data.V2 -0.5895848
- * data.V3 0.8931147
- * data.V4 -0.3925051
- * data.V5 -0.7996864
+/*
+ Using the following R code to load the data and train the model
using glmnet package.
+
+ > library("glmnet")
--- End diff --
@Rosstin Could you also remove `>`s? Then people can easily copy & paste.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660][ML] Convert JavaDoc style comment...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7096 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660][ML] Convert JavaDoc style comment...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7096#issuecomment-116856496 Thanks - merging this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660][ML] Convert JavaDoc style comment...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7096#issuecomment-116856432 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660][ML] Convert JavaDoc style comment...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7096#issuecomment-116856329 [Test build #36027 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36027/console) for PR 7096 at commit [`242aedd`](https://github.com/apache/spark/commit/242aeddcd949f23c86c5b3000e27019a901df64b). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class Hex(child: Expression)` * `case class Hypot(left: Expression, right: Expression)` * `case class Sha1(child: Expression) extends UnaryExpression with ExpectsInputTypes ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660][ML] Convert JavaDoc style comment...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7096#issuecomment-116845502 Thanks - LGTM. We can merge this once Jenkins comes back happy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
