[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7167#issuecomment-117904528 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7167#issuecomment-117856892 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7167#issuecomment-117856830 [Test build #36316 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36316/console) for PR 7167 at commit [`f4b9bc8`](https://github.com/apache/spark/commit/f4b9bc8994993c428092035d7b55c7aa632f5470). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7167#issuecomment-117848985 [Test build #36316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36316/consoleFull) for PR 7167 at commit [`f4b9bc8`](https://github.com/apache/spark/commit/f4b9bc8994993c428092035d7b55c7aa632f5470). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7167#issuecomment-117848599 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7167#issuecomment-117848593 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7167#issuecomment-117848104 LGTM pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7167#issuecomment-117848092 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user Rosstin commented on the pull request: https://github.com/apache/spark/pull/7167#issuecomment-117841525 @mengxr @holdenk Alright, I restored the multiline comments conforming to the 100-character rule --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7167#issuecomment-117837038 Let's keep the line width within 100. As @holdenk mentioned, we can copy & paste a paragraph of code to Scala and ipython easily. I also tried RStudio, which takes multiline statement as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/7167#issuecomment-117826411 For copypasteing in Scala mode :paste mode makes the multi-line copy/past work well (although requires remembering that + ctrl-d) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user Rosstin commented on the pull request: https://github.com/apache/spark/pull/7167#issuecomment-117820353 @mengxr Would it be desirable to un-multiline the LOC in the file's comments? Or should these remain multiline to follow style? (What I mean is, the lines are long enough that they were being broken into multiple lines, so copy-pasting them would be harder. I made them back into single-line.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7167#issuecomment-117820196 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8660] [MLLib] removed > symbols from co...
GitHub user Rosstin opened a pull request: https://github.com/apache/spark/pull/7167 [SPARK-8660] [MLLib] removed > symbols from comments in LogisticRegressionSuite.scala for ease of copypaste '>' symbols removed from comments in LogisticRegressionSuite.scala, for ease of copypaste also single-lined the multiline commands (is this desirable, or does it violate style?) You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rosstin/spark SPARK-8660-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/7167.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7167 commit 6c18058336a1a027207d194c31134351ec3ed86d Author: Rosstin Date: 2015-06-26T18:00:35Z fixed minor typos in docs/README.md and docs/api.md commit 21ac1e54283d633e5c4978427e03937b17c1b626 Author: Rosstin Date: 2015-06-29T17:06:15Z Merge branch 'master' of github.com:apache/spark into SPARK-8639 commit 2cd298520f7018fbd2fc5174f40a984db52b68a0 Author: Rosstin Date: 2015-06-29T20:06:15Z Merge branch 'master' of github.com:apache/spark into SPARK-8639 commit 242aeddcd949f23c86c5b3000e27019a901df64b Author: Rosstin Date: 2015-06-29T20:18:39Z SPARK-8660, changed comment style from JavaDoc style to normal multiline comment in order to make copypaste into R easier, in file classification/LogisticRegressionSuite.scala commit bb9a4b19487c55c826d0a49b1987dba9b4d7d031 Author: Rosstin Date: 2015-06-29T20:21:17Z Merge branch 'master' of github.com:apache/spark into SPARK-8660 commit 5a05dee9fb142e8997b85904d01a02964ed32553 Author: Rosstin Date: 2015-06-29T20:27:44Z SPARK-8661 for LinearRegressionSuite.scala, changed javadoc-style comments to regular multiline comments to make it easier to copy-paste the R code. commit 39ddd50ee27d80debf02cf9a5985c8bf2f4cb94c Author: Rosstin Date: 2015-07-01T20:13:37Z Merge branch 'master' of github.com:apache/spark into SPARK-8661 commit fe6b11224126adb5692292fbb8b8c1bc03c48f46 Author: Rosstin Date: 2015-07-01T20:40:41Z SPARK-8660 > symbols removed from LogisticRegressionSuite.scala for easy of copypaste --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
