[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7497 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122634880 Merging this - thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122634825 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122634820 [Test build #37765 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37765/console) for PR 7497 at commit [`8324dce`](https://github.com/apache/spark/commit/8324dceecb5e8bedc97544008a3dbb1d1f501ffb). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class IllegalArgumentException(Exception):` * `case class Hour(child: Expression) extends UnaryExpression with ImplicitCastInputTypes ` * `case class Minute(child: Expression) extends UnaryExpression with ImplicitCastInputTypes ` * `case class Second(child: Expression) extends UnaryExpression with ImplicitCastInputTypes ` * `case class DayInYear(child: Expression) extends UnaryExpression with ImplicitCastInputTypes ` * `case class Year(child: Expression) extends UnaryExpression with ImplicitCastInputTypes ` * `case class Quarter(child: Expression) extends UnaryExpression with ImplicitCastInputTypes ` * `case class Month(child: Expression) extends UnaryExpression with ImplicitCastInputTypes ` * `case class Day(child: Expression) extends UnaryExpression with ImplicitCastInputTypes ` * `case class WeekOfYear(child: Expression) extends UnaryExpression with ImplicitCastInputTypes ` * `case class DateFormatClass(left: Expression, right: Expression) extends BinaryExpression` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122634403 [Test build #37765 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37765/consoleFull) for PR 7497 at commit [`8324dce`](https://github.com/apache/spark/commit/8324dceecb5e8bedc97544008a3dbb1d1f501ffb). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122634362 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122634366 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122634158 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122634156 [Test build #37763 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37763/console) for PR 7497 at commit [`9ace67d`](https://github.com/apache/spark/commit/9ace67dede05115cfed7f4794867cd9dabe370d8). * This patch **fails Python style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122634134 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122634105 [Test build #37763 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37763/consoleFull) for PR 7497 at commit [`9ace67d`](https://github.com/apache/spark/commit/9ace67dede05115cfed7f4794867cd9dabe370d8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122634068 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122634065 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7497#discussion_r34952506 --- Diff: python/pyspark/sql/utils.py --- @@ -24,6 +24,12 @@ class AnalysisException(Exception): """ +class IllegalArgumentException(Exception): --- End diff -- Alright let's just use IllegalArgumentException then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7497#discussion_r34951172
--- Diff: python/pyspark/sql/tests.py ---
@@ -894,6 +894,13 @@ def test_capture_analysis_exception(self):
# RuntimeException should not be captured
self.assertRaises(py4j.protocol.Py4JJavaError, lambda:
self.sqlCtx.sql("abc"))
+def test_capture_illegalargument_exception(self):
+self.assertRaises(IllegalArgumentException,
+ lambda: self.sqlCtx.sql("SET
mapred.reduce.tasks=-1"))
--- End diff --
can the test case make sure the error message is still present? It would be
bad if we only show IllegalArgumentException, but no error message anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7497#discussion_r34951136 --- Diff: python/pyspark/sql/utils.py --- @@ -24,6 +24,12 @@ class AnalysisException(Exception): """ +class IllegalArgumentException(Exception): --- End diff -- Using IllegalArgumentException here will be more consistent with other API. Either one is good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7497#discussion_r34950004 --- Diff: python/pyspark/sql/utils.py --- @@ -24,6 +24,12 @@ class AnalysisException(Exception): """ +class IllegalArgumentException(Exception): --- End diff -- i suspect this can be replaced with just the normal ValueError, but let's cc @davies to confirm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122559380 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122559232 [Test build #37720 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37720/console) for PR 7497 at commit [`7be016a`](https://github.com/apache/spark/commit/7be016a047e76db6ce368cfd08fae7f65aeb58b0). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class IllegalArgumentException(Exception):` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122558493 [Test build #37720 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37720/consoleFull) for PR 7497 at commit [`7be016a`](https://github.com/apache/spark/commit/7be016a047e76db6ce368cfd08fae7f65aeb58b0). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122558002 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7497#issuecomment-122557993 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9166][SQL][PYSPARK] Capture and hide Il...
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/7497 [SPARK-9166][SQL][PYSPARK] Capture and hide IllegalArgumentException in Python API JIRA: https://issues.apache.org/jira/browse/SPARK-9166 Simply capture and hide `IllegalArgumentException` in Python API. You can merge this pull request into a Git repository by running: $ git pull https://github.com/viirya/spark-1 hide_illegalargument Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/7497.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7497 commit 7be016a047e76db6ce368cfd08fae7f65aeb58b0 Author: Liang-Chi Hsieh Date: 2015-07-18T15:47:41Z Capture and hide IllegalArgumentException in Python. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
