[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user rotationsymmetry commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-123135898 Hi @mengxr, thank you for merge. I have also fixed a similar bug in BLAS.gemv, as suggested by @brkyvz . Shall I make another pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-123110412 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-123110325 [Test build #37872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37872/console) for PR 7503 at commit [`fce199c`](https://github.com/apache/spark/commit/fce199c3419b36a8c6d69d7b9eb293c7d4185b59). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-123102238 Merged into master and all branches since 1.2. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7503 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-123099497 I like @brkyvz 's idea about calling `scal` when `alpha == 0`. It would be a noop when `beta == 0`, but handled by `scal`. Since this is a bug, I would like to merge this first and have follow-up JIRAs to implement `scal`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-123098736 [Test build #37872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37872/consoleFull) for PR 7503 at commit [`fce199c`](https://github.com/apache/spark/commit/fce199c3419b36a8c6d69d7b9eb293c7d4185b59). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-123098525 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-123098485 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-123098568 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user rotationsymmetry commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-122933155 @brkyvz 1) I will put in the same check to gemv if everybody agrees. 2) scal for (dense or sparse) matrices will be helpful. I could implement it as well. Will this be considered as new API? cc @srowen @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-122918985 Can we add the same check to gemv please? In addition, instead of calling the dgemm routine to just scale C, maybe we can just call f2jBlas.scal? @mengxr What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-122804300 @brkyvz is this OK with you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-122645924 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-122645909 [Test build #37768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37768/console) for PR 7503 at commit [`fce199c`](https://github.com/apache/spark/commit/fce199c3419b36a8c6d69d7b9eb293c7d4185b59). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-122638160 [Test build #37768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37768/consoleFull) for PR 7503 at commit [`fce199c`](https://github.com/apache/spark/commit/fce199c3419b36a8c6d69d7b9eb293c7d4185b59). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-122638019 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-122638017 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-122637916 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-122637915 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-122606318 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7503#issuecomment-122605981 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9175] [MLlib] BLAS.gemm fails to update...
GitHub user rotationsymmetry opened a pull request: https://github.com/apache/spark/pull/7503 [SPARK-9175] [MLlib] BLAS.gemm fails to update matrix C when alpha==0 and beta!=1 Fix BLAS.gemm to update matrix C when alpha==0 and beta!=1 Also include unit tests to verify the fix. @mengxr @brkyvz You can merge this pull request into a Git repository by running: $ git pull https://github.com/rotationsymmetry/spark fix_BLAS_gemm Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/7503.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7503 commit fce199c3419b36a8c6d69d7b9eb293c7d4185b59 Author: Meihua Wu Date: 2015-07-18T23:00:43Z Fix BLAS.gemm to update C when alpha==0 and beta!=1 Also included tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
