[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8159 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-131209839 Merging this in master (not branch-1.5). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-131195304 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130977814 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130976967 [Test build #40843 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40843/console) for PR 8159 at commit [`39ce9c7`](https://github.com/apache/spark/commit/39ce9c738e159b1c2a5517e6bd8d6f5d1b952b14). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8159#discussion_r37050438
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -1150,6 +1150,23 @@ class DataFrame private[sql](
}
/**
+ * Returns a new [[DataFrame]] by adding a column with metadata.
+ */
+ private[spark] def withColumn(colName: String, col: Column, metadata:
Metadata): DataFrame = {
--- End diff --
Don't think we can change that since it's been public since 1.3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8159#discussion_r37050371
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -1150,6 +1150,23 @@ class DataFrame private[sql](
}
/**
+ * Returns a new [[DataFrame]] by adding a column with metadata.
+ */
+ private[spark] def withColumn(colName: String, col: Column, metadata:
Metadata): DataFrame = {
--- End diff --
should we make `Column.as(alias: String, metadata: Metadata)` also private?
As it also expose the `Metadata` too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130966333 The API change LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130957867 [Test build #40843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40843/consoleFull) for PR 8159 at commit [`39ce9c7`](https://github.com/apache/spark/commit/39ce9c738e159b1c2a5517e6bd8d6f5d1b952b14). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130957065 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130957124 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130936203 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130936201 [Test build #40841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40841/console) for PR 8159 at commit [`11c5575`](https://github.com/apache/spark/commit/11c5575f569d80cbbf9415cddfaa86a153a9601b). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130935142 [Test build #40841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40841/consoleFull) for PR 8159 at commit [`11c5575`](https://github.com/apache/spark/commit/11c5575f569d80cbbf9415cddfaa86a153a9601b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130934044 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130934034 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130903815 OK @cloud-fan let's make this private[spark] for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130903532 ML does not need it to be public. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130890183 Does the new function needs to be public? Can it be private[spark] ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130870552 The ML changes look good. (Thanks for adding this.) The new method looks fine, unless you want to reduce code duplication. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8159#discussion_r37034675 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -1150,6 +1150,25 @@ class DataFrame private[sql]( } /** + * Returns a new [[DataFrame]] by adding a column with medadata. --- End diff -- typo: metadata --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130555873 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130555772 [Test build #40732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40732/console) for PR 8159 at commit [`4698d05`](https://github.com/apache/spark/commit/4698d05db5e874cc6cb7aa3dced022809bf3ba3d). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130531949 [Test build #40732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40732/consoleFull) for PR 8159 at commit [`4698d05`](https://github.com/apache/spark/commit/4698d05db5e874cc6cb7aa3dced022809bf3ba3d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130529657 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130529363 cc @marmbrus @rxin , this blocks https://github.com/apache/spark/pull/7957 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8159#issuecomment-130529604 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9929][SQL] support metadata in withColu...
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/8159 [SPARK-9929][SQL] support metadata in withColumn in MLlib sometimes we need to set metadata for the new column, thus we will alias the new column with metadata before call `withColumn` and in `withColumn` we alias this clolumn again. Here I overloaded `withColumn` to allow user set metadata, just like what we did for `Column.as`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloud-fan/spark withColumn Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8159.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8159 commit 4698d05db5e874cc6cb7aa3dced022809bf3ba3d Author: Wenchen Fan Date: 2015-08-13T04:24:42Z support metadata in withColumn --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
