[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-212405238 @srowen thank you for the review & merging :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-212371700 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12450 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211721783 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211721784 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56175/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211721561 **[Test build #56175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56175/consoleFull)** for PR 12450 at commit [`feefa8d`](https://github.com/apache/spark/commit/feefa8d2e5d0986e61b7e9374bb28c3a16b09904). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211681445 **[Test build #56175 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56175/consoleFull)** for PR 12450 at commit [`feefa8d`](https://github.com/apache/spark/commit/feefa8d2e5d0986e61b7e9374bb28c3a16b09904). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211679362 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211546728 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56077/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211546724 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211546454 **[Test build #56077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56077/consoleFull)** for PR 12450 at commit [`feefa8d`](https://github.com/apache/spark/commit/feefa8d2e5d0986e61b7e9374bb28c3a16b09904). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211487542 **[Test build #56077 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56077/consoleFull)** for PR 12450 at commit [`feefa8d`](https://github.com/apache/spark/commit/feefa8d2e5d0986e61b7e9374bb28c3a16b09904). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211209966 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211016252 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56051/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211016251 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211016164 **[Test build #56051 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56051/consoleFull)** for PR 12450 at commit [`feefa8d`](https://github.com/apache/spark/commit/feefa8d2e5d0986e61b7e9374bb28c3a16b09904). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211003918 **[Test build #56051 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56051/consoleFull)** for PR 12450 at commit [`feefa8d`](https://github.com/apache/spark/commit/feefa8d2e5d0986e61b7e9374bb28c3a16b09904). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211003756 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12450#discussion_r59982497 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala --- @@ -39,7 +39,7 @@ class FileStreamSource( providerName: String, dataFrameBuilder: Array[String] => DataFrame) extends Source with Logging { - private val fs = FileSystem.get(sqlContext.sparkContext.hadoopConfiguration) + private val fs = new Path(path).getFileSystem(sqlContext.sparkContext.hadoopConfiguration) --- End diff -- All LGTM pending tests. I suppose this could even be fetched in the one place it's used later during the method call rather than hold on to a reference, but, I can't recall a specific reason it's bad to hold onto a FileSystem handle, so, leave it as you've done I think. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211001455 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211001456 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56044/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-211001432 **[Test build #56044 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56044/consoleFull)** for PR 12450 at commit [`feefa8d`](https://github.com/apache/spark/commit/feefa8d2e5d0986e61b7e9374bb28c3a16b09904). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12450#issuecomment-210983321 **[Test build #56044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56044/consoleFull)** for PR 12450 at commit [`feefa8d`](https://github.com/apache/spark/commit/feefa8d2e5d0986e61b7e9374bb28c3a16b09904). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [Spark-14687][Core][SQL][MLlib] Call path.getF...
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12450 [Spark-14687][Core][SQL][MLlib] Call path.getFileSystem(conf) instead of call FileSystem.get(conf) ## What changes were proposed in this pull request? - replaced `FileSystem.get(conf)` calls with `path.getFileSystem(conf)` ## How was this patch tested? N/A You can merge this pull request into a Git repository by running: $ git pull https://github.com/lw-lin/spark fix-fs-get Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12450.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12450 commit feefa8d2e5d0986e61b7e9374bb28c3a16b09904 Author: Liwei LinDate: 2016-04-17T06:25:03Z should call path.getFileSystem(conf) instead of call FileSystem.get(cont) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org