[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-31 Thread jkbradley
Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-107233326
  
No problem (and thanks for catching that other typo I missed).  Merging 
into master and branch-1.4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-31 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/6498


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-31 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-107135215
  
  [Test build #33846 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33846/consoleFull)
 for   PR 6498 at commit 
[`7f9f06d`](https://github.com/apache/spark/commit/7f9f06dcf621ac990ea2d1270801ee89d72ccb40).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-31 Thread hhbyyh
Github user hhbyyh commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-107135180
  
This is awkward... Thanks a lot for the careful review.
Guess I just focused on the save/load part. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-107135183
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-107135178
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-31 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-107146958
  
  [Test build #33846 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33846/consoleFull)
 for   PR 6498 at commit 
[`7f9f06d`](https://github.com/apache/spark/commit/7f9f06dcf621ac990ea2d1270801ee89d72ccb40).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-107146959
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-30 Thread jkbradley
Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/6498#discussion_r31385428
  
--- Diff: docs/mllib-isotonic-regression.md ---
@@ -88,6 +88,10 @@ val predictionAndLabel = test.map { point =
 // Calculate mean squared error between predicted and real labels.
 val meanSquaredError = predictionAndLabel.map{case(p, l) = math.pow((p - 
l), 2)}.mean()
 println(Mean Squared Error =  + meanSquaredError)
+
+// Save and load model
+model.save(sc, myModelPath)
+val sameModel = IsotonicRegressionModel.load(sc, myModelPath)
--- End diff --

import IsotonicRegressionModel


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-30 Thread jkbradley
Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/6498#discussion_r31385423
  
--- Diff: docs/mllib-clustering.md ---
@@ -63,6 +63,10 @@ val clusters = KMeans.train(parsedData, numClusters, 
numIterations)
 val WSSSE = clusters.computeCost(parsedData)
 println(Within Set Sum of Squared Errors =  + WSSSE)
 {% endhighlight %}
+
+// Save and load model
--- End diff --

Oops!  I missed this before.  This should go before the endhighlight.

Also, you now need to import KMeansModel


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-30 Thread jkbradley
Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/6498#discussion_r31385425
  
--- Diff: docs/mllib-clustering.md ---
@@ -325,6 +337,10 @@ val model = pic.run(similarities)
 model.assignments.foreach { a =
   println(s${a.id} - ${a.cluster})
 }
+
+// Save and load model
+model.save(sc, myModelPath)
+val sameModel = PowerIterationClusteringModel.load(sc, myModelPath)
--- End diff --

ditto: import PowerIterationClusteringModel


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-30 Thread jkbradley
Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/6498#discussion_r31385424
  
--- Diff: docs/mllib-clustering.md ---
@@ -143,6 +151,10 @@ def error(point):
 
 WSSSE = parsedData.map(lambda point: error(point)).reduce(lambda x, y: x + 
y)
 print(Within Set Sum of Squared Error =  + str(WSSSE))
+
+# Save and load model
+clusters.save(sc, myModelPath)
+sameModel = KMeansModel.load(sc, myModelPath)
--- End diff --

ditto: import KMeansModel


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-30 Thread jkbradley
Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/6498#discussion_r31385426
  
--- Diff: docs/mllib-feature-extraction.md ---
@@ -201,6 +201,11 @@ val synonyms = model.findSynonyms(china, 40)
 for((synonym, cosineSimilarity) - synonyms) {
   println(s$synonym $cosineSimilarity)
 }
+
+// Save and load model
+model.save(sc, myModelPath)
+val sameModel = Word2VecModel.load(sc, myModelPath)
--- End diff --

import Word2VecModel


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-30 Thread jkbradley
Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-107098635
  
I missed these items on my first pass---and I remember making the same 
mistakes when I first wrote save/load examples!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-29 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-106788130
  
  [Test build #33735 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33735/consoleFull)
 for   PR 6498 at commit 
[`1dd77cc`](https://github.com/apache/spark/commit/1dd77cc8fe836ba7bc5ef134ed05301709ddc422).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-106787813
  
 Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-106787827
  
Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-29 Thread hhbyyh
GitHub user hhbyyh opened a pull request:

https://github.com/apache/spark/pull/6498

[Spark-7949] [MLlib] [Doc] update document with some missing save/load

add save load for examples:
KMeansModel
PowerIterationClusteringModel
Word2VecModel
IsotonicRegressionModel

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hhbyyh/spark docSaveLoad

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/6498.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6498


commit 1dd77cc8fe836ba7bc5ef134ed05301709ddc422
Author: Yuhao Yang hhb...@gmail.com
Date:   2015-05-29T12:08:32Z

update document with some missing save/load




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-29 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-106818602
  
  [Test build #33735 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33735/consoleFull)
 for   PR 6498 at commit 
[`1dd77cc`](https://github.com/apache/spark/commit/1dd77cc8fe836ba7bc5ef134ed05301709ddc422).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-106818675
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-29 Thread jkbradley
Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-106953044
  
@hhbyyh  I don't see any problems.  Just to confirm, have you run all of 
the updated examples?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [Spark-7949] [MLlib] [Doc] update document wit...

2015-05-29 Thread hhbyyh
Github user hhbyyh commented on the pull request:

https://github.com/apache/spark/pull/6498#issuecomment-106973866
  
@jkbradley. Sure, I have verified the changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org