[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39701471 Ok I pushed another change for generators. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39701605 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39701614 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39701865 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39701876 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39701962 The default eval method is for things like `UnresolvedAttribute` or `AttributeReference`, though we could probably special case the failure there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39702050 Yea I think it makes sense to put UnsupportedOperations on those rather than having a generic implementation for eval. It is less error-prone that way. I can make that change after this one goes in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39703070 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39704394 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13839/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39704393 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13840/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39704389 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39704390 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39708005 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39708020 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39710934 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13842/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39710933 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/340 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/340 [sql] Rename Expression.apply to eval for better readability. I didn't rename the table generator function yet - we might want a different name for those. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rxin/spark eval Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/340.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #340 commit ea061decc5eeb531347a1ebb2d11f522fe49c565 Author: Reynold Xin r...@apache.org Date: 2014-04-07T01:27:01Z Rename Expression.apply to eval for better readability. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39689824 @marmbrus I was looking over the code. How come we have a default implementation for the Expression.eval/apply? Don't we want a concrete expression implementation to fail if it doesn't implement apply? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39689858 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39689853 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39691697 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [sql] Rename Expression.apply to eval for bett...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/340#issuecomment-39691699 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13829/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
