[GitHub] spark pull request: Drop VD type parameter from EdgeRDD
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3303#issuecomment-63267732 [Test build #23467 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23467/consoleFull) for PR 3303 at commit [`38dca9b`](https://github.com/apache/spark/commit/38dca9bbb8f3799cbe531680edffbeba7b75e40b). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Drop VD type parameter from EdgeRDD
Github user ankurdave commented on a diff in the pull request:
https://github.com/apache/spark/pull/3303#discussion_r20420549
--- Diff:
graphx/src/main/scala/org/apache/spark/graphx/impl/GraphImpl.scala ---
@@ -336,8 +337,8 @@ object GraphImpl {
*/
def fromExistingRDDs[VD: ClassTag, ED: ClassTag](
vertices: VertexRDD[VD],
- edges: EdgeRDD[ED, VD]): GraphImpl[VD, ED] = {
-new GraphImpl(vertices, new ReplicatedVertexView(edges))
+ edges: EdgeRDD[ED]): GraphImpl[VD, ED] = {
+new GraphImpl(vertices, new
ReplicatedVertexView(edges.asInstanceOf[EdgeRDDImpl[ED, VD]]))
--- End diff --
Unfortunately, here we have to remove the statically-checked constraint
that the cached vertices in `edges` are of the correct type (`VD`). Preserving
this static constraint would require fromExistingRDDs to take an EdgeRDDImpl,
which would be a breaking change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Drop VD type parameter from EdgeRDD
Github user jegonzal commented on the pull request: https://github.com/apache/spark/pull/3303#issuecomment-63267156 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Drop VD type parameter from EdgeRDD
Github user ankurdave commented on a diff in the pull request: https://github.com/apache/spark/pull/3303#discussion_r20420408 --- Diff: graphx/src/main/scala/org/apache/spark/graphx/impl/EdgeRDDImpl.scala --- @@ -75,20 +75,20 @@ class EdgeRDDImpl[ED: ClassTag, VD: ClassTag] private[graphx] ( partitionsRDD.map(_._2.size.toLong).reduce(_ + _) } - override def mapValues[ED2: ClassTag](f: Edge[ED] => ED2): EdgeRDD[ED2, VD] = + override def mapValues[ED2: ClassTag](f: Edge[ED] => ED2): EdgeRDDImpl[ED2, VD] = mapEdgePartitions((pid, part) => part.map(f)) - override def reverse: EdgeRDD[ED, VD] = mapEdgePartitions((pid, part) => part.reverse) + override def reverse: EdgeRDDImpl[ED, VD] = mapEdgePartitions((pid, part) => part.reverse) - override def filter( + def filter( --- End diff -- We had to remove `filter` from EdgeRDD and move it exclusively to EdgeRDDImpl because it depends on vertex attribute caching. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Drop VD type parameter from EdgeRDD
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/3303#discussion_r20420325 --- Diff: graphx/src/main/scala/org/apache/spark/graphx/impl/EdgeRDDImpl.scala --- @@ -75,20 +75,20 @@ class EdgeRDDImpl[ED: ClassTag, VD: ClassTag] private[graphx] ( partitionsRDD.map(_._2.size.toLong).reduce(_ + _) } - override def mapValues[ED2: ClassTag](f: Edge[ED] => ED2): EdgeRDD[ED2, VD] = + override def mapValues[ED2: ClassTag](f: Edge[ED] => ED2): EdgeRDDImpl[ED2, VD] = mapEdgePartitions((pid, part) => part.map(f)) - override def reverse: EdgeRDD[ED, VD] = mapEdgePartitions((pid, part) => part.reverse) + override def reverse: EdgeRDDImpl[ED, VD] = mapEdgePartitions((pid, part) => part.reverse) - override def filter( + def filter( --- End diff -- why remove the override modifier? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Drop VD type parameter from EdgeRDD
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3303#issuecomment-63266716 [Test build #23463 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23463/consoleFull) for PR 3303 at commit [`fafeb51`](https://github.com/apache/spark/commit/fafeb51eccf87a39b2ede02a427b039a264ba68d). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Drop VD type parameter from EdgeRDD
GitHub user ankurdave opened a pull request: https://github.com/apache/spark/pull/3303 Drop VD type parameter from EdgeRDD You can merge this pull request into a Git repository by running: $ git pull https://github.com/ankurdave/spark edgerdd-drop-tparam Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/3303.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3303 commit fafeb51eccf87a39b2ede02a427b039a264ba68d Author: Ankur Dave Date: 2014-11-17T06:48:56Z Drop VD type parameter from EdgeRDD --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
