[GitHub] spark pull request: Fix org.scala-lang: * inconsistent versions de...
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/465 Fix org.scala-lang: * inconsistent versions dependency for maven You can merge this pull request into a Git repository by running: $ git pull https://github.com/witgo/spark SPARK-1325 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/465.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #465 commit 42238b6292008d24c96e07f26083b2349f8dd48e Author: witgo Date: 2014-04-21T14:54:21Z Fix org.scala-lang: * inconsistent versions for maven commit b434ec083178aef398ce9c2df431652ac7f28d08 Author: witgo Date: 2014-04-21T15:31:31Z remove exclusion scalap --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Fix org.scala-lang: * inconsistent versions de...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/465#issuecomment-40945647 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Fix org.scala-lang: * inconsistent versions de...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/465#issuecomment-40956505 Is a lot of the difference in this patch just due to whitespace? it looks like a lot of change that isn't related to the PR. I am having a hard time parsing the real change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Fix org.scala-lang: * inconsistent versions de...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/465#discussion_r11816771
--- Diff: pom.xml ---
@@ -440,6 +431,16 @@
${scala.version}
+org.scala-lang
+scala-actors
+${scala.version}
+
+
+org.scala-lang
+scalap
--- End diff --
Yeah I see what you mean, that this could also be resolved by just
depending on scalap explicitly. The product doesn't need scalap directly, I
think, so that feels a bit wrong. On the other hand, the workaround of having
to track exclusions to get the versions right seems ugly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix org.scala-lang: * inconsistent versions de...
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/465#issuecomment-40957374 @srowen Try appending `?w=1` to the github URL to see the diff without whitespace differences. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Fix org.scala-lang: * inconsistent versions de...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/465#issuecomment-40957655 @markhamstra Ah, what magic! Yes it's almost all whitespace changes. I think the whitespace should be left unchanged. The change is really just the ones to `pom.xml` and `core/pom.xml`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Fix org.scala-lang: * inconsistent versions de...
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/465#issuecomment-41006929 @srowen I'm sorry, I submitted a modified on the sql/catalyst/pom.xml,sql/hive/pom.xml,sql/core/pom.xml (Four spaces formatted into two spaces). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Fix org.scala-lang: * inconsistent versions de...
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/465 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
