[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-103153352 @jegonzal cleaning house a bit -- this is the oldest oustanding PR. Are you proceeding with it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user jegonzal closed the pull request at: https://github.com/apache/spark/pull/1228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user jegonzal commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-103186580 I think we have covered most of this code in later tests (PR #1217) and the remaining tests need to be substantially updated which I can do in a later PR. I am going to go ahead and close this one. Sorry about the delay. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-66351203 [Test build #24257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24257/consoleFull) for PR 1228 at commit [`8498483`](https://github.com/apache/spark/commit/849848311f4b781a3e62345aeb83a8f8f0837c03). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-66364174 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24257/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-66364167 [Test build #24257 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24257/consoleFull) for PR 1228 at commit [`8498483`](https://github.com/apache/spark/commit/849848311f4b781a3e62345aeb83a8f8f0837c03). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class PageRankSuite extends FunSuite with LocalSparkContext with Matchers ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user jegonzal commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-63597173 @ankurdave and @rxin can we merge this now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-62220208 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-62221168 [Test build #23072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23072/consoleFull) for PR 1228 at commit [`8498483`](https://github.com/apache/spark/commit/849848311f4b781a3e62345aeb83a8f8f0837c03). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-62230084 [Test build #23072 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23072/consoleFull) for PR 1228 at commit [`8498483`](https://github.com/apache/spark/commit/849848311f4b781a3e62345aeb83a8f8f0837c03). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class PageRankSuite extends FunSuite with LocalSparkContext with Matchers ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-62230090 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23072/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user jegonzal commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-61029490 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user jegonzal commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-61029482 This should now be addressed in the latest master and does not depend on PR #1217 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-54694643 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user jegonzal commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-53776044 Yes. This is an extension of the unit tests to catch a class of bugs addressed in PR #1217 (which has not been merged). I believe @ankurdave was working on a merge of these two pull requests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-53622677 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-53629811 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19317/consoleFull) for PR 1228 at commit [`487c968`](https://github.com/apache/spark/commit/487c96867cb72ac583ebcc598abff8fbb454dd02). * This patch **fails** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-53631432 @jegonzal seems like these GraphX tests actually fail -- any ideas what's going on? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-53515213 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-47199424 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-47199418 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user jegonzal commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-47200276 @ankurdave thanks for pointing out this bug! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-47202811 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16151/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Improved GraphX PageRank Test Coverage
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1228#issuecomment-47202809 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
