[GitHub] spark pull request: Rectify gereneric parameter names between Spar...
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2637#issuecomment-57973031 Thanks @nkronenfeld and @srowen. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Rectify gereneric parameter names between Spar...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2637 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Rectify gereneric parameter names between Spar...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/2637#issuecomment-57792726 +1, makes more sense for sure. Open a JIRA for this as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Rectify gereneric parameter names between Spar...
GitHub user nkronenfeld opened a pull request: https://github.com/apache/spark/pull/2637 Rectify gereneric parameter names between SparkContext and AccumulablePa... AccumulableParam gave its generic parameters as 'R, T', whereas SparkContext labeled them 'T, R'. Trivial, but really confusing. I resolved this in favor of AccumulableParam, because it seemed to have some logic for its names. I also extended this minimal, but at least present, justification into the SparkContext comments. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nkronenfeld/spark-1 accumulators Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/2637.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2637 commit 98d6b74a20cb39d7b3bc8a6336b5c15ca4e7197a Author: Nathan Kronenfeld nkronenf...@oculusinfo.com Date: 2014-10-02T22:06:18Z Rectify gereneric parameter names between SparkContext and AccumulableParam --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Rectify gereneric parameter names between Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2637#issuecomment-57718455 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21225/consoleFull) for PR 2637 at commit [`98d6b74`](https://github.com/apache/spark/commit/98d6b74a20cb39d7b3bc8a6336b5c15ca4e7197a). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Rectify gereneric parameter names between Spar...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2637#issuecomment-57725467 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21225/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Rectify gereneric parameter names between Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2637#issuecomment-57725454 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21225/consoleFull) for PR 2637 at commit [`98d6b74`](https://github.com/apache/spark/commit/98d6b74a20cb39d7b3bc8a6336b5c15ca4e7197a). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
