[GitHub] spark pull request: Remove compile-scoped junit dependency.
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/794 Remove compile-scoped junit dependency. This avoids having junit classes showing up in the assembly jar. I verified that only test classes in the jtransforms package use junit. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vanzin/spark junit-dep-exclusion Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/794.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #794 commit f9a9507f2835235e7498346c8c6e621cd05371a1 Author: Marcelo Vanzin Date: 2014-05-15T18:35:29Z Remove compile-scoped junit dependency. This avoids having junit classes showing up in the assembly jar. I verified that only test classes in the jtransforms package use junit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove compile-scoped junit dependency.
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/794#issuecomment-43253650 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove compile-scoped junit dependency.
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/794#issuecomment-43280537 No, but will take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove compile-scoped junit dependency.
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/794#issuecomment-43280215 @vanzin Did you check the sbt side? Try `sbt/sbt assembly` and see whether we have junit classes inside? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove compile-scoped junit dependency.
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/794#issuecomment-43351634 Yeah, that pretty much has the same code. If it goes in I can close this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove compile-scoped junit dependency.
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/794#issuecomment-43288330 Related work #713 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove compile-scoped junit dependency.
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/794#issuecomment-45162685 LGTM - @vanzin mind bringing this up to date? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove compile-scoped junit dependency.
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/794 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove compile-scoped junit dependency.
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/794#issuecomment-45268270 Thanks I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
