[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user hsaputra commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39911243 Thx! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39903603 ok i've merged this. thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39903504 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13908/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39903503 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39899226 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39899235 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39899041 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user hsaputra commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39851403 Seems like Jenkins had build error related to some PySpark file parsing. Can we try it again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39820119 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39820120 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13882/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user hsaputra commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39819023 @srowen there has been PRs to remove unnecessary semicolons and imports before and I believe we had remove most of them. Probably the best way to have some kind of check executed by Jenkins in addition to style check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39818376 It might be worth it. But be careful sometimes IDE gives you false signals. Also for the imports to conform to Spark's coding standard, we need @aarondav's import organizer plugin for IntelliJ. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39818305 Meta question - all of the unused imports can be zapped in one go with an IDE and semicolons too. Is that worth one big PR here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39817788 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39817794 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/358#issuecomment-39817779 bothers me too. will merge once jenkins is happy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Remove extra semicolon in import statement and...
GitHub user hsaputra opened a pull request: https://github.com/apache/spark/pull/358 Remove extra semicolon in import statement and unused import in ApplicationMaster Small nit cleanup to remove extra semicolon and unused import in Yarn's stable ApplicationMaster (it bothers me every time I saw it) You can merge this pull request into a Git repository by running: $ git pull https://github.com/hsaputra/spark nitcleanup_removesemicolon_import_applicationmaster Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/358.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #358 commit bffb685c56b69c8919d4df7fe43edcf2ddd07677 Author: Henry Saputra Date: 2014-04-08T06:58:09Z Remove extra semicolon in import statement and unused import in ApplicationMaster.scala --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
