[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-15 Thread tgravescs
Github user tgravescs commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14935222
  
--- Diff: 
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala 
---
@@ -82,6 +84,9 @@ class ExecutorLauncher(args: ApplicationMasterArguments, 
conf: Configuration, sp
   case x: DisassociatedEvent =
 logInfo(sDriver terminated or disconnected! Shutting down. $x)
 driverClosed = true
+  case x: AddWebUIFilter =
--- End diff --

Can you make the same changes for yarn alpha mode also please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-15 Thread tgravescs
Github user tgravescs commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-49036292
  
@witgo this looks good could you also add support for setting it in yarn 
alpha mode, sorry I missed that in earlier reviews.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-15 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-49044799
  
QA tests have started for PR 1112. This patch merges cleanly. brView 
progress: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16680/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-15 Thread witgo
Github user witgo commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-49045150
  
@tgravescs  The code has been submitted. Because I don't have the hadoop 
0.23.x cluster, the code no strict test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-15 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-49047222
  
QA tests have started for PR 1112. This patch merges cleanly. brView 
progress: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16681/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-15 Thread tgravescs
Github user tgravescs commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-49054435
  
Thanks, I'll test out the 0.23 code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-15 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-49059065
  
QA results for PR 1112:br- This patch PASSES unit tests.br- This patch 
merges cleanlybr- This patch adds the following public classes 
(experimental):brcase class AddWebUIFilter(filterName:String, filterParams: 
String, proxyBase :String)brbrFor more information see test 
ouptut:brhttps://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16680/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-15 Thread tgravescs
Github user tgravescs commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-49061972
  
Jenkins, test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-15 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-49062792
  
QA tests have started for PR 1112. This patch merges cleanly. brView 
progress: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16687/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-15 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-49075062
  
QA results for PR 1112:br- This patch PASSES unit tests.br- This patch 
merges cleanlybr- This patch adds the following public classes 
(experimental):brcase class AddWebUIFilter(filterName:String, filterParams: 
String, proxyBase :String)brbrFor more information see test 
ouptut:brhttps://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16687/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-15 Thread tgravescs
Github user tgravescs commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-49076295
  
Looks good. Thanks @witgo 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/1112


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-14 Thread tgravescs
Github user tgravescs commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14914235
  
--- Diff: 
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala 
---
@@ -99,6 +104,8 @@ class ExecutorLauncher(args: ApplicationMasterArguments, 
conf: Configuration, sp
 registerApplicationMaster()
 
 waitForSparkMaster()
+// setup AmIpFilter for the SparkUI - do this before we start the UI
--- End diff --

remove the comment.  The UI is already running at this point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-14 Thread tgravescs
Github user tgravescs commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-48981947
  
I just tried this out on a secure yarn cluster but I'm getting an error:

java.io.IOException: java.net.URISyntaxException: Expected authority at 
index 7: http://

I'll try to take a closer look tomorrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-14 Thread tgravescs
Github user tgravescs commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-48982138
  
Sorry I might have been wrong here think it didn't pick up the changes when 
I built.  Let me do clean build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-14 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-48982244
  
QA tests have started for PR 1112. This patch merges cleanly. brView 
progress: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16647/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-14 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-48986871
  
QA results for PR 1112:br- This patch PASSES unit tests.br- This patch 
merges cleanlybr- This patch adds the following public classes 
(experimental):brcase class AddWebUIFilter(filterName:String, filterParams: 
String, proxyBase :String)brbrFor more information see test 
ouptut:brhttps://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16647/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-10 Thread witgo
Github user witgo commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14775753
  
--- Diff: 
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala 
---
@@ -142,9 +149,20 @@ class ExecutorLauncher(args: 
ApplicationMasterArguments, conf: Configuration, sp
   }
 
   private def registerApplicationMaster(): 
RegisterApplicationMasterResponse = {
-logInfo(Registering the ApplicationMaster)
-// TODO: Find out client's Spark UI address and fill in here?
-amClient.registerApplicationMaster(Utils.localHostName(), 0, )
+val appUIAddress = sparkConf.get(spark.driver.appUIAddress, )
+logInfo(sRegistering the ApplicationMaster with appUIAddress: 
$appUIAddress)
+amClient.registerApplicationMaster(Utils.localHostName(), 0, 
appUIAddress)
+  }
+
+  // add the yarn amIpFilter that Yarn requires for properly securing the 
UI
+  private def addAmIpFilter() {
--- End diff --

There are differences in the code.Should not be combined.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-10 Thread witgo
Github user witgo commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14776233
  
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -135,7 +135,16 @@ private[spark] object UIUtils extends Logging {
   }
 
   // Yarn has to go through a proxy so the base uri is provided and has to 
be on all links
-  val uiRoot : String = 
Option(System.getenv(APPLICATION_WEB_PROXY_BASE)).getOrElse()
+  def uiRoot: String = {
+if (System.getenv(APPLICATION_WEB_PROXY_BASE) != null) {
--- End diff --

 `addAmIpFilter ` is invoked in  yarn Container.  The code in 
[Client.scala](https://github.com/apache/spark/blob/master/yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/Client.scala)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-48280910
  
 Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-48280916
  
Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-48284602
  
Merged build finished. All automated tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-48284603
  
All automated tests passed.
Refer to this link for build results: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16397/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-26 Thread witgo
Github user witgo closed the pull request at:

https://github.com/apache/spark/pull/1112


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-26 Thread witgo
GitHub user witgo reopened a pull request:

https://github.com/apache/spark/pull/1112

SPARK-1291: Link the spark UI to RM ui in yarn-client mode



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/witgo/spark SPARK-1291

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/1112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1112


commit fe01513a5b8f57410962a3b2a3427dab7c634868
Author: witgo wi...@qq.com
Date:   2014-06-18T09:01:53Z

Link the spark UI to RM ui in yarn-client mode

commit 9805b8dcebd2b609c5997db34193037f34daaf33
Author: witgo wi...@qq.com
Date:   2014-06-23T15:22:28Z

Merge branch 'master' of https://github.com/apache/spark into SPARK-1291

commit b11061c57140280f56ec4d6c5a155f40b0cb2888
Author: witgo wi...@qq.com
Date:   2014-06-23T16:25:36Z

review commit

commit b3d978195f823c7990dd30ca026bbdb0c743eaeb
Author: witgo wi...@qq.com
Date:   2014-06-23T16:27:33Z

review commit

commit 346af2ebd0211e9d1fdbc4c5e47fc5b5c291f055
Author: witgo wi...@qq.com
Date:   2014-06-24T02:38:00Z

Merge branch 'master' of https://github.com/apache/spark into SPARK-1291

commit 5630d449695d6c742101217b7974b5cf6bf1aa31
Author: witgo wi...@qq.com
Date:   2014-06-24T03:11:48Z

Add comments to addWebUIFilter

commit a49c8e7072ad6e4595ff9a1e2ba11bdbeeeb735b
Author: witgo wi...@qq.com
Date:   2014-06-25T02:51:00Z

Merge branch 'master' of https://github.com/apache/spark into SPARK-1291

commit b9a623ab7f501145181f5d592d024c22d5749677
Author: witgo wi...@qq.com
Date:   2014-06-27T01:38:37Z

Merge branch 'master' of https://github.com/apache/spark into SPARK-1291

commit f8f0fc952dd931a115e5cce8186f703dba2151e4
Author: witgo wi...@qq.com
Date:   2014-06-27T02:13:33Z

review commit




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47301721
  
Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47301713
  
 Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47303576
  
Merged build finished. All automated tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47303577
  
All automated tests passed.
Refer to this link for build results: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16184/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-26 Thread rahulsinghaliitd
Github user rahulsinghaliitd commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47306598
  
Tested successfully that the UI URL is correctly displayed in RM UI and 
that the spark UI is correctly rendered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-26 Thread rahulsinghaliitd
Github user rahulsinghaliitd commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14279134
  
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -135,7 +135,16 @@ private[spark] object UIUtils extends Logging {
   }
 
   // Yarn has to go through a proxy so the base uri is provided and has to 
be on all links
-  val uiRoot : String = 
Option(System.getenv(APPLICATION_WEB_PROXY_BASE)).getOrElse()
+  def uiRoot: String = {
+if (System.getenv(APPLICATION_WEB_PROXY_BASE) != null) {
--- End diff --

Can we set the spark.ui.proxyBase property in ApplicationMaster.scala's 
addAmIpFilter() so that
1. The code is more consistent
2. The if-else case here is reduced


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-26 Thread rahulsinghaliitd
Github user rahulsinghaliitd commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14279155
  
--- Diff: 
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala 
---
@@ -142,9 +149,20 @@ class ExecutorLauncher(args: 
ApplicationMasterArguments, conf: Configuration, sp
   }
 
   private def registerApplicationMaster(): 
RegisterApplicationMasterResponse = {
-logInfo(Registering the ApplicationMaster)
-// TODO: Find out client's Spark UI address and fill in here?
-amClient.registerApplicationMaster(Utils.localHostName(), 0, )
+val appUIAddress = sparkConf.get(spark.driver.appUIAddress, )
+logInfo(sRegistering the ApplicationMaster with appUIAddress: 
$appUIAddress)
+amClient.registerApplicationMaster(Utils.localHostName(), 0, 
appUIAddress)
+  }
+
+  // add the yarn amIpFilter that Yarn requires for properly securing the 
UI
+  private def addAmIpFilter() {
--- End diff --

Can the functions addAmIpFilter() in ApplicationMaster.scala and 
ExecutorLauncher.scala be combined in say a new file YarnUtil.scala?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47055497
  
 Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47055506
  
Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47055992
  

Refer to this link for build results: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16099/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47055991
  
Merged build finished. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-24 Thread witgo
Github user witgo commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47056084
  
Jenkins, test this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47056247
  
 Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47056256
  
Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47058599
  
Merged build finished. All automated tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-47058606
  
All automated tests passed.
Refer to this link for build results: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16100/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread tgravescs
Github user tgravescs commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14077635
  
--- Diff: 
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala 
---
@@ -142,9 +149,19 @@ class ExecutorLauncher(args: 
ApplicationMasterArguments, conf: Configuration, sp
   }
 
   private def registerApplicationMaster(): 
RegisterApplicationMasterResponse = {
-logInfo(Registering the ApplicationMaster)
-// TODO: Find out client's Spark UI address and fill in here?
-amClient.registerApplicationMaster(Utils.localHostName(), 0, )
+val appUIAddress = 
sparkConf.getOption(spark.driver.appUIAddress).getOrElse()
--- End diff --

You can just use sparkConf.get(spark.driver.appUIAddress, )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread tgravescs
Github user tgravescs commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14077685
  
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -135,7 +135,16 @@ private[spark] object UIUtils extends Logging {
   }
 
   // Yarn has to go through a proxy so the base uri is provided and has to 
be on all links
-  val uiRoot : String = 
Option(System.getenv(APPLICATION_WEB_PROXY_BASE)).getOrElse()
+  def uiRoot: String = {
+if (System.getenv(APPLICATION_WEB_PROXY_BASE) != null) {
--- End diff --

can you use use 
Option(System.getenv(APPLICATION_WEB_PROXY_BASE)).getOrElse(System.getProperty(spark.ui.proxyBase)).getOrElse()
 for this instead of  != null checks.

Also we should be using the SparkConf whenever possible and not system 
properties unless there is explicit reason


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread tgravescs
Github user tgravescs commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14077679
  
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -139,7 +139,8 @@ private[spark] object JettyUtils extends Logging {
 
   /** Add filters, if any, to the given list of ServletContextHandlers */
   def addFilters(handlers: Seq[ServletContextHandler], conf: SparkConf) {
-val filters: Array[String] = conf.get(spark.ui.filters, 
).split(',').map(_.trim())
+val filters: Array[String] = sys.props.get(spark.ui.filters).
--- End diff --

why was this changed to sys.props.get from the sparkConf?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread witgo
Github user witgo commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14077844
  
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -135,7 +135,16 @@ private[spark] object UIUtils extends Logging {
   }
 
   // Yarn has to go through a proxy so the base uri is provided and has to 
be on all links
-  val uiRoot : String = 
Option(System.getenv(APPLICATION_WEB_PROXY_BASE)).getOrElse()
+  def uiRoot: String = {
+if (System.getenv(APPLICATION_WEB_PROXY_BASE) != null) {
--- End diff --

`Option(System.getenv(APPLICATION_WEB_PROXY_BASE))` will create a new 
object


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread tgravescs
Github user tgravescs commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14077908
  
--- Diff: 
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala 
---
@@ -142,9 +149,19 @@ class ExecutorLauncher(args: 
ApplicationMasterArguments, conf: Configuration, sp
   }
 
   private def registerApplicationMaster(): 
RegisterApplicationMasterResponse = {
-logInfo(Registering the ApplicationMaster)
-// TODO: Find out client's Spark UI address and fill in here?
-amClient.registerApplicationMaster(Utils.localHostName(), 0, )
+val appUIAddress = 
sparkConf.getOption(spark.driver.appUIAddress).getOrElse()
+logInfo(sRegistering the ApplicationMaster with appUIAddress: 
$appUIAddress)
+amClient.registerApplicationMaster(Utils.localHostName(), 0, 
appUIAddress)
+  }
+
+  // add the yarn amIpFilter that Yarn requires for properly securing the 
UI
+  private def addAmIpFilter() {
+val proxy = WebAppUtils.getProxyHostAndPort(conf)
+val parts : Array[String] = proxy.split(:)
+val proxyBase 
=System.getenv(ApplicationConstants.APPLICATION_WEB_PROXY_BASE_ENV)
--- End diff --

add space after =


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread witgo
Github user witgo commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14077980
  
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -139,7 +139,8 @@ private[spark] object JettyUtils extends Logging {
 
   /** Add filters, if any, to the given list of ServletContextHandlers */
   def addFilters(handlers: Seq[ServletContextHandler], conf: SparkConf) {
-val filters: Array[String] = conf.get(spark.ui.filters, 
).split(',').map(_.trim())
+val filters: Array[String] = sys.props.get(spark.ui.filters).
--- End diff --

  `System.setProperty(spark.ui.filters, amFilter)` in  `addAmIpFilter` 
method is called after the sparkConf is initialized
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread tgravescs
Github user tgravescs commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14078350
  
--- Diff: 
yarn/common/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala
 ---
@@ -116,4 +118,15 @@ private[spark] class YarnClientSchedulerBackend(
 logInfo(Stopped)
   }
 
+  override def addWebUIFilter(filter: String, proxyBase: String) {
+if (filter != null  filter.nonEmpty  proxyBase != null  
proxyBase.nonEmpty) {
+  logInfo(sAdd WebUI Filter. $filter)
+  val amFilter = 
org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter
+  System.setProperty(spark.ui.filters, amFilter)
+  System.setProperty(sspark.$amFilter.params, filter)
+  System.setProperty(spark.ui.proxyBase, proxyBase)
+  JettyUtils.addFilters(sc.ui.handlers, conf)
--- End diff --

you should be using getHandlers function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread tgravescs
Github user tgravescs commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14078643
  
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -43,7 +43,7 @@ private[spark] abstract class WebUI(
   extends Logging {
 
   protected val tabs = ArrayBuffer[WebUITab]()
-  protected val handlers = ArrayBuffer[ServletContextHandler]()
+  protected[spark] val handlers = ArrayBuffer[ServletContextHandler]()
--- End diff --

don't expose this to everyone, just use the get function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread tgravescs
Github user tgravescs commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14079223
  
--- Diff: 
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala 
---
@@ -142,9 +149,19 @@ class ExecutorLauncher(args: 
ApplicationMasterArguments, conf: Configuration, sp
   }
 
   private def registerApplicationMaster(): 
RegisterApplicationMasterResponse = {
-logInfo(Registering the ApplicationMaster)
-// TODO: Find out client's Spark UI address and fill in here?
-amClient.registerApplicationMaster(Utils.localHostName(), 0, )
+val appUIAddress = 
sparkConf.getOption(spark.driver.appUIAddress).getOrElse()
+logInfo(sRegistering the ApplicationMaster with appUIAddress: 
$appUIAddress)
+amClient.registerApplicationMaster(Utils.localHostName(), 0, 
appUIAddress)
+  }
+
+  // add the yarn amIpFilter that Yarn requires for properly securing the 
UI
+  private def addAmIpFilter() {
+val proxy = WebAppUtils.getProxyHostAndPort(conf)
+val parts : Array[String] = proxy.split(:)
+val proxyBase 
=System.getenv(ApplicationConstants.APPLICATION_WEB_PROXY_BASE_ENV)
+val uriBase = http://; + proxy + proxyBase
+val amFilter = PROXY_HOST= + parts(0) + , + PROXY_URI_BASE= + 
uriBase
+actor ! AddWebUIFilter(amFilter, proxyBase)
--- End diff --

any particular reason we are sending ourselves a message and not sending 
directly to the driver?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread tgravescs
Github user tgravescs commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14079754
  
--- Diff: 
yarn/common/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala
 ---
@@ -116,4 +118,15 @@ private[spark] class YarnClientSchedulerBackend(
 logInfo(Stopped)
   }
 
+  override def addWebUIFilter(filter: String, proxyBase: String) {
+if (filter != null  filter.nonEmpty  proxyBase != null  
proxyBase.nonEmpty) {
+  logInfo(sAdd WebUI Filter. $filter)
+  val amFilter = 
org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter
+  System.setProperty(spark.ui.filters, amFilter)
+  System.setProperty(sspark.$amFilter.params, filter)
--- End diff --

This is a bit odd to me.  The filter parameter to this function is actually 
the paramters and not the filter.  We should just be passing all of them as 
parameters (filterName, filterparams, proxyBase)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread tgravescs
Github user tgravescs commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14080191
  
--- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
@@ -244,6 +247,9 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, actorSystem: A
 throw new SparkException(Error notifying standalone scheduler's 
driver actor, e)
 }
   }
+
+  def addWebUIFilter(filter: String, proxyBase: String) {}
--- End diff --

please add scaladoc and explain parameters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread tgravescs
Github user tgravescs commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14080360
  
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -139,7 +139,8 @@ private[spark] object JettyUtils extends Logging {
 
   /** Add filters, if any, to the given list of ServletContextHandlers */
   def addFilters(handlers: Seq[ServletContextHandler], conf: SparkConf) {
-val filters: Array[String] = conf.get(spark.ui.filters, 
).split(',').map(_.trim())
+val filters: Array[String] = sys.props.get(spark.ui.filters).
--- End diff --

Unless I'm missing something, addAmIpFilter isn't setting these configs. 
addWebUIFilter is and its passing a sparkConf into JettyUtils.addFilters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread witgo
Github user witgo commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14080567
  
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -139,7 +139,8 @@ private[spark] object JettyUtils extends Logging {
 
   /** Add filters, if any, to the given list of ServletContextHandlers */
   def addFilters(handlers: Seq[ServletContextHandler], conf: SparkConf) {
-val filters: Array[String] = conf.get(spark.ui.filters, 
).split(',').map(_.trim())
+val filters: Array[String] = sys.props.get(spark.ui.filters).
--- End diff --

You're right,I made a mistake.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread witgo
Github user witgo commented on a diff in the pull request:

https://github.com/apache/spark/pull/1112#discussion_r14081769
  
--- Diff: 
yarn/common/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala
 ---
@@ -116,4 +118,15 @@ private[spark] class YarnClientSchedulerBackend(
 logInfo(Stopped)
   }
 
+  override def addWebUIFilter(filter: String, proxyBase: String) {
+if (filter != null  filter.nonEmpty  proxyBase != null  
proxyBase.nonEmpty) {
+  logInfo(sAdd WebUI Filter. $filter)
+  val amFilter = 
org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter
+  System.setProperty(spark.ui.filters, amFilter)
+  System.setProperty(sspark.$amFilter.params, filter)
--- End diff --

This is a good idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-46868364
  
 Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-46868383
  
Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-46873730
  
All automated tests passed.
Refer to this link for build results: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16030/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-46927916
  
 Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-46927924
  
Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-46930106
  

Refer to this link for build results: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16047/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-46930104
  
Merged build finished. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-18 Thread witgo
GitHub user witgo opened a pull request:

https://github.com/apache/spark/pull/1112

SPARK-1291: Link the spark UI to RM ui in yarn-client mode



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/witgo/spark SPARK-1291

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/1112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1112


commit fe01513a5b8f57410962a3b2a3427dab7c634868
Author: witgo wi...@qq.com
Date:   2014-06-18T09:01:53Z

Link the spark UI to RM ui in yarn-client mode




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-46411809
  
 Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-46411829
  
Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-46415412
  
Merged build finished. All automated tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1291: Link the spark UI to RM ui in yarn...

2014-06-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1112#issuecomment-46415415
  
All automated tests passed.
Refer to this link for build results: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15869/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---