[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user hsaputra commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-40260830 Cool! Thanks @tgravescs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-40216406 I pulled this into branch-1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-40178755 Merging this into master. @tgravescs, @pwendell if this is relevant to 1.0, please do merge into that branch too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39921610 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13916/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39921609 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39919863 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39919871 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39919770 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39894714 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13901/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39894712 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39888097 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39888084 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39885534 Oh its because jenkins is picking up an ip instead of when I run it locally it picks up the host. Ok, let me fix that test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39885229 It seems that URI requires a scheme in the parameter, so `new URI(appUIHostPort)` fails that check (which is part of the suite currently in github). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39884822 Is jenkins not picking up the latest changes? The test it says is failing works fine for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39882021 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39882023 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13895/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/spark/pull/344#discussion_r11401846
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -112,7 +112,12 @@ private[spark] class SparkUI(
logInfo("Stopped Spark Web UI at %s".format(appUIAddress))
}
- private[spark] def appUIAddress = "http://"; + publicHost + ":" +
boundPort
+ /**
+ * Return the application UI host:port. This does not include the scheme
(http://).
+ */
+ private[spark] def appUIHostPort = publicHost + ":" + boundPort
+
+ private[spark] def appUIAddress = s"http://appUIHostPort";
--- End diff --
Ah, Scala String interpolation. Missing the $ character. Thanks @andrewor14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39877635 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39877613 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/344#discussion_r11401257
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -112,7 +112,12 @@ private[spark] class SparkUI(
logInfo("Stopped Spark Web UI at %s".format(appUIAddress))
}
- private[spark] def appUIAddress = "http://"; + publicHost + ":" +
boundPort
+ /**
+ * Return the application UI host:port. This does not include the scheme
(http://).
+ */
+ private[spark] def appUIHostPort = publicHost + ":" + boundPort
+
+ private[spark] def appUIAddress = s"http://appUIHostPort";
--- End diff --
Yes I did. thanks. I added another assert in the test for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/344#discussion_r11397718
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -112,7 +112,12 @@ private[spark] class SparkUI(
logInfo("Stopped Spark Web UI at %s".format(appUIAddress))
}
- private[spark] def appUIAddress = "http://"; + publicHost + ":" +
boundPort
+ /**
+ * Return the application UI host:port. This does not include the scheme
(http://).
+ */
+ private[spark] def appUIHostPort = publicHost + ":" + boundPort
+
+ private[spark] def appUIAddress = s"http://appUIHostPort";
--- End diff --
I think you missed the `$` in front of appUIHostPort?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/spark/pull/344#discussion_r11397585
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -112,7 +112,12 @@ private[spark] class SparkUI(
logInfo("Stopped Spark Web UI at %s".format(appUIAddress))
}
- private[spark] def appUIAddress = "http://"; + publicHost + ":" +
boundPort
+ /**
+ * Return the application UI host:port. This does not include the scheme
(http://).
+ */
+ private[spark] def appUIHostPort = publicHost + ":" + boundPort
+
+ private[spark] def appUIAddress = s"http://appUIHostPort";
--- End diff --
Sorry if this is obvious to others but what is the purpose of the "s"
character prefix for the appUIAddress variable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39855171 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13892/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39855170 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39850477 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39850494 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/344#discussion_r11390149
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -112,6 +112,11 @@ private[spark] class SparkUI(
logInfo("Stopped Spark Web UI at %s".format(appUIAddress))
}
+ /**
+ * Return the application UI host:port. This does not include the scheme
(http://).
+ */
+ private[spark] def appUIHostPort = publicHost + ":" + boundPort
+
private[spark] def appUIAddress = "http://"; + publicHost + ":" +
boundPort
--- End diff --
thanks for catching that. I had meant to do that, updating.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39790128 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39790131 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13857/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39786990 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39786991 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13859/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/344#discussion_r11367039
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -112,6 +112,11 @@ private[spark] class SparkUI(
logInfo("Stopped Spark Web UI at %s".format(appUIAddress))
}
+ /**
+ * Return the application UI host:port. This does not include the scheme
(http://).
+ */
+ private[spark] def appUIHostPort = publicHost + ":" + boundPort
+
private[spark] def appUIAddress = "http://"; + publicHost + ":" +
boundPort
--- End diff --
Pedantic - but this one could just use `appUIHostPort` - tiny thing, don't
let it block you from merging this.
```
private[spark] def appUIAddress = s"http://$appUIHostPort";
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39786047 Thanks for the review, updated it to remove extra newline and simplify the assert. (and I accidentally hit the close button instead of the comment button). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39785928 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39785943 Thanks, --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39785918 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
GitHub user tgravescs reopened a pull request: https://github.com/apache/spark/pull/344 SPARK-1417: Spark on Yarn - spark UI link from resourcemanager is broken You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgravescs/spark SPARK-1417 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/344.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #344 commit 2a6b1b72f26c860a16fb3a6e58c8f1a09477117f Author: Thomas Graves Date: 2014-04-07T14:01:30Z SPARK-1417: Spark on Yarn - spark UI link from resourcemanager is broken commit 061420829a89916da87437e114b1e20648178c63 Author: Thomas Graves Date: 2014-04-07T18:54:24Z Fix test commit 658a8ec9249975c36a25f3e0666a7eaf880f73af Author: Thomas Graves Date: 2014-04-07T21:21:32Z Add a appUIHostPort routine commit 0803ec22a875f7714cd7af4df0933600ee63cef2 Author: Thomas Graves Date: 2014-04-07T21:26:08Z Review comment updates - remove extra newline, simplify assert in test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user tgravescs closed the pull request at: https://github.com/apache/spark/pull/344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/344#discussion_r11366365
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -112,8 +112,14 @@ private[spark] class SparkUI(
logInfo("Stopped Spark Web UI at %s".format(appUIAddress))
}
+ /**
+ * Return the application UI host:port. This does not include the scheme
(http://).
+ */
+ private[spark] def appUIHostPort = publicHost + ":" + boundPort
+
private[spark] def appUIAddress = "http://"; + publicHost + ":" +
boundPort
+
--- End diff --
nit: new line here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/344#discussion_r11366350
--- Diff: core/src/test/scala/org/apache/spark/SparkUISuite.scala ---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark
+
+import java.net.URI
+
+import org.scalatest.FunSuite
+
+class SparkUISuite extends FunSuite with SharedSparkContext {
+
+ test("verify appUIHostPort doesn't contain scheme") {
+val appUIUri = new URI(sc.ui.appUIHostPort)
+assert(appUIUri.getScheme().startsWith("http") == false)
--- End diff --
nit: `assert(!appUIUri.getScheme().startsWith("http"))` (similarly in L33)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39785420 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39785401 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/344#discussion_r11363051
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -112,7 +112,10 @@ private[spark] class SparkUI(
logInfo("Stopped Spark Web UI at %s".format(appUIAddress))
}
- private[spark] def appUIAddress = "http://"; + publicHost + ":" +
boundPort
+ /**
+ * Return the application UI address. This does not include the scheme
(http://).
+ */
+ private[spark] def appUIAddress = publicHost + ":" + boundPort
--- End diff --
I'm fine with that. That is actually what I originally had back when I put
in the support for linking spark ui to yarn ui, but during the review we
decided to remove it since it was only used in one other spot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/344#discussion_r11361448
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -112,7 +112,10 @@ private[spark] class SparkUI(
logInfo("Stopped Spark Web UI at %s".format(appUIAddress))
}
- private[spark] def appUIAddress = "http://"; + publicHost + ":" +
boundPort
+ /**
+ * Return the application UI address. This does not include the scheme
(http://).
+ */
+ private[spark] def appUIAddress = publicHost + ":" + boundPort
--- End diff --
hm - rather than doing this what about having `appUIHostPort` in addition
to `appUIAddress`. Even though address is not an official term, I think people
downstream would expect it to have a scheme (ala
http://en.wikipedia.org/wiki/Uniform_resource_locator).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39773451 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39773455 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13851/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39769248 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39769232 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39738667 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13843/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39738666 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39733811 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/344#issuecomment-39733823 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1417: Spark on Yarn - spark UI link from...
GitHub user tgravescs opened a pull request: https://github.com/apache/spark/pull/344 SPARK-1417: Spark on Yarn - spark UI link from resourcemanager is broken You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgravescs/spark SPARK-1417 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/344.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #344 commit 2a6b1b72f26c860a16fb3a6e58c8f1a09477117f Author: Thomas Graves Date: 2014-04-07T14:01:30Z SPARK-1417: Spark on Yarn - spark UI link from resourcemanager is broken --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
