[GitHub] spark pull request: SPARK-1759

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/693


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: SPARK-1759

[pjopensource]

Github user pjopensource commented on the pull request:

https://github.com/apache/spark/pull/693#issuecomment-42626207
  
OK,I see. The sbt script in spark is just for building the Spark itself,not
for other project.Thanks very much.
I was confused by the quickstart doc
http://spark.apache.org/docs/latest/quick-start.html,it use the sbt/sbt to
build the simpleApp project. maybe we should revise the doc.


2014-05-08 22:14 GMT+08:00 Sean Owen :

> Yes, so if you are making your own separate project, even if it's
> Spark-based, you should be using the regular SBT and its sbt binary in
> your build, not this script that is for building Spark itself, IIUC. This
> would now require now setting SPARK_HOME, for example, when it seems a
> little funny to have to do so from the top-level of the project itself.
>
> —
> Reply to this email directly or view it on 
GitHub
> .
>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: SPARK-1759

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/693#issuecomment-42545954
  
I don't think it's intended that you use `sbt/sbt` for other projects. It's 
specific to Spark. Right? You can use the regular `sbt` app of course.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: SPARK-1759

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/693#issuecomment-42643489
  
Yes, maybe someone can double-check me, but I imagine it is meant to show 
using just `sbt`. There is no `sbt/` directory created in this sample to begin 
with, and the script doesn't seem set up to be used elsewhere for the reason 
you give. Maybe change your PR to instead suggest the doc change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: SPARK-1759

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/693#issuecomment-42527399
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: SPARK-1759

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/693#issuecomment-42554599
  
Yes, so if you are making your own separate project, even if it's 
Spark-based, you should be using the regular SBT and its `sbt` binary in your 
build, not this script that is for building Spark itself, IIUC. This would now 
require now setting `SPARK_HOME`, for example, when it seems a little funny to 
have to do so from the top-level of the project itself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: SPARK-1759

[pjopensource]

Github user pjopensource commented on the pull request:

https://github.com/apache/spark/pull/693#issuecomment-42527084
  
https://issues.apache.org/jira/browse/SPARK-1759


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: SPARK-1759

[pjopensource]

Github user pjopensource commented on the pull request:

https://github.com/apache/spark/pull/693#issuecomment-42554050
  
yes, it's specific to spark.


2014-05-08 20:52 GMT+08:00 Sean Owen :

> I don't think it's intended that you use sbt/sbt for other projects. It's
> specific to Spark. Right? You can use the regular sbt app of course.
>
> —
> Reply to this email directly or view it on 
GitHub
> .
>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: SPARK-1759

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/693#issuecomment-42910766
  
Do you mind closing this if it is no longer necessary? Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: SPARK-1759

[pjopensource]

GitHub user pjopensource opened a pull request:

https://github.com/apache/spark/pull/693

SPARK-1759



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pjopensource/spark branch-0.9

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/693.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #693


commit a017d2ee597473d483350b5a3d57713fae392522
Author: Jason Penn 
Date:   2014-05-08T08:48:09Z

modified:   sbt/sbt




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---