[GitHub] spark pull request: SPARK-1879. Increase MaxPermSize since some of...

2014-05-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/823


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1879. Increase MaxPermSize since some of...

2014-05-19 Thread tdas
Github user tdas commented on the pull request:

https://github.com/apache/spark/pull/823#issuecomment-43578188
  
Merging this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1879. Increase MaxPermSize since some of...

2014-05-19 Thread andrewor14
Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/823#issuecomment-43573627
  
Ah, I see. Looks like memory management is quite different in Java 8. The 
new Metaspace  is dynamically resized for this very reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1879. Increase MaxPermSize since some of...

2014-05-19 Thread vanzin
Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/823#issuecomment-43572594
  
@andrewor14 Yes Java 8 doesn't have a perm gen anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1879. Increase MaxPermSize since some of...

2014-05-19 Thread andrewor14
Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/823#issuecomment-43572532
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1879. Increase MaxPermSize since some of...

2014-05-19 Thread andrewor14
Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/823#issuecomment-43571957
  
I'm looking at the warning you posted on the JIRA
```
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option 
MaxPermSize=128m; support was removed in 8.0
```

Does that mean this fix only applies to Java 6 and 7?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1879. Increase MaxPermSize since some of...

2014-05-19 Thread vanzin
Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/823#issuecomment-43529752
  
LGTM. I ran into this while testing, so this is very welcome. :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1879. Increase MaxPermSize since some of...

2014-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/823#issuecomment-43476291
  
Merged build finished. All automated tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1879. Increase MaxPermSize since some of...

2014-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/823#issuecomment-43476292
  
All automated tests passed.
Refer to this link for build results: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15076/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1879. Increase MaxPermSize since some of...

2014-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/823#issuecomment-43473503
  
 Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1879. Increase MaxPermSize since some of...

2014-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/823#issuecomment-43473510
  
Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: SPARK-1879. Increase MaxPermSize since some of...

2014-05-19 Thread mateiz
GitHub user mateiz opened a pull request:

https://github.com/apache/spark/pull/823

SPARK-1879. Increase MaxPermSize since some of our builds have many classes

See https://issues.apache.org/jira/browse/SPARK-1879 -- builds with Hadoop2 
and Hive ran out of PermGen space in spark-shell, when those things added up 
with the Scala compiler.

Note that users can still override it by setting their own Java options 
with this change. Their options will come later in the command string than the 
-XX:MaxPermSize=128m.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mateiz/spark spark-1879

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/823.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #823


commit 6bc0ee8b898c4ea2cc4996594886d4f59907b345
Author: Matei Zaharia 
Date:   2014-05-19T07:31:44Z

Increase MaxPermSize to 128m since some of our builds have lots of classes

Note that users can still override it by setting their own Java options.
Their options will come later in the command string.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---