[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1137#issuecomment-47068276 Looks good. Merging in master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
GitHub user CodingCat opened a pull request: https://github.com/apache/spark/pull/1137 SPARK-2038: rename conf parameters in the saveAsHadoop functions with source-compatibility https://issues.apache.org/jira/browse/SPARK-2038 to differentiate with SparkConf object and at the same time keep the source level compatibility You can merge this pull request into a Git repository by running: $ git pull https://github.com/CodingCat/spark SPARK-2038 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/1137.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1137 commit d91288d6804db8feed210cfba01cb8f0f6780493 Author: CodingCat zhunans...@gmail.com Date: 2014-06-15T00:49:14Z rename conf parameters in the saveAsHadoop functions to distinguish with SparkConf commit 763975ff7b6cdea32ebd9f2770f28febd44b7174 Author: CodingCat zhunans...@gmail.com Date: 2014-06-15T00:56:58Z style fix commit 7ee5712e91861b902814f3e2d76a059e39e4d3c9 Author: CodingCat zhunans...@gmail.com Date: 2014-06-19T19:45:01Z to keep the source-compatibility --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1137#issuecomment-46606943 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1137#issuecomment-46606962 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1137#discussion_r13989526
--- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala
---
@@ -721,7 +721,9 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
outputFormatClass: Class[_ : NewOutputFormat[_, _]],
conf: Configuration = self.context.hadoopConfiguration)
{
-val job = new NewAPIHadoopJob(conf)
+// keep the source-compatibility and distinct with the SparkConf
--- End diff --
Might be a bit more clear to say:
```
// Rename this as hadoopConf internally to avoid shadowing (see SPARK-2038).
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1137#issuecomment-46611570 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1137#issuecomment-46611572 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15918/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1137#issuecomment-46618807 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1137#issuecomment-46618783 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/1137#issuecomment-46619142 revised the comments, and waiting for the Jenkins, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1137#issuecomment-46622950 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15926/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1137#issuecomment-46622949 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46408239 Just leaving a note that this pr has been reverted because changing the parameter name in Scala could make the function non-source-compatible anymore ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user ash211 commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46435921 Is there a place we're collecting a backlog of changes queued for the next API breaking release? On Jun 18, 2014 4:23 AM, Reynold Xin notificati...@github.com wrote: Just leaving a note that this pr has been reverted because changing the parameter name in Scala could make the function non-source-compatible anymore ... â Reply to this email directly or view it on GitHub https://github.com/apache/spark/pull/1087#issuecomment-46408239. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46477205 That's a very good idea. We should probably have a API-breaking label on JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user ash211 commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46499913 A proposed-api-break tag on JIRA sounds perfect. Every API-breaking release we can scan through those issues and choose to take the opportunity to break API or not. On Wed, Jun 18, 2014 at 2:49 PM, Reynold Xin notificati...@github.com wrote: That's a very good idea. We should probably have a API-breaking label on JIRA. â Reply to this email directly or view it on GitHub https://github.com/apache/spark/pull/1087#issuecomment-46477205. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46500185 Yup I added api-breaking label to the ticket. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46352144 LGTM - thanks for this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1087 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
GitHub user CodingCat opened a pull request: https://github.com/apache/spark/pull/1087 SPARK-2038: rename conf parameters in the saveAsHadoop functions to distinguish with SparkConf object https://issues.apache.org/jira/browse/SPARK-2038 You can merge this pull request into a Git repository by running: $ git pull https://github.com/CodingCat/spark SPARK-2038 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/1087.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1087 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46103470 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46103472 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46103486 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46103487 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15792/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46103551 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46103553 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46104198 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15794/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2038: rename conf parameters in the sa...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1087#issuecomment-46104196 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
