[GitHub] spark pull request: SPARK-2170: Fix for global name 'PIPE' is not ...
Github user gregakespret closed the pull request at: https://github.com/apache/spark/pull/1109 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2170: Fix for global name 'PIPE' is not ...
Github user gregakespret commented on the pull request: https://github.com/apache/spark/pull/1109#issuecomment-46399053 @rxin Sure, PR closed. At the time I created this PR, the other one wasn't yet merged in I suppose. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2170: Fix for global name 'PIPE' is not ...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1109#issuecomment-46399205 Yup looks like a racing condition (in a good way). Thanks a lot for catching this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2170: Fix for global name 'PIPE' is not ...
Github user danosipov commented on the pull request: https://github.com/apache/spark/pull/1109#issuecomment-46374082 Fixed the problem for me - thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2170: Fix for global name 'PIPE' is not ...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1109#issuecomment-46383100 Thanks. Merging this in master branch-1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2170: Fix for global name 'PIPE' is not ...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1109#issuecomment-46383668 Actually the merge script failed for this pull request. @pwendell any idea? ``` ./merge_spark_pr.py Which pull request would you like to merge? (e.g. 34): 1109 === Pull Request #1109 === title SPARK-2170: Fix for global name 'PIPE' is not defined source gregakespret/spark-ec2-subprocess-script target master url https://api.github.com/repos/apache/spark/pulls/1109 Proceed with merging pull request #1109? (y/n): y From github.com:apache/spark * [new ref] refs/pull/1109/head - PR_TOOL_MERGE_PR_1109 From https://git-wip-us.apache.org/repos/asf/spark * [new branch] master - PR_TOOL_MERGE_PR_1109_MASTER Switched to branch 'PR_TOOL_MERGE_PR_1109_MASTER' Automatic merge went well; stopped before committing as requested Traceback (most recent call last): File ./merge_spark_pr.py, line 316, in module merge_hash = merge_pr(pr_num, target_ref) File ./merge_spark_pr.py, line 152, in merge_pr run_cmd(['git', 'commit', '--author=%s' % primary_author] + merge_message_flags) File ./merge_spark_pr.py, line 78, in run_cmd return subprocess.check_output(cmd) File /Users/rxin/anaconda/lib/python2.7/subprocess.py, line 573, in check_output raise CalledProcessError(retcode, cmd, output=output) subprocess.CalledProcessError: Command '['git', 'commit', '--author=Grega Kespret gr...@celtra.com', '-m', uSPARK-2170: Fix for global name 'PIPE' is not defined, '-m', u'https://issues.apache.org/jira/browse/SPARK-2170\r\n\r\nBefore this fix, when running ./spark-ec2 script:\r\n\r\n```\r\nTraceback (most recent call last):\r\n File ./spark_ec2.py, line 894, in module\r\n main()\r\n File ./spark_ec2.py, line 886, in main\r\n real_main()\r\n File ./spark_ec2.py, line 770, in real_main\r\n setup_cluster(conn, master_nodes, slave_nodes, opts, True)\r\n File ./spark_ec2.py, line 475, in setup_cluster\r\ndot_ssh_tar = ssh_read(master, opts, [\'tar\', \'c\', \'.ssh\'])\r\n File ./spark_ec2.py, line 709, in ssh_read\r\nssh_command(opts) + [\'%s@%s\' % (opts.user, host), stringify_command(command)])\r\n File ./spark_ec2.py, line 696, in _check_output\r\nprocess = subprocess.Popen(stdout=PIP E, *popenargs, **kwargs)\r\nNameError: global name \'PIPE\' is not defined\r\n```', '-m', 'Author: Grega Kespret gr...@celtra.com', '-m', u'Closes #1109 from gregakespret/spark-ec2-subprocess-script and squashes the following commits:', '-m', 4168dc6 [Grega Kespret] Fix for global name 'PIPE' is not defined]' returned non-zero exit status 1 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2170: Fix for global name 'PIPE' is not ...
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1109#issuecomment-46384591 https://github.com/apache/spark/commit/b2ebf429e24566c29850c570f8d76943151ad78c --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2170: Fix for global name 'PIPE' is not ...
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1109#issuecomment-46384563 This was already fixed earlier today so it's probably hitting a merge conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2170: Fix for global name 'PIPE' is not ...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1109#issuecomment-46398768 @gregakespret since this has been fixed already in master, do you mind closing this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
