[GitHub] spark pull request: SPARK-2497 Exclude companion classes, with the...
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/1463#issuecomment-49579128 Also according to current code flow we don't check methods if we spot an annotation on a class. I can remove this restriction if you are okay with it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2497 Exclude companion classes, with the...
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/1463#issuecomment-49576941 @pwendell The reason I did this is, if you compile a file A.scala with contents ```scala @SomeAnnotation object A ``` it will produce two class files A.class and A$.class. And I don't understand why scala reflection does not detect the annotation on A.class, it is only detected on A$.class. This was the reason for doing it. The impact of this change is that, when we see annotation on a class we assume it is also present on its companion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2497 Exclude companion classes, with the...
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1463#issuecomment-49341909
@ScrapCodes could you explain a bit more how this fixes SPARK-2497. If I
look at the original false-positive the issue reported was not with a companion
class. It was actually in a method of the object itself. Also the method was
annotated, not the object.
```
Source:
https://github.com/apache/spark/pull/886/files#diff-0f907b47af6261abe00eb31097a9493bR41
Error:
[error] * method calculate(Double,Double)Double in object
org.apache.spark.mllib.tree.impurity.Gini's type has changed; was
(Double,Double)Double, is now: (Array[Double],Double)Double
[error]filter with:
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.mllib.tree.impurity.Gini.calculate")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2497 Exclude companion classes, with the...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1463#issuecomment-49314286 QA results for PR 1463:- This patch PASSES unit tests.- This patch merges cleanly- This patch adds no public classesFor more information see test ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16777/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2497 Exclude companion classes, with the...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1463#issuecomment-49302217 QA tests have started for PR 1463. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16777/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2497 Exclude companion classes, with the...
GitHub user ScrapCodes opened a pull request: https://github.com/apache/spark/pull/1463 SPARK-2497 Exclude companion classes, with their corresponding objects. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ScrapCodes/spark-1 SPARK-2497/mima-exclude-all Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/1463.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1463 commit 11eff8f7fe2a5dcd3bd6b0ed38c51c9f914e96c3 Author: Prashant Sharma Date: 2014-07-17T12:48:49Z SPARK-2497 Exclude companion classes, with their corresponding objects. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
