[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[javadba]

Github user javadba closed the pull request at:

https://github.com/apache/spark/pull/1586


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-68331226
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24880/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-68331223
  
QA results for PR 1586:- This patch FAILED unit tests.For more 
information see test 
ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24880/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-68328503
  
QA tests have started for PR 1586. This patch DID NOT merge cleanly! 
View progress: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24880/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[marmbrus]

Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-67422217
  
Mind closing this manually?  Our script seems to be missing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[javadba]

Github user javadba commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-67383303
  
OK Michael thanks for the update.

2014-12-17 11:21 GMT-08:00 Michael Armbrust :
>
> Hey @javadba , thanks for all the work on
> this, especially the time figuring out the surprisingly complicated
> semantics for this function. Also, sorry for the delay with 
review/merging!
> I'd love to add this, but right now I'm concerned that the way we are
> adding UDFs is unsustainable. I've written up some thoughts on the right
> way to proceed in SPARK-4867
> .
>
> Since I'm trying really hard to keep the PR queue small (mostly to help
> avoid PRs that languish like this one has been), I propose we close this
> issue for now and reopen once the UDF framework has been updated. I've
> linked your issue to that one so you or others can use this code as a
> starting point.
>
> —
> Reply to this email directly or view it on GitHub
> .
>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[marmbrus]

Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-67377013
  
Hey @javadba, thanks for all the work on this, especially the time figuring 
out the surprisingly complicated semantics for this function.  Also, sorry for 
the delay with review/merging!  I'd love to add this, but right now I'm 
concerned that the way we are adding UDFs is unsustainable.  I've written up 
some thoughts on the right way to proceed in 
[SPARK-4867](https://issues.apache.org/jira/browse/SPARK-4867).

Since I'm trying really hard to keep the PR queue small (mostly to help 
avoid PRs that languish like this one has been), I propose we close this issue 
for now and reopen once the UDF framework has been updated.  I've linked your 
issue to that one so you or others can use this code as a starting point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51643002
  
QA results for PR 1586:- This patch PASSES unit tests.- This patch 
merges cleanly- This patch adds the following public classes 
(experimental):case class Length(child: Expression) extends UnaryExpression 
{case class OctetLength(child: Expression, encoding : Expression) extends 
UnaryExpressionFor more information see test 
ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18209/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[javadba]

Github user javadba commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51640101
  
@marmbrusI am fine with delays on this - I just was unclear as to 
whether there some expectation on action on my part.Overall this is a minor 
enhancement but it has generated a non-trivial amount of interaction and 
effort. I can understand if this were put on hold. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51633885
  
QA tests have started for PR 1586. This patch merges cleanly. View 
progress: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18209/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[marmbrus]

Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51633297
  
add to whitelist


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[marmbrus]

Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51633288
  
Sorry for the delay.  We are a little swamped with the 1.1 release.  I will 
trigger Jenkins.  If we are still having issues with the SQL parser its 
probably okay to leave that out.  We are hoping to overhaul that codepath in 
the near future anyway.

Also, we are going to need to block this PR on 
https://issues.apache.org/jira/browse/SPARK-2863


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[javadba]

Github user javadba commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51614247
  
I have been waiting here for @ueshin and @marmbrus to decide on next steps. 
 Please be clear what are the next steps at this point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[ueshin]

Github user ueshin commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51179894
  
@javadba, @marmbrus 
I saw the case of SOF sometimes, it was not with @javadba's sequence, 
though.
I can't identify the exact reason now, but I guess this is not related to 
@javadba's commits and is more general problem.
I'll file a new issue on JIRA with some sequences to reproduce the problem.

I'd like to know the result of Jenkins build without the last commit 
22eddbc.
If succeed, we should use OCTET/CHAR_LENGTH, or if failed, we could use 
OCTET/CHAR_LEN for now, I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[ueshin]

Github user ueshin commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51152075
  
@javadba Thanks for detail.
Let me replay the sequence.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[javadba]

Github user javadba commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51149151
  
@ueshin  

I have git clone'd to a completely new area, and I reverted my last commit. 
 

git clone https://github.com/javadba/spark.git strlen2 
cd strlen2
git chckout strlen
git revert 22eddbce6a201c8f5b5c31859ceb972e60657377
 mvn -DskipTests  -Pyarn -Phive -Phadoop-2.3 clean compile package
 mvn  -Pyarn -Phive -Phadoop-2.3 test 
-DwildcardSuites=org.apache.spark.sql.hive.execution.HiveQuerySuite,org.apache.spark.sql.SQLQuerySuite,org.apache.spark.sql.catalyst.expressions.ExpressionEvaluationSuite

I get precisely the same error:

HiveQuerySuite:
21:03:31.120 WARN org.apache.spark.util.Utils: Your hostname, mithril 
resolves to a loopback address: 127.0.1.1; using 10.0.0.33 instead (on 
interface eth0)
21:03:31.121 WARN org.apache.spark.util.Utils: Set SPARK_LOCAL_IP if 
you need to bind to another address
21:03:37.294 WARN org.apache.hadoop.util.NativeCodeLoader: Unable to 
load native-hadoop library for your platform... using builtin-java classes 
where applicable
21:03:40.045 WARN com.jolbox.bonecp.BoneCPConfig: Max Connections < 1. 
Setting to 20
21:03:49.464 WARN com.jolbox.bonecp.BoneCPConfig: Max Connections < 1. 
Setting to 20
21:03:49.487 WARN org.apache.hadoop.hive.metastore.ObjectStore: Version 
information not found in metastore. hive.metastore.schema.verification is not 
enabled so recording the schema version 0.12.0
21:03:57.157 WARN com.jolbox.bonecp.BoneCPConfig: Max Connections < 1. 
Setting to 20
21:03:57.593 WARN com.jolbox.bonecp.BoneCPConfig: Max Connections < 1. 
Setting to 20
- single case
- double case
- case else null
- having no references
- boolean = number
- CREATE TABLE AS runs once
- between
- div
- division
*** RUN ABORTED ***
  java.lang.StackOverflowError:
  at 
scala.util.parsing.combinator.Parsers$Parser$$anonfun$append$1.apply(Parsers.scala:254)
  at 
scala.util.parsing.combinator.Parsers$$anon$3.apply(Parsers.scala:222)
  at 
scala.util.parsing.combinator.Parsers$Parser$$anonfun$append$1.apply(Parsers.scala:254)
  at 
scala.util.parsing.combinator.Parsers$Parser$$anonfun$append$1.apply(Parsers.scala:254)
  at 
scala.util.parsing.combinator.Parsers$$anon$3.apply(Parsers.scala:222)
  at 
scala.util.parsing.combinator.Parsers$Parser$$anonfun$append$1.apply(Parsers.scala:254)
  at 
scala.util.parsing.combinator.Parsers$Parser$$anonfun$append$1.apply(Parsers.scala:254)
  at 
scala.util.parsing.combinator.Parsers$$anon$3.apply(Parsers.scala:222)
  at 
scala.util.parsing.combinator.Parsers$Parser$$anonfun$append$1.apply(Parsers.scala:254)
  at 
scala.util.parsing.combinator.Parsers$Parser$$anonfun$append$1.apply(Parsers.scala:254)

Now, let's revert the revert :
git log 
commit db09cd132c2d7e995287eea54f3415726934138c 
Author: Stephen Boesch  
Date:   Mon Aug 4 20:54:24 2014 -0700

  Revert "Use Octet/Char_Len instead of Octet/Char_length due to 
apparent preexisting spark ParserCombinator bug."

This reverts commit 22eddbce6a201c8f5b5c31859ceb972e60657377.
git revert db09cd132c2d7e995287eea54f3415726934138c
mvn  -Pyarn -Phive -Phadoop-2.3 test 
-DwildcardSuites=org.apache.spark.sql.hive.execution.HiveQuerySuite,org.apache.spark.sql.SQLQuerySuite,org.apache.spark.sql.catalyst.expressions.ExpressionEvaluationSuite


Now those three test sutes pass again (specifically HiveQuerySuite did not 
fail)

And .. just to be *extra* sure here- that we can toggle between pass/fail 
arbitrary # of times: 

commit 602adedc9ca58d99957eb12bd91098ffe904604c
Author: Stephen Boesch 
Date:   Mon Aug 4 21:18:53 2014 -0700

Revert "Revert "Use Octet/Char_Len instead of Octet/Char_length due 
to apparent preexisting spark ParserCombinator bug.""

git revert 602adedc9ca58d99957eb12bd91098ffe904604c

And once again HiveQuerySuite fails with the same error.

So I have established clearly  the following:  
the strlen branch on my fork fails with SOF if we rollback the commit 
that changes OCTET/CHAR_LENGTH -> OCTET/CHAR_LEN. 






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.o

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[javadba]

Github user javadba commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51146419
  
@ueshinI repeatably verified that simply changing "OCTET_LEN" to 
"OCTET_LENGTH" ended up causing SOF.  By "repeatably" I mean:

  Set the 'constant'  val OCTET_LENGTH="OCTET_LENGTH"
  observe the error
  change to something like val OCTET_LENGTH="OCTET_LEN" or  val 
OCTET_LENGTH="OCTET_LENG"
  observe the error has gone away
  Rinse, cleanse, repeat

 i have been able to demonstrate this multiple times.  Now  the regression 
tests have been  run against the modified and reliable code.   

Please re-run your tests in a fresh area.  I will do the same .. but i am 
hesitant to consider to revert because we have positive test results now with 
the latest commit (as well as my results of the problem before the commit). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[ueshin]

Github user ueshin commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51145793
  
Hi @javadba, I tested `org.apache.spark.sql.SQLQuerySuite` and 
`org.apache.spark.sql.hive.execution.HiveQuerySuite` locally, and they worked 
fine even if I reverted the last commit 22eddbc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51143772
  
QA results for PR 1586:- This patch PASSES unit tests.- This patch 
merges cleanly- This patch adds the following public classes 
(experimental):case class Length(child: Expression) extends UnaryExpression 
{case class OctetLength(child: Expression, encoding : Expression) extends 
UnaryExpressionFor more information see test 
ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17902/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51138818
  
QA tests have started for PR 1586. This patch merges cleanly. View 
progress: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17902/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[marmbrus]

Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51138518
  
test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[javadba]

Github user javadba commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51065193
  
Hi,
  For some reason the CORE module testing has ballooned in overall testing 
time: it took over 7.5 hours to run. There was one timeout error out of 736 
tests - and it is quite unlikely to have anything to do with the code added in 
this PR.  

Here is the test that failed and then the overall results:

DriverSuite:
Spark assembly has been built with Hive, including Datanucleus jars on 
classpath
- driver should exit after finishing *** FAILED ***
  TestFailedDueToTimeoutException was thrown during property 
evaluation. (DriverSuite.scala:40)
Message: The code passed to failAfter did not complete within 60 
seconds.
Location: (DriverSuite.scala:41)
Occurred at table row 0 (zero based, not counting headings), which 
had values (
  master = local
)

  Tests: succeeded 723, failed 1, canceled 0, ignored 7, pending 0
*** 1 TEST FAILED ***
[INFO] 

[INFO] Reactor Summary:
[INFO] 
[INFO] Spark Project Parent POM ... SUCCESS [  
1.180 s]
[INFO] Spark Project Core . FAILURE [  
07:35 h]

So I am not presently in a position to run regression tests - given the 
overall runtime will be doulbe-digit hours.  Would someone please run Jenkins 
on this code?  




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

[javadba]

Github user javadba commented on the pull request:

https://github.com/apache/spark/pull/1586#issuecomment-51020150
  
The rename change was committed/pushed and the most germane tests pass. I 
am re-running full regression.  One thing I have noticed already:  the 
flume-sink external project is failing - looks to be unrelated to any of my 
work. But I am looking into it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org