[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-11-14 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/2518


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-11-14 Thread andrewor14
Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/2518#issuecomment-63132422
  
I think we can just go ahead and merge this actually because the tests are 
irrelevant. LGTM this is going into master and 1.2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-11-14 Thread ash211
Github user ash211 commented on the pull request:

https://github.com/apache/spark/pull/2518#issuecomment-63103760
  
@JoshRosen A PySpark test failed on this docs-only PR.  Any idea what might 
be wrong or who would be good to go about debugging the flaky test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/2518#issuecomment-63101998
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23372/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-11-14 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2518#issuecomment-63101985
  
  [Test build #23372 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23372/consoleFull)
 for   PR 2518 at commit 
[`058b257`](https://github.com/apache/spark/commit/058b257149313ae0268cdddb949e3d373733c349).
 * This patch **fails PySpark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-11-14 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2518#issuecomment-63091491
  
  [Test build #23372 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23372/consoleFull)
 for   PR 2518 at commit 
[`058b257`](https://github.com/apache/spark/commit/058b257149313ae0268cdddb949e3d373733c349).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-11-14 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on a diff in the pull request:

https://github.com/apache/spark/pull/2518#discussion_r20367562
  
--- Diff: conf/spark-env.sh.template ---
@@ -41,3 +41,10 @@
 # - SPARK_HISTORY_OPTS, to set config properties only for the history 
server (e.g. "-Dx=y")
 # - SPARK_DAEMON_JAVA_OPTS, to set config properties for all daemons (e.g. 
"-Dx=y")
 # - SPARK_PUBLIC_DNS, to set the public dns name of the master or workers
+
+# Generic options for the daemons used in the standalone deploy mode
+# - SPARK_CONF_DIR  Alternate conf dir. (Default: ${SPARK_HOME}/conf)
+# - SPARK_LOG_DIR   Where log files are stored.  (Default: 
${SPARK_HOME}/logs)
+# - SPARK_PID_DIR   The pid files are stored. (Default: /tmp)
--- End diff --

Nit: ”Where the pid file is stored"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/2518#issuecomment-63037110
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23361/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-11-14 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2518#issuecomment-63037099
  
  [Test build #23361 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23361/consoleFull)
 for   PR 2518 at commit 
[`a17cb4b`](https://github.com/apache/spark/commit/a17cb4b8bac4fe1d98bc0433203155753176e0fd).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-11-14 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2518#issuecomment-63025707
  
  [Test build #23361 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23361/consoleFull)
 for   PR 2518 at commit 
[`a17cb4b`](https://github.com/apache/spark/commit/a17cb4b8bac4fe1d98bc0433203155753176e0fd).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-11-14 Thread ash211
Github user ash211 commented on the pull request:

https://github.com/apache/spark/pull/2518#issuecomment-63025274
  
@andrewor14 Updated, would you be able to merge in time for the Spark 1.2.0 
release?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-10-28 Thread andrewor14
Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/2518#issuecomment-60820617
  
Hey @ash211 I think these are slightly outdated as of this commit 
https://github.com/apache/spark/commit/44d8b45a38c8d934628373a3b21084432516ee00.
 Would you mind updating it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-09-24 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2518#issuecomment-56645112
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20745/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-09-24 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2518#issuecomment-56645105
  
  [QA tests have 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20745/consoleFull)
 for   PR 2518 at commit 
[`af89096`](https://github.com/apache/spark/commit/af89096fd93a6c85ce5828268ba546fc691f3e3b).
 * This patch **passes** unit tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-09-24 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2518#issuecomment-56638326
  
  [QA tests have 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20745/consoleFull)
 for   PR 2518 at commit 
[`af89096`](https://github.com/apache/spark/commit/af89096fd93a6c85ce5828268ba546fc691f3e3b).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-3663 Document SPARK_LOG_DIR and SPARK_PI...

2014-09-24 Thread ash211
GitHub user ash211 opened a pull request:

https://github.com/apache/spark/pull/2518

SPARK-3663 Document SPARK_LOG_DIR and SPARK_PID_DIR

These descriptions are from the header of spark-daemon.sh

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ash211/spark SPARK-3663

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/2518.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2518


commit af89096fd93a6c85ce5828268ba546fc691f3e3b
Author: Andrew Ash 
Date:   2014-09-24T08:07:21Z

SPARK-3663 Document SPARK_LOG_DIR and SPARK_PID_DIR

These descriptions are from the header of spark-daemon.sh




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org