[GitHub] spark pull request: SPARK-4012: call tryOrExit instead of logUncau...

2014-10-20 Thread CodingCat
GitHub user CodingCat opened a pull request:

https://github.com/apache/spark/pull/2864

SPARK-4012: call tryOrExit instead of logUncaughtExceptions in 
ContextCleaner

When running an might-be-memory-intensive application locally, I received 
the following exception

```
Exception: java.lang.OutOfMemoryError thrown from the 
UncaughtExceptionHandler in thread Spark Context Cleaner
Java HotSpot(TM) 64-Bit Server VM warning: Exception 
java.lang.OutOfMemoryError occurred dispatching signal SIGINT to handler- the 
VM may need to be forcibly terminated
Exception: java.lang.OutOfMemoryError thrown from the 
UncaughtExceptionHandler in thread Driver Heartbeater
Java HotSpot(TM) 64-Bit Server VM warning: Exception 
java.lang.OutOfMemoryError occurred dispatching signal SIGINT to handler- 
the VM may need to be forcibly terminated
Java HotSpot(TM) 64-Bit Server VM warning: Exception 
java.lang.OutOfMemoryError occurred dispatching signal SIGINT to handler- the 
VM may need to be forcibly terminated
Java HotSpot(TM) 64-Bit Server VM warning: Exception 
java.lang.OutOfMemoryError occurred dispatching signal SIGINT to handler- the 
VM may need to be forcibly terminated
Java HotSpot(TM) 64-Bit Server VM warning: Exception 
java.lang.OutOfMemoryError occurred dispatching signal SIGINT to handler- the 
VM may need to be forcibly terminated
Java HotSpot(TM) 64-Bit Server VM warning: Exception 
java.lang.OutOfMemoryError occurred dispatching signal SIGINT to handler- the 
VM may need to be forcibly terminated
Java HotSpot(TM) 64-Bit Server VM warning: Exception 
java.lang.OutOfMemoryError occurred dispatching signal SIGINT to handler- the 
VM may need to be forcibly terminated
```

the reason is that we start ContextCleaner in a separate thread but didn't 
capture the exception there (re-throw with logUncaughtExceptions)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/CodingCat/spark SPARK-4012

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/2864.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2864


commit 287bd0750ea870e4ff34f28339f92b2e293bcfc0
Author: Nan Zhu nanzhu@nans-macbook-pro.local
Date:   2014-10-20T19:57:32Z

call tryOrExit instead of logUncaughtExceptions in 
ContextCleaner.keepCleaning




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4012: call tryOrExit instead of logUncau...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2864#issuecomment-59851664
  
  [QA tests have 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21935/consoleFull)
 for   PR 2864 at commit 
[`287bd07`](https://github.com/apache/spark/commit/287bd0750ea870e4ff34f28339f92b2e293bcfc0).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4012: call tryOrExit instead of logUncau...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/2864#issuecomment-59852140
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21935/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4012: call tryOrExit instead of logUncau...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2864#issuecomment-59852133
  
  [QA tests have 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21935/consoleFull)
 for   PR 2864 at commit 
[`287bd07`](https://github.com/apache/spark/commit/287bd0750ea870e4ff34f28339f92b2e293bcfc0).
 * This patch **fails to build**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4012: call tryOrExit instead of logUncau...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2864#issuecomment-59853916
  
  [QA tests have 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21937/consoleFull)
 for   PR 2864 at commit 
[`55cafc8`](https://github.com/apache/spark/commit/55cafc82d82c6df1264266db3e05c46564af37d5).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4012: call tryOrExit instead of logUncau...

2014-10-20 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2864#issuecomment-59854276
  
  [QA tests have 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21937/consoleFull)
 for   PR 2864 at commit 
[`55cafc8`](https://github.com/apache/spark/commit/55cafc82d82c6df1264266db3e05c46564af37d5).
 * This patch **fails to build**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `  case class ReconnectWorker(masterUrl: String) extends DeployMessage`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: SPARK-4012: call tryOrExit instead of logUncau...

2014-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/2864#issuecomment-59854280
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21937/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org