[GitHub] spark pull request: SPARK-4159 [CORE] [WIP] Maven build doesn't ru...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3651#issuecomment-66425799 [Test build #24303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24303/consoleFull) for PR 3651 at commit [`11bd041`](https://github.com/apache/spark/commit/11bd041909a20b6d7c1b5074d6b78133aa1ff547). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-4159 [CORE] [WIP] Maven build doesn't ru...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3651#issuecomment-66423082 [Test build #24299 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24299/consoleFull) for PR 3651 at commit [`125b0b6`](https://github.com/apache/spark/commit/125b0b64efc22c5a573aea00bf9bfdb53393cdbe). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-4159 [CORE] [WIP] Maven build doesn't ru...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3651#issuecomment-66423087 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24299/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-4159 [CORE] [WIP] Maven build doesn't ru...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3651#issuecomment-66416040 [Test build #24299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24299/consoleFull) for PR 3651 at commit [`125b0b6`](https://github.com/apache/spark/commit/125b0b64efc22c5a573aea00bf9bfdb53393cdbe). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-4159 [CORE] [WIP] Maven build doesn't ru...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3651#discussion_r21585931
--- Diff: pom.xml ---
@@ -941,19 +950,38 @@
true
+
org.apache.maven.plugins
maven-surefire-plugin
- 2.17
+ 2.18
+
-
-true
+
+ **/Test*.java
+ **/*Test.java
+ **/*TestCase.java
+ **/*Suite.java
+
+
${project.build.directory}/surefire-reports
+-Xmx3g -XX:MaxPermSize=${MaxPermGen}
-XX:ReservedCodeCacheSize=512m
+
+ true
+
${session.executionRootDirectory}
+ 1
+ false
+
false
+
${test_classpath}
+
true
+
+
--- End diff --
It probably is; I had not tried it just yet. I do think this is a precursor
to more change, potentially using `surefire` for everything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-4159 [CORE] [WIP] Maven build doesn't ru...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3651#issuecomment-66389927 [Test build #24269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24269/consoleFull) for PR 3651 at commit [`f165f58`](https://github.com/apache/spark/commit/f165f588ebf5c446bfc13930c16cd26c2436b8b5). * This patch **passes all tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-4159 [CORE] [WIP] Maven build doesn't ru...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3651#issuecomment-66389931 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24269/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-4159 [CORE] [WIP] Maven build doesn't ru...
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3651#discussion_r21573086
--- Diff: pom.xml ---
@@ -941,19 +950,38 @@
true
+
org.apache.maven.plugins
maven-surefire-plugin
- 2.17
+ 2.18
+
-
-true
+
+ **/Test*.java
+ **/*Test.java
+ **/*TestCase.java
+ **/*Suite.java
+
+
${project.build.directory}/surefire-reports
+-Xmx3g -XX:MaxPermSize=${MaxPermGen}
-XX:ReservedCodeCacheSize=512m
+
+ true
+
${session.executionRootDirectory}
+ 1
+ false
+
false
+
${test_classpath}
+
true
+
+
--- End diff --
N00b question: Is it not possible to have Surefire run the Scala tests as
well? Or are you just saving that change for a future PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-4159 [CORE] [WIP] Maven build doesn't ru...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3651#issuecomment-66379403 [Test build #24269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24269/consoleFull) for PR 3651 at commit [`f165f58`](https://github.com/apache/spark/commit/f165f588ebf5c446bfc13930c16cd26c2436b8b5). * This patch **does not merge cleanly**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-4159 [CORE] [WIP] Maven build doesn't ru...
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/3651 SPARK-4159 [CORE] [WIP] Maven build doesn't run JUnit test suites This PR: - Reenables `surefire`, and copies config from `scalatest` (which is itself an old fork of `surefire`, so similar) - Tells `surefire` to test only Java tests - Enables `surefire` and `scalatest` for all children, and in turn eliminates some duplication. For me this causes the Scala and Java tests to be run once each, it seems, as desired. It doesn't affect the SBT build but works for Maven. I still need to verify that all of the Scala tests and Java tests are being run. You can merge this pull request into a Git repository by running: $ git pull https://github.com/srowen/spark SPARK-4159 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/3651.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3651 commit f165f588ebf5c446bfc13930c16cd26c2436b8b5 Author: Sean Owen Date: 2014-12-09T22:45:03Z Reenable Java tests by reenabling surefire with config cloned from scalatest; centralize test config in the parent --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
