[GitHub] spark pull request: SPARK-5308 [BUILD] MD5 / SHA1 hash format does...
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4161#issuecomment-71699359 Thanks Sean - pulling this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-5308 [BUILD] MD5 / SHA1 hash format does...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4161 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-5308 [BUILD] MD5 / SHA1 hash format does...
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/4161 SPARK-5308 [BUILD] MD5 / SHA1 hash format doesn't match standard Maven output Here's one way to make the hashes match what Maven's plugins would create. It takes a little extra footwork since OS X doesn't have the same command line tools. An alternative is just to make Maven output these of course - would that be better? I ask in case there is a reason I'm missing, like, we need to hash files that Maven doesn't build. You can merge this pull request into a Git repository by running: $ git pull https://github.com/srowen/spark SPARK-5308 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/4161.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4161 commit e25eff8cd20e436002c77426e9b5e04cc1a19f2e Author: Sean Owen so...@cloudera.com Date: 2015-01-22T14:22:22Z Generate MD5, SHA1 hashes in a format like Maven's plugin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-5308 [BUILD] MD5 / SHA1 hash format does...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4161#issuecomment-71027549 [Test build #25968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25968/consoleFull) for PR 4161 at commit [`e25eff8`](https://github.com/apache/spark/commit/e25eff8cd20e436002c77426e9b5e04cc1a19f2e). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-5308 [BUILD] MD5 / SHA1 hash format does...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4161#issuecomment-71039399 [Test build #25968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25968/consoleFull) for PR 4161 at commit [`e25eff8`](https://github.com/apache/spark/commit/e25eff8cd20e436002c77426e9b5e04cc1a19f2e). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-5308 [BUILD] MD5 / SHA1 hash format does...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4161#issuecomment-71106554 [Test build #25973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25973/consoleFull) for PR 4161 at commit [`70d09d0`](https://github.com/apache/spark/commit/70d09d0880302e667a69f0b073d1b85af75c1c5e). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-5308 [BUILD] MD5 / SHA1 hash format does...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4161#issuecomment-71039411 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25968/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-5308 [BUILD] MD5 / SHA1 hash format does...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4161#issuecomment-71117062 [Test build #25973 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25973/consoleFull) for PR 4161 at commit [`70d09d0`](https://github.com/apache/spark/commit/70d09d0880302e667a69f0b073d1b85af75c1c5e). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-5308 [BUILD] MD5 / SHA1 hash format does...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4161#issuecomment-71117069 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25973/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-5308 [BUILD] MD5 / SHA1 hash format does...
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/4161#discussion_r23407106 --- Diff: dev/create-release/create-release.sh --- @@ -122,8 +122,14 @@ if [[ ! $@ =~ --package-only ]]; then for file in $(find . -type f) do echo $GPG_PASSPHRASE | gpg --passphrase-fd 0 --output $file.asc --detach-sig --armour $file; -gpg --print-md MD5 $file $file.md5; -gpg --print-md SHA1 $file $file.sha1 +if [ `command -v md5` ]; then --- End diff -- Minor style comment: Could we use `$(...)` instead of backticks? I believe use of backticks is discouraged in bash. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
