[GitHub] spark pull request: Spark 4229 Create hadoop configuration in a co...

2014-12-01 Thread marmbrus
Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/3102#issuecomment-65164900
  
Sorry for the delay here.  A few comments: can you open the PR against 
master instead of a specific branch and also merge with master?

The new hadoop config documentation: this was already there and you are 
just documenting it? /cc @pwendell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: Spark 4229 Create hadoop configuration in a co...

2014-12-01 Thread koeninger
Github user koeninger commented on the pull request:

https://github.com/apache/spark/pull/3102#issuecomment-65176731
  
Yes, the new hadoop config documentation is just documenting the behavior 
of SparkHadoopUtil.scala lines 95-100

Sorry about the branch situation, I was unclear on what the plan for 1.2 
merges was.
Opened a new PR that should merge cleanly into master

https://github.com/apache/spark/pull/3543


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: Spark 4229 Create hadoop configuration in a co...

2014-12-01 Thread koeninger
Github user koeninger closed the pull request at:

https://github.com/apache/spark/pull/3102


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: Spark 4229 Create hadoop configuration in a co...

2014-11-04 Thread koeninger
GitHub user koeninger opened a pull request:

https://github.com/apache/spark/pull/3102

Spark 4229 Create hadoop configuration in a consistent way



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/koeninger/spark-1 SPARK-4229

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/3102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3102


commit 3cd384f77ba9505fe7c94c82980e07044f6b128c
Author: cody koeninger c...@koeninger.org
Date:   2014-11-04T22:40:17Z

SPARK-4229 use SparkHadoopUtil.get.conf so that hadoop properties are 
copied from spark config

commit f2ee4f9f1ed717d54fb7916ff2cf3ae85468eab0
Author: cody koeninger c...@koeninger.org
Date:   2014-11-04T22:41:07Z

SPARK-4229 document handling of spark.hadoop.* properties

commit eebbdcc53caa214079612732d3a4a13e57cecffe
Author: cody koeninger c...@koeninger.org
Date:   2014-11-05T03:26:26Z

SPARK-4229 fix broken table in documentation, make hadoop doc formatting 
match that of runtime env




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: Spark 4229 Create hadoop configuration in a co...

2014-11-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/3102#issuecomment-61755719
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: Spark 4229 Create hadoop configuration in a co...

2014-11-04 Thread srowen
Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/3102#issuecomment-61770464
  
Looks pretty reasonable to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org