[GitHub] spark pull request: Switched to binary mode for file reading
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/7215#issuecomment-118922652 Could you add `[SPARK-8821] [EC2]` to the PR title ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Switched to binary mode for file reading
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7215#issuecomment-118930717 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Switched to binary mode for file reading
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/7215#issuecomment-118920893 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Switched to binary mode for file reading
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7215#issuecomment-118931072 [Test build #36590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36590/consoleFull) for PR 7215 at commit [`e86957a`](https://github.com/apache/spark/commit/e86957a71749a1c5031474d7837bc4b13a59cfda). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Switched to binary mode for file reading
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7215#issuecomment-118930617 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Switched to binary mode for file reading
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7215#issuecomment-118930204 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Switched to binary mode for file reading
Github user reactormonk commented on the pull request: https://github.com/apache/spark/pull/7215#issuecomment-118463218 https://issues.apache.org/jira/browse/SPARK-8821 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Switched to binary mode for file reading
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/7215#issuecomment-118438351 Could you open a JIRA for this ? See https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark for more details cc @nchammas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Switched to binary mode for file reading
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7215#issuecomment-118447863 I think the motivations for JIRA tickets are: - JIRA helps us track where a fix has been applied; this is important if a fix needs to be applied to multiple maintenance branches and it also helpful when a fix is reverted. - The contributor credits in our release notes are automatically generated from JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Switched to binary mode for file reading
Github user reactormonk commented on the pull request: https://github.com/apache/spark/pull/7215#issuecomment-118447227 Looks too trivial to jump through the hoops of JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Switched to binary mode for file reading
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7215#issuecomment-118422021 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Switched to binary mode for file reading
GitHub user reactormonk opened a pull request: https://github.com/apache/spark/pull/7215 Switched to binary mode for file reading Otherwise the script will crash with - Downloading boto... Traceback (most recent call last): File ec2/spark_ec2.py, line 148, in module setup_external_libs(external_libs) File ec2/spark_ec2.py, line 128, in setup_external_libs if hashlib.md5(tar.read()).hexdigest() != lib[md5]: File /usr/lib/python3.4/codecs.py, line 319, in decode (result, consumed) = self._buffer_decode(data, self.errors, final) UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8b in position 1: invalid start byte In case of an utf8 env setting. You can merge this pull request into a Git repository by running: $ git pull https://github.com/reactormonk/spark branch-1.4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/7215.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7215 commit 3255026e7b2b073c02b4a4e6a09a74c60bb2d9e1 Author: Simon Hafner hafnersi...@gmail.com Date: 2015-07-03T20:22:55Z Switched to binary mode for file reading Otherwise the script will crash with - Downloading boto... Traceback (most recent call last): File ec2/spark_ec2.py, line 148, in module setup_external_libs(external_libs) File ec2/spark_ec2.py, line 128, in setup_external_libs if hashlib.md5(tar.read()).hexdigest() != lib[md5]: File /usr/lib/python3.4/codecs.py, line 319, in decode (result, consumed) = self._buffer_decode(data, self.errors, final) UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8b in position 1: invalid start byte In case of an utf8 env setting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
