[GitHub] spark pull request: Turn UpdateBlockInfo into case class.
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1872#issuecomment-51724118 It is using some custom serialization to reduce serialization overhead. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Turn UpdateBlockInfo into case class.
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/1872#issuecomment-51710872 If case class then does it still need to be Externalizable ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Turn UpdateBlockInfo into case class.
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1872 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Turn UpdateBlockInfo into case class.
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1872#issuecomment-51707226 I'm going to merge this one since the test failure is independent of this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Turn UpdateBlockInfo into case class.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1872#issuecomment-51707087 QA results for PR 1872:- This patch FAILED unit tests.- This patch merges cleanly- This patch adds the following public classes (experimental):case class UpdateBlockInfo(For more information see test ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18269/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Turn UpdateBlockInfo into case class.
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/1872#issuecomment-51706705 LGTM and wait for Jenkins ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Turn UpdateBlockInfo into case class.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1872#issuecomment-51706499 QA tests have started for PR 1872. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18269/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Turn UpdateBlockInfo into case class.
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/1872 Turn UpdateBlockInfo into case class. This helps us log UpdateBlockInfo properly once #1870 is merged. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rxin/spark UpdateBlockInfo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/1872.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1872 commit 0cee1c2b7b62df22716c8d44d61a8795d0167397 Author: Reynold Xin Date: 2014-08-10T05:02:49Z Turn UpdateBlockInfo into case class. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org