[GitHub] spark pull request: Typos in Spark
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/798#discussion_r12721749 --- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala --- @@ -33,7 +33,7 @@ import org.apache.spark.util.ByteBufferInputStream * - [[org.apache.spark.scheduler.ResultTask]] * * A Spark job consists of one or more stages. The very last stage in a job consists of multiple - * ResultTask's, while earlier stages consist of ShuffleMapTasks. A ResultTask executes the task --- End diff -- Actually never mind this looks good. I looked a bit into the rest of the code base and "ResultTasks" is consistent with RDDs. Going to merge this now. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Typos in Spark
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/798#issuecomment-43283906 The 2nd typo fix looks good - but we should revert the first one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Typos in Spark
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/798#discussion_r12721213 --- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala --- @@ -33,7 +33,7 @@ import org.apache.spark.util.ByteBufferInputStream * - [[org.apache.spark.scheduler.ResultTask]] * * A Spark job consists of one or more stages. The very last stage in a job consists of multiple - * ResultTask's, while earlier stages consist of ShuffleMapTasks. A ResultTask executes the task --- End diff -- Actually in this case, ResultTask's is probably better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Typos in Spark
Github user huajianmao commented on a diff in the pull request: https://github.com/apache/spark/pull/798#discussion_r12721623 --- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala --- @@ -33,7 +33,7 @@ import org.apache.spark.util.ByteBufferInputStream * - [[org.apache.spark.scheduler.ResultTask]] * * A Spark job consists of one or more stages. The very last stage in a job consists of multiple - * ResultTask's, while earlier stages consist of ShuffleMapTasks. A ResultTask executes the task --- End diff -- Is there any special meaning here to use "ResultTask's"? If not ,shall we keep it consistent with the following "ShuffleMapTasks"? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: Typos in Spark
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/798 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
