[GitHub] spark pull request: Upgrade genjavadoc and use upstream version

[jodersky]

Github user jodersky commented on the pull request:

https://github.com/apache/spark/pull/12707#issuecomment-214849927
  
cc @mengxr 
@JoshRosen, is the maven build ok? I could only find references to 
genjavadoc in sbt.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: Upgrade genjavadoc and use upstream version

[jodersky]

GitHub user jodersky opened a pull request:

https://github.com/apache/spark/pull/12707

Upgrade genjavadoc and use upstream version

## What changes were proposed in this pull request?
In the past, genjavadoc had issues with package private members which led 
the spark project to use a forked version. This issue has been fixed upstream 
(typesafehub/genjavadoc#70) and a release is available for scala versions 2.10, 
2.11 **and 2.12**, hence a forked version for spark is no longer necessary.
This pull request updates the build configuration to use the newest 
upstream genjavadoc.

## How was this patch tested?
The build was run `sbt unidoc`. During the process javadoc emits some 
errors on the generates java stubs, however these errors were also present 
before the upgrade. Furthermore, the produces html is fine.




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jodersky/spark SPARK-14511-genjavadoc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/12707.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12707


commit f7d649c47d0d6f082b5a6237e4b60e8bd8cf3716
Author: Jakob Odersky 
Date:   2016-04-25T22:58:40Z

Upgrade genjavadoc and use upstream version




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org