[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-27 Thread rxin
Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/2473#issuecomment-57043606
  
Merging in master. Thanks!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/2473


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-23 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request:

https://github.com/apache/spark/pull/2473#issuecomment-56622767
  
For example fixed in PR



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-22 Thread nchammas
Github user nchammas commented on a diff in the pull request:

https://github.com/apache/spark/pull/2473#discussion_r17889459
  
--- Diff: docs/ec2-scripts.md ---
@@ -137,11 +146,11 @@ cost you any EC2 cycles, but ***will*** continue to 
cost money for EBS
 storage.
 
 - To stop one of your clusters, go into the `ec2` directory and run
-`./spark-ec2 stop cluster-name`.
+`./spark-ec2 --region=ec2-region stop cluster-name`.
 - To restart it later, run
-`./spark-ec2 -i key-file start cluster-name`.
+`./spark-ec2 -i key-file --region=ec2-region start cluster-name`.
 - To ultimately destroy the cluster and stop consuming EBS space, run
-`./spark-ec2 destroy cluster-name` as described in the previous
+`./spark-ec2 --region=ec2-region destroy cluster-name` as described in 
the previous
--- End diff --

Hmm, are you sure `destroy` requires `ec2-region`? I've been successfully 
destroying EC2 clusters without specifying it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-22 Thread nchammas
Github user nchammas commented on a diff in the pull request:

https://github.com/apache/spark/pull/2473#discussion_r17889468
  
--- Diff: docs/ec2-scripts.md ---
@@ -48,6 +48,15 @@ by looking for the Name tag of the instance in the 
Amazon EC2 Console.
 key pair, `num-slaves` is the number of slave nodes to launch (try
 1 at first), and `cluster-name` is the name to give to your
 cluster.
+
+For Example:
--- End diff --

Minor nit: For example: (lower case E)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-22 Thread rxin
Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/2473#discussion_r17889800
  
--- Diff: docs/ec2-scripts.md ---
@@ -137,11 +146,11 @@ cost you any EC2 cycles, but ***will*** continue to 
cost money for EBS
 storage.
 
 - To stop one of your clusters, go into the `ec2` directory and run
-`./spark-ec2 stop cluster-name`.
+`./spark-ec2 --region=ec2-region stop cluster-name`.
 - To restart it later, run
-`./spark-ec2 -i key-file start cluster-name`.
+`./spark-ec2 -i key-file --region=ec2-region start cluster-name`.
 - To ultimately destroy the cluster and stop consuming EBS space, run
-`./spark-ec2 destroy cluster-name` as described in the previous
+`./spark-ec2 --region=ec2-region destroy cluster-name` as described in 
the previous
--- End diff --

it does require it unless the region is us-east.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-22 Thread nchammas
Github user nchammas commented on a diff in the pull request:

https://github.com/apache/spark/pull/2473#discussion_r17889871
  
--- Diff: docs/ec2-scripts.md ---
@@ -137,11 +146,11 @@ cost you any EC2 cycles, but ***will*** continue to 
cost money for EBS
 storage.
 
 - To stop one of your clusters, go into the `ec2` directory and run
-`./spark-ec2 stop cluster-name`.
+`./spark-ec2 --region=ec2-region stop cluster-name`.
 - To restart it later, run
-`./spark-ec2 -i key-file start cluster-name`.
+`./spark-ec2 -i key-file --region=ec2-region start cluster-name`.
 - To ultimately destroy the cluster and stop consuming EBS space, run
-`./spark-ec2 destroy cluster-name` as described in the previous
+`./spark-ec2 --region=ec2-region destroy cluster-name` as described in 
the previous
--- End diff --

Ah, right. It's set as the default.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-21 Thread jeffsteinmetz
Github user jeffsteinmetz commented on the pull request:

https://github.com/apache/spark/pull/2473#issuecomment-56312949
  
now consistent, using lower-case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-20 Thread jeffsteinmetz
GitHub user jeffsteinmetz opened a pull request:

https://github.com/apache/spark/pull/2473

stop, start and destroy require the EC2_REGION

i.e  
./spark-ec2 --region=us-west-1 stop yourclustername

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeffsteinmetz/spark master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/2473.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2473


commit 37fc8769b67c3fef2ca165c98f38b62e2244d202
Author: Jeff Steinmetz jeffrey.steinm...@gmail.com
Date:   2014-09-20T21:07:43Z

stop, start and destroy require the EC2_REGION 

i.e  
./spark-ec2 --region=us-west-1 stop yourclustername




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-20 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/2473#issuecomment-56280512
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-20 Thread rxin
Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/2473#discussion_r17822066
  
--- Diff: docs/ec2-scripts.md ---
@@ -137,11 +137,11 @@ cost you any EC2 cycles, but ***will*** continue to 
cost money for EBS
 storage.
 
 - To stop one of your clusters, go into the `ec2` directory and run
-`./spark-ec2 stop cluster-name`.
+`./spark-ec2 --region=EC2_REGION stop cluster-name`.
--- End diff --

can u use lower case and hyphen like cluster-name? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-20 Thread rxin
Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/2473#issuecomment-56282092
  
Thanks. This is great to have. I left a tiny comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-20 Thread jeffsteinmetz
Github user jeffsteinmetz commented on a diff in the pull request:

https://github.com/apache/spark/pull/2473#discussion_r17822444
  
--- Diff: docs/ec2-scripts.md ---
@@ -137,11 +137,11 @@ cost you any EC2 cycles, but ***will*** continue to 
cost money for EBS
 storage.
 
 - To stop one of your clusters, go into the `ec2` directory and run
-`./spark-ec2 stop cluster-name`.
+`./spark-ec2 --region=EC2_REGION stop cluster-name`.
--- End diff --

the format EC2_REGION  UPPERCASE_UNDERSCORE was used throughout the rest 
of the documentation earlier.
This change was to indicate the python script would not work with stop 
unless region was passed as an argument.
It would need to be a global replace if we wanted to reflect the same 
approach earlier in the document.
Other UPPERCASE_SCORE text already in the docs include things like:
INSTANCE_TYPE
EC2_ZONE
etc..

cluster-name is lowercase in the rest of the doc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: stop, start and destroy require the EC2_REGION

2014-09-20 Thread rxin
Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/2473#discussion_r17823526
  
--- Diff: docs/ec2-scripts.md ---
@@ -137,11 +137,11 @@ cost you any EC2 cycles, but ***will*** continue to 
cost money for EBS
 storage.
 
 - To stop one of your clusters, go into the `ec2` directory and run
-`./spark-ec2 stop cluster-name`.
+`./spark-ec2 --region=EC2_REGION stop cluster-name`.
--- End diff --

there are some inconsistency in this whole doc. Would you mind renaming 
either all of them to upper case, or all of them to lower case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org