[GitHub] spark pull request: update twitter4j to 4.0.4 version
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/9221#issuecomment-150296842 slf4j & log4j are in sync with Spark 1.6. I can't actually see an explicit ref to commons-logging in the spark poms (just lots of exclusions of the hadoop one), but some indirect references come in at v 1.1.3. That leaves kryo. Precisely because this is a very old import with different package names, this isn't going to be as fraught as trouble as the main kryo package. mvn repo [says its just for testing anyway](http://mvnrepository.com/artifact/org.twitter4j/twitter4j-core/4.0.4) No sign of the other troublespots: guava, jackson, jetty... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: update twitter4j to 4.0.4 version
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9221#issuecomment-150201234 Yes, but if you're proposing the change I believe you need to investigate the implications. This doesn't address dependency changes which Steve already alluded to. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: update twitter4j to 4.0.4 version
Github user pronix commented on the pull request: https://github.com/apache/spark/pull/9221#issuecomment-150200410 @srowen Official documentation about upgrade http://blog.twitter4j.org/2014/03/13/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: update twitter4j to 4.0.4 version
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9221#issuecomment-150177373 @pronix also you need to look at https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark and update the title, etc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: update twitter4j to 4.0.4 version
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9221#issuecomment-150177327 Yeah, we would need more info here, to update across major releases. Because this is just an isolated 'leaf' package, we can probably tolerate more change there. But, at least, can you summarize any incompatible changes or siginficant ones, and more importantly key changes in the dependency tree? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: update twitter4j to 4.0.4 version
Github user pronix commented on the pull request: https://github.com/apache/spark/pull/9221#issuecomment-150155800 @steveloughran you mean require something change ? or just potential issue ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: update twitter4j to 4.0.4 version
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/9221#issuecomment-150151459 Looking @ the twitter4j poms, their dependencies pull in a com.googlecode.kryo -given the kryo pain its a possible troublespot. However, that com.googlecode release is so old its in a different package from the com.esotericsoftware-packaged releases Various modules seems to refer to a different junit (3.8.2 in http-2, 4.10 in core, ...), but those are test scoped only. Log4j 1.2.17; SLF4J 1.7.12, commons-logging 1.1 -nothing incompatible with the spark versions, afaik. main [pom.xml](https://github.com/yusuke/twitter4j/blob/master/twitter4j-core/pom.xml) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: update twitter4j to 4.0.4 version
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9221#issuecomment-150138607 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: update twitter4j to 4.0.4 version
GitHub user pronix opened a pull request: https://github.com/apache/spark/pull/9221 update twitter4j to 4.0.4 version update twitter4j to 4.0.4 version https://issues.apache.org/jira/browse/SPARK-11245 You can merge this pull request into a Git repository by running: $ git pull https://github.com/pronix/spark twitter4j_update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/9221.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9221 commit f82a64832e75da04bb2ef83f645352f5a7e93ab1 Author: dima Date: 2015-10-22T07:55:52Z update twitter4j to 4.0.4 version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
