[GitHub] spark pull request #13542: [SPARK-15730][SQL][WIP] Respect the --hiveconf in...

[chenghao-intel]

Github user chenghao-intel commented on a diff in the pull request:

https://github.com/apache/spark/pull/13542#discussion_r66731077
  
--- Diff: 
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
 ---
@@ -91,6 +91,8 @@ class CliSuite extends SparkFunSuite with 
BeforeAndAfterAll with Logging {
  |  --hiveconf ${ConfVars.METASTORECONNECTURLKEY}=$jdbcUrl
  |  --hiveconf ${ConfVars.METASTOREWAREHOUSE}=$warehousePath
  |  --hiveconf ${ConfVars.SCRATCHDIR}=$scratchDirPath
+ |  --hiveconf conf1=conftest
+ |  --hiveconf conf2=1
--- End diff --

yes, it works, that's intention, right?

But seems the below code in `SparkSQLCliDriver` will not work as we 
expected.
```scala
  if (key != "javax.jdo.option.ConnectionURL") {
conf.set(key, value)
sessionState.getOverriddenConfigurations.put(key, value)
  }
```

Why do we have to ignore the connection url? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #13542: [SPARK-15730][SQL][WIP] Respect the --hiveconf in...

[yhuai]

Github user yhuai commented on a diff in the pull request:

https://github.com/apache/spark/pull/13542#discussion_r66678717
  
--- Diff: 
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
 ---
@@ -91,6 +91,8 @@ class CliSuite extends SparkFunSuite with 
BeforeAndAfterAll with Logging {
  |  --hiveconf ${ConfVars.METASTORECONNECTURLKEY}=$jdbcUrl
  |  --hiveconf ${ConfVars.METASTOREWAREHOUSE}=$warehousePath
  |  --hiveconf ${ConfVars.SCRATCHDIR}=$scratchDirPath
+ |  --hiveconf conf1=conftest
+ |  --hiveconf conf2=1
--- End diff --

@chenghao-intel Does `--hiveconf 
${ConfVars.METASTORECONNECTURLKEY}=$jdbcUrl` work?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #13542: [SPARK-15730][SQL][WIP] Respect the --hiveconf in...

[chenghao-intel]

GitHub user chenghao-intel opened a pull request:

https://github.com/apache/spark/pull/13542

[SPARK-15730][SQL][WIP] Respect the --hiveconf in the spark-sql command line

## What changes were proposed in this pull request?

We should respect the --hiveconf in the spark-sql command line, otherwise, 
the existing applications based on the spark 1.6 and earlier will broke, as the 
configurations specified via --hiveconf are missing

## How was this patch tested?
I've added the unit test, but still need to be verified with real 
application.




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chenghao-intel/spark hiveconf

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13542.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13542


commit bbf0ac4da1278722f82abd38b5cc7b0f94f17a60
Author: Cheng Hao 
Date:   2016-06-07T14:55:27Z

respect the --hiveconf in the SparkSQLCliDriver commandline




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org