[GitHub] spark pull request #13569: [SPARK-15791] Fix NPE in ScalarSubquery

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/13569


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #13569: [SPARK-15791] Fix NPE in ScalarSubquery

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13569#discussion_r66563276
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala 
---
@@ -54,6 +54,10 @@ class SubquerySuite extends QueryTest with 
SharedSQLContext {
 t.createOrReplaceTempView("t")
   }
 
+  test("rdd deserialization does not crash [SPARK-15791]") {
+sql("select (select 1 as b) as b").rdd.count()
--- End diff --

+1 

although not that big of a deal, since other tests already cover some 
correctness. I'm going to merge this one to cut down the number of 2.0 blockers.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #13569: [SPARK-15791] Fix NPE in ScalarSubquery

[davies]

Github user davies commented on a diff in the pull request:

https://github.com/apache/spark/pull/13569#discussion_r66561018
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala 
---
@@ -54,6 +54,10 @@ class SubquerySuite extends QueryTest with 
SharedSQLContext {
 t.createOrReplaceTempView("t")
   }
 
+  test("rdd deserialization does not crash [SPARK-15791]") {
+sql("select (select 1 as b) as b").rdd.count()
--- End diff --

Should we check the result?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #13569: [SPARK-15791] Fix NPE in ScalarSubquery

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13569#discussion_r66541796
  
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala 
---
@@ -54,6 +54,10 @@ class SubquerySuite extends QueryTest with 
SharedSQLContext {
 t.createOrReplaceTempView("t")
   }
 
+  test("rdd deserialization does not crash") {
--- End diff --

put the jira number here SPARK-15791


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #13569: [SPARK-15791] Fix NPE in ScalarSubquery

[ericl]

GitHub user ericl opened a pull request:

https://github.com/apache/spark/pull/13569

[SPARK-15791] Fix NPE in ScalarSubquery

## What changes were proposed in this pull request?

The fix is pretty simple, just don't make the executedPlan transient in 
`ScalarSubquery` since it is referenced at execution time.

## How was this patch tested?

I verified the fix manually in non-local mode. It's not clear to me why the 
problem did not manifest in local mode, any suggestions?

cc @davies 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ericl/spark fix-scalar-npe

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13569.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13569


commit 7e2eb6f6f014f5c8ea15343deab205bed59496a1
Author: Eric Liang 
Date:   2016-06-08T22:29:47Z

Wed Jun  8 15:29:47 PDT 2016




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org