[GitHub] spark pull request #13576: [SPARK-15840][SQL] Add two missing options in doc...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13576 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #13576: [SPARK-15840][SQL] Add two missing options in doc...
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13576#discussion_r66569746 --- Diff: python/pyspark/sql/readwriter.py --- @@ -327,6 +334,8 @@ def csv(self, path, schema=None, sep=None, encoding=None, quote=None, escape=Non character. By default (None), it is disabled. :param header: uses the first line as names of columns. If None is set, it uses the default value, ``false``. +:param inferSchema: infers the input schema automatically from data. It requires one extra --- End diff -- Yes, it will be off (so I wrote some comments above). However, thing is about `header`. If `inferSchema` option is removed and it is only enabled when the schema is set, there would be no way to not infer schema (meaning all string columns) but only use column names in the header. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #13576: [SPARK-15840][SQL] Add two missing options in doc...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13576#discussion_r66563599 --- Diff: python/pyspark/sql/readwriter.py --- @@ -327,6 +334,8 @@ def csv(self, path, schema=None, sep=None, encoding=None, quote=None, escape=Non character. By default (None), it is disabled. :param header: uses the first line as names of columns. If None is set, it uses the default value, ``false``. +:param inferSchema: infers the input schema automatically from data. It requires one extra --- End diff -- isn't inferSchema automatically off if schema is set? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #13576: [SPARK-15840][SQL] Add two missing options in doc...
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13576#discussion_r66563370 --- Diff: python/pyspark/sql/readwriter.py --- @@ -207,9 +207,10 @@ def json(self, path, schema=None, primitivesAsString=None, prefersDecimal=None, * ``FAILFAST`` : throws an exception when it meets corrupted records. :param columnNameOfCorruptRecord: allows renaming the new field having malformed string - created by ``PERMISSIVE`` mode. This overrides + created by ``PERMISSIVE`` mode. This overwrites --- End diff -- i think technically "overrides" is more accurate than "overwrites" here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
